From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A28F1AF0AF; Wed, 28 Jan 2026 03:03:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769569409; cv=none; b=LnGv3ofyYvtuZMpAtPiJ529hitayY0+QChlXFc983Lyl6T2ESlKULyW+hrPc+mMjk6jKbODnahpHxnt09Tq5ZrCP7mGC1SxxiechAYEibUd1A2nrfeOsVRHwAHcJekzp1dbzlHiTbPJ9Zee08tdON4Vfp5YGexGyOVa8Z2K42K0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769569409; c=relaxed/simple; bh=NuPmG5cCSn0t4qwwi8kNapz/EY1MPUp1qrbJz4vUVmo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=d+2nbocUe/FaCraFy2/2slt20rQSBkRVCmRaKpJr6B1s43oEQKxFNbSS2Hq+SlTE/BCpQ4EcGRZXv4yBGRnDDkKeL/6FEvNCVUwC2ZCIpVdYo2hiJU6tjoOQ+VKRXzMiT7peAq9jViUmU/gyoDnv9tKx6ugiSvVryok7bw0rfrU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=W5c8wEO6; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="W5c8wEO6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EAE66C116C6; Wed, 28 Jan 2026 03:03:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769569408; bh=NuPmG5cCSn0t4qwwi8kNapz/EY1MPUp1qrbJz4vUVmo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W5c8wEO678/rrHZPIjaXRmN18g+OJ5VWuR/LSHlb2rrSaZNq0tjFngCOai5US7lRK DoKih1bTpnQOoZ6qv/Pkult2ITUbob5l0HitVJu11wPNfU7Vpo77XopGZsWvdOf/IZ j3zB1aGhgPLRfNOVo83p5pHZypFzjShWHlKtblrRf7zk6idxO34WA6k+Kd2UQmHQVK 3T3ks+4XCPmtY4P1CleU8kCPnyuTSwGbVIbawu/5gMVTX3cLmptLSAjp0qiCuTNDdm Vz1zRe6//U0LISvFQ8oUbqoBgXuZicH+ju3kuB2ni/zW+UGutLRxkIsMJiuzFoB3hy Y8JMGFaJRse2A== Date: Tue, 27 Jan 2026 19:03:27 -0800 From: Jakub Kicinski To: "Bastien Curutchet (Schneider Electric)" Cc: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Simon Horman , Pascal Eberhard , =?UTF-8?B?TWlxdcOobA==?= Raynal , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v4 1/8] net: dsa: microchip: Add support for KSZ8463 global irq Message-ID: <20260127190327.79d3f154@kernel.org> In-Reply-To: <20260127-ksz8463-ptp-v4-1-652e021aae86@bootlin.com> References: <20260127-ksz8463-ptp-v4-0-652e021aae86@bootlin.com> <20260127-ksz8463-ptp-v4-1-652e021aae86@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 27 Jan 2026 10:06:43 +0100 Bastien Curutchet (Schneider Electric) wrote: > /* Read interrupt status register */ > - ret = ksz_read8(dev, kirq->reg_status, &data); > + ret = ksz_read16(dev, kirq->reg_status, &data); AI code review points out that we're potentially over-reading here for !ksz_is_ksz8463(kirq->dev), I'm assuming the wider read is okay for all chips? Is this something that'll be obvious to all readers of this code or should we perhaps leave a relevant comment here? (assuming you need to respin, not sure its worth a respin by itself)