From: Vladimir Oltean <olteanv@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Hauke Mehrtens <hauke@hauke-m.de>, Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] dt-bindings: net: dsa: lantiq,gswip: reference common PHY properties
Date: Wed, 28 Jan 2026 00:25:08 +0200 [thread overview]
Message-ID: <20260127222508.gvky6smlrmnj3uix@skbuf> (raw)
In-Reply-To: <aXk38o39i62SIq_K@makrotopia.org>
On Tue, Jan 27, 2026 at 10:10:58PM +0000, Daniel Golle wrote:
> Taking a step back I noticed that we need to decide this also for
> mt7530.
>
> commit bde1ae2d52ab ("net: pcs: pcs-mtk-lynxi: pass SGMIISYS OF node to PCS")
> currently doesn't pass any fwnode when creating the LynxI PCS.
> > + pcs = mtk_pcs_lynxi_create(priv->dev, NULL, regmap,
> > + MT7531_PHYA_CTRL_SIGNAL3);
>
> However, each PCS does belong to a specific switch port, and it would be
> advantegous and imho consistent to also assign the ports OF node to the
> PCS, this would allow to configure the polarities also on the MT7530
> SerDes ports.
mt753x_phylink_mac_select_pcs() returns either &priv->pcs[dp->index].pcs
for TRGMII or priv->ports[dp->index].sgmii_pcs for the rest.
How would one know (generally speaking) if properties placed in the
ethernet-port node are for the SGMII PCS or for the other one?
next prev parent reply other threads:[~2026-01-27 22:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 13:18 [PATCH net-next 0/3] net: dsa: mxl-gsw1xx: setup polarities and validate chip Daniel Golle
2026-01-27 13:18 ` [PATCH net-next 1/3] dt-bindings: net: dsa: lantiq,gswip: reference common PHY properties Daniel Golle
2026-01-27 13:29 ` Vladimir Oltean
2026-01-27 14:07 ` Daniel Golle
2026-01-27 15:07 ` Vladimir Oltean
2026-01-27 22:10 ` Daniel Golle
2026-01-27 22:25 ` Vladimir Oltean [this message]
2026-01-28 1:47 ` Daniel Golle
2026-01-27 15:21 ` Andrew Lunn
2026-01-27 16:22 ` Daniel Golle
2026-01-27 13:18 ` [PATCH net-next 2/3] net: dsa: mxl-gsw1xx: configure PCS polarities Daniel Golle
2026-01-27 13:25 ` Vladimir Oltean
2026-01-27 13:18 ` [PATCH net-next 3/3] net: dsa: mxl-gsw1xx: validate chip ID Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260127222508.gvky6smlrmnj3uix@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hauke@hauke-m.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox