[PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

[PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

[javen]

From: Javen Xu <javen_xu@realsil.com.cn>

This series patch add a fake driver r816e to ensure the kernel could set the
correct power state for #fun through r816e driver when suspending.

Javen Xu (3):
  r816e: add a fake driver r816e for RTL8116af
  r816e: Add a Makefile in the r816e folder
  realtek: Update Makefile and Kconfig

 drivers/net/ethernet/realtek/Kconfig        |  7 ++
 drivers/net/ethernet/realtek/Makefile       |  1 +
 drivers/net/ethernet/realtek/r816e/Makefile |  8 +++
 drivers/net/ethernet/realtek/r816e/r816e.c  | 75 +++++++++++++++++++++
 4 files changed, 91 insertions(+)
 create mode 100644 drivers/net/ethernet/realtek/r816e/Makefile
 create mode 100644 drivers/net/ethernet/realtek/r816e/r816e.c

-- 
2.43.0

[PATCH net-next v1 1/3] r816e: add a fake driver r816e for RTL8116af

[javen]

From: Javen Xu <javen_xu@realsil.com.cn>

The driver is for the #fun which DID is 0x816e. The kernel could set
correct power state for #fun through the driver when suspending.

Signed-off-by: Javen Xu <javen_xu@realsil.com.cn>
---
 drivers/net/ethernet/realtek/r816e/r816e.c | 75 ++++++++++++++++++++++
 1 file changed, 75 insertions(+)
 create mode 100644 drivers/net/ethernet/realtek/r816e/r816e.c

diff --git a/drivers/net/ethernet/realtek/r816e/r816e.c b/drivers/net/ethernet/realtek/r816e/r816e.c
new file mode 100644
index 000000000000..71674019de2c
--- /dev/null
+++ b/drivers/net/ethernet/realtek/r816e/r816e.c
@@ -0,0 +1,75 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ *  r816e is the Linux device driver released for Realtek RTL8116AF nic
+ *  with PCI-Express interface, which is used for power management.
+ *
+ *  Copyright(c) 2026 Realtek Semiconductor Corp.
+ */
+
+#include <linux/module.h>
+#include <linux/version.h>
+#include <linux/pci.h>
+#include <linux/init.h>
+
+static struct pci_device_id rtl816e_pci_tbl[] = {
+	{ PCI_VDEVICE(REALTEK, 0x816e), },
+	{ 0, },
+};
+
+MODULE_DEVICE_TABLE(pci, rtl816e_pci_tbl);
+
+static int rtl816e_probe(struct pci_dev *pdev,
+			 const struct pci_device_id *ent)
+{
+	int rc;
+
+	/* enable device (incl. PCI PM wakeup and hotplug setup) */
+	rc = pcim_enable_device(pdev);
+	if (rc < 0)
+		return dev_err_probe(&pdev->dev, rc, "enable failure\n");
+
+	dev_info(&pdev->dev, "enable device\n");
+
+	return rc;
+}
+
+static void rtl816e_remove(struct pci_dev *pdev) {}
+
+static int rtl816e_pm_suspend(struct device *device)
+{
+	return 0;
+}
+
+static int rtl816e_pm_resume(struct device *device)
+{
+	return 0;
+}
+
+static const struct dev_pm_ops rtl816e_pm_ops = {
+	SYSTEM_SLEEP_PM_OPS(rtl816e_pm_suspend, rtl816e_pm_resume)
+};
+
+static struct pci_driver rtl816e_pci_driver = {
+	.name		= "r816e",
+	.id_table	= rtl816e_pci_tbl,
+	.probe		= rtl816e_probe,
+	.remove		= rtl816e_remove,
+#ifdef CONFIG_PM
+	.driver.pm  = pm_ptr(&rtl816e_pm_ops),
+#endif
+};
+
+static int __init rtl816e_init_module(void)
+{
+	return pci_register_driver(&rtl816e_pci_driver);
+}
+
+static void __exit rtl816e_cleanup_module(void)
+{
+	pci_unregister_driver(&rtl816e_pci_driver);
+}
+
+module_init(rtl816e_init_module);
+module_exit(rtl816e_cleanup_module);
+MODULE_LICENSE("GPL");
+MODULE_DESCRIPTION("RealTek RTL816E driver");
-- 
2.43.0

Re: [PATCH net-next v1 1/3] r816e: add a fake driver r816e for RTL8116af

[kernel test robot]

Hi javen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/javen/r816e-add-a-fake-driver-r816e-for-RTL8116af/20260127-193831
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260127113425.1989-2-javen_xu%40realsil.com.cn
patch subject: [PATCH net-next v1 1/3] r816e: add a fake driver r816e for RTL8116af
reproduce: (https://download.01.org/0day-ci/archive/20260127/202601271822.HvRlrxlv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601271822.HvRlrxlv-lkp@intel.com/

versioncheck warnings: (new ones prefixed by >>)
   INFO PATH=/opt/cross/rustc-1.88.0-bindgen-0.72.1/cargo/bin:/opt/cross/clang-20/bin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
   /usr/bin/timeout -k 100 3h /usr/bin/make KCFLAGS= -fno-crash-diagnostics -Wno-error=return-type -Wreturn-type -funsigned-char -Wundef -falign-functions=64 W=1 --keep-going LLVM=1 -j32 ARCH=x86_64 versioncheck
   find ./* \( -name SCCS -o -name BitKeeper -o -name .svn -o -name CVS -o -name .pc -o -name .hg -o -name .git \) -prune -o \
   	-name '*.[hcS]' -type f -print | sort \
   	| xargs perl -w ./scripts/checkversion.pl
>> ./drivers/net/ethernet/realtek/r816e/r816e.c: 10 linux/version.h not needed.
   ./samples/bpf/spintest.bpf.c: 8 linux/version.h not needed.
   ./tools/lib/bpf/bpf_helpers.h: 449: need linux/version.h
   ./tools/testing/selftests/bpf/progs/dev_cgroup.c: 9 linux/version.h not needed.
   ./tools/testing/selftests/bpf/progs/netcnt_prog.c: 3 linux/version.h not needed.
   ./tools/testing/selftests/bpf/progs/test_map_lock.c: 4 linux/version.h not needed.
   ./tools/testing/selftests/bpf/progs/test_send_signal_kern.c: 4 linux/version.h not needed.
   ./tools/testing/selftests/bpf/progs/test_spin_lock.c: 4 linux/version.h not needed.
   ./tools/testing/selftests/bpf/progs/test_tcp_estats.c: 37 linux/version.h not needed.
   ./tools/testing/selftests/wireguard/qemu/init.c: 27 linux/version.h not needed.

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH net-next v1 2/3] r816e: Add a Makefile in the r816e folder

[javen]

From: Javen Xu <javen_xu@realsil.com.cn>

Add a Makefile in the r816e folder to build r816e driver.

Signed-off-by: Javen Xu <javen_xu@realsil.com.cn>
---
 drivers/net/ethernet/realtek/r816e/Makefile | 8 ++++++++
 1 file changed, 8 insertions(+)
 create mode 100644 drivers/net/ethernet/realtek/r816e/Makefile

diff --git a/drivers/net/ethernet/realtek/r816e/Makefile b/drivers/net/ethernet/realtek/r816e/Makefile
new file mode 100644
index 000000000000..0f028c7ce7bf
--- /dev/null
+++ b/drivers/net/ethernet/realtek/r816e/Makefile
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
+# Copyright(c) 2026 Realtek Semiconductor Corp. All rights reserved.
+
+#
+# Makefile for the Realtek R816E power management driver
+#
+
+obj-$(CONFIG_R816E) += r816e.o
-- 
2.43.0

[PATCH net-next v1 3/3] realtek: Update Makefile and Kconfig

[javen]

From: Javen Xu <javen_xu@realsil.com.cn>

This patch adds the R816E entry in the Kconfig and adds the CONFIG_R816E
entry in the Makefile.

Signed-off-by: Javen Xu <javen_xu@realsil.com.cn>
---
 drivers/net/ethernet/realtek/Kconfig  | 7 +++++++
 drivers/net/ethernet/realtek/Makefile | 1 +
 2 files changed, 8 insertions(+)

diff --git a/drivers/net/ethernet/realtek/Kconfig b/drivers/net/ethernet/realtek/Kconfig
index 9b0f4f9631db..f2d7edaf299d 100644
--- a/drivers/net/ethernet/realtek/Kconfig
+++ b/drivers/net/ethernet/realtek/Kconfig
@@ -126,4 +126,11 @@ config RTASE
 	  To compile this driver as a module, choose M here: the module
 	  will be called rtase. This is recommended.
 
+config R816E
+	tristate "Realtek RTL8116AF power management support"
+	depends on PCI
+	help
+	  Say Y here and it will be complied to ensure the device enters correct
+	  power state if you have Realtek PCIe nic RTL8116AF.
+
 endif # NET_VENDOR_REALTEK
diff --git a/drivers/net/ethernet/realtek/Makefile b/drivers/net/ethernet/realtek/Makefile
index 12a9c399f40c..c027667df74f 100644
--- a/drivers/net/ethernet/realtek/Makefile
+++ b/drivers/net/ethernet/realtek/Makefile
@@ -9,3 +9,4 @@ r8169-y += r8169_main.o r8169_firmware.o r8169_phy_config.o
 r8169-$(CONFIG_R8169_LEDS) += r8169_leds.o
 obj-$(CONFIG_R8169) += r8169.o
 obj-$(CONFIG_RTASE) += rtase/
+obj-$(CONFIG_R816E) += r816e/
-- 
2.43.0

Re: [PATCH net-next v1 3/3] realtek: Update Makefile and Kconfig

[kernel test robot]

Hi javen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/javen/r816e-add-a-fake-driver-r816e-for-RTL8116af/20260127-193831
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260127113425.1989-4-javen_xu%40realsil.com.cn
patch subject: [PATCH net-next v1 3/3] realtek: Update Makefile and Kconfig
config: s390-allmodconfig (https://download.01.org/0day-ci/archive/20260128/202601280645.owh2ZlCS-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260128/202601280645.owh2ZlCS-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601280645.owh2ZlCS-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/realtek/r816e/r816e.c:48:32: warning: unused variable 'rtl816e_pm_ops' [-Wunused-const-variable]
      48 | static const struct dev_pm_ops rtl816e_pm_ops = {
         |                                ^~~~~~~~~~~~~~
   1 warning generated.


vim +/rtl816e_pm_ops +48 drivers/net/ethernet/realtek/r816e/r816e.c

638d27c0a2f682 Javen Xu 2026-01-27  47  
638d27c0a2f682 Javen Xu 2026-01-27 @48  static const struct dev_pm_ops rtl816e_pm_ops = {
638d27c0a2f682 Javen Xu 2026-01-27  49  	SYSTEM_SLEEP_PM_OPS(rtl816e_pm_suspend, rtl816e_pm_resume)
638d27c0a2f682 Javen Xu 2026-01-27  50  };
638d27c0a2f682 Javen Xu 2026-01-27  51  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH net-next v1 3/3] realtek: Update Makefile and Kconfig

[kernel test robot]

Hi javen,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/javen/r816e-add-a-fake-driver-r816e-for-RTL8116af/20260127-193831
base:   net-next/main
patch link:    https://lore.kernel.org/r/20260127113425.1989-4-javen_xu%40realsil.com.cn
patch subject: [PATCH net-next v1 3/3] realtek: Update Makefile and Kconfig
config: openrisc-allmodconfig (https://download.01.org/0day-ci/archive/20260128/202601280610.ncyvilQz-lkp@intel.com/config)
compiler: or1k-linux-gcc (GCC) 15.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260128/202601280610.ncyvilQz-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202601280610.ncyvilQz-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/realtek/r816e/r816e.c:48:32: warning: 'rtl816e_pm_ops' defined but not used [-Wunused-const-variable=]
      48 | static const struct dev_pm_ops rtl816e_pm_ops = {
         |                                ^~~~~~~~~~~~~~


vim +/rtl816e_pm_ops +48 drivers/net/ethernet/realtek/r816e/r816e.c

638d27c0a2f682 Javen Xu 2026-01-27  47  
638d27c0a2f682 Javen Xu 2026-01-27 @48  static const struct dev_pm_ops rtl816e_pm_ops = {
638d27c0a2f682 Javen Xu 2026-01-27  49  	SYSTEM_SLEEP_PM_OPS(rtl816e_pm_suspend, rtl816e_pm_resume)
638d27c0a2f682 Javen Xu 2026-01-27  50  };
638d27c0a2f682 Javen Xu 2026-01-27  51  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

[Heiner Kallweit]

On 1/27/2026 12:34 PM, javen wrote:
> From: Javen Xu <javen_xu@realsil.com.cn>
> 
> This series patch add a fake driver r816e to ensure the kernel could set the
> correct power state for #fun through r816e driver when suspending.
> 

I think a better approach would be to contribute to adding phylink/sfp
support to r8169, so that the SFP NIC versions (incl. RTL8116AF) can be
properly supported. This would have to include making the SFP I2C bus
accessible by the kernel (instead of firmware only).

> Javen Xu (3):
>   r816e: add a fake driver r816e for RTL8116af
>   r816e: Add a Makefile in the r816e folder
>   realtek: Update Makefile and Kconfig
> 
>  drivers/net/ethernet/realtek/Kconfig        |  7 ++
>  drivers/net/ethernet/realtek/Makefile       |  1 +
>  drivers/net/ethernet/realtek/r816e/Makefile |  8 +++
>  drivers/net/ethernet/realtek/r816e/r816e.c  | 75 +++++++++++++++++++++
>  4 files changed, 91 insertions(+)
>  create mode 100644 drivers/net/ethernet/realtek/r816e/Makefile
>  create mode 100644 drivers/net/ethernet/realtek/r816e/r816e.c
> 

RE: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

[javen]

>On 1/27/2026 12:34 PM, javen wrote:
>> From: Javen Xu <javen_xu@realsil.com.cn>
>>
>> This series patch add a fake driver r816e to ensure the kernel could 
>> set the correct power state for #fun through r816e driver when suspending.
>>
>
> I think a better approach would be to contribute to adding phylink/sfp support
> to r8169, so that the SFP NIC versions (incl. RTL8116AF) can be properly
> supported. This would have to include making the SFP I2C bus accessible by
> the kernel (instead of firmware only).
>

RTL8116af is a multi-function device. fun0 is a BMC virtual driver and fun1 is
the nic driver. The BMC virtual driver(fun0) is used for power management,
while fun1 provides the actual network functionality.

Thanks,
Javen Xu
>> Javen Xu (3):
>>   r816e: add a fake driver r816e for RTL8116af
>>   r816e: Add a Makefile in the r816e folder
>>   realtek: Update Makefile and Kconfig
>>
>>  drivers/net/ethernet/realtek/Kconfig        |  7 ++
>>  drivers/net/ethernet/realtek/Makefile       |  1 +
>>  drivers/net/ethernet/realtek/r816e/Makefile |  8 +++  
>> drivers/net/ethernet/realtek/r816e/r816e.c  | 75 +++++++++++++++++++++
>>  4 files changed, 91 insertions(+)
>>  create mode 100644 drivers/net/ethernet/realtek/r816e/Makefile
>>  create mode 100644 drivers/net/ethernet/realtek/r816e/r816e.c
>>

Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

[Andrew Lunn]

> RTL8116af is a multi-function device. fun0 is a BMC virtual driver and fun1 is
> the nic driver. The BMC virtual driver(fun0) is used for power management,
> while fun1 provides the actual network functionality.

This is the sort of thing which should be in patch 0/X, because at the
moment, this patch series makes no sense to me. You need to explain
the big picture, especially when doing something so odd.

What does this BMC virtual driver do? Is it providing an NCSI like
device? Should it have a real driver at some point in the future, more
than this stub?

> >>   r816e: add a fake driver r816e for RTL8116af

Please could you explain the naming. The device is RTL8116af, yet the
files are r816e.c ?

	Andrew

Re: [PATCH net-next v1 0/3] r816e: Add r816e driver in Realtek

[Heiner Kallweit]

On 1/28/2026 7:53 AM, javen wrote:
>> On 1/27/2026 12:34 PM, javen wrote:
> 
>>> From: Javen Xu <javen_xu@realsil.com.cn>
> 
>>>
> 
>>> This series patch add a fake driver r816e to ensure the kernel could 
> 
>>> set the correct power state for #fun through r816e driver when suspending.
> 
>>>
> 
>>
> 
>> I think a better approach would be to contribute to adding phylink/sfp support
> 
>> to r8169, so that the SFP NIC versions (incl. RTL8116AF) can be properly
> 
>> supported. This would have to include making the SFP I2C bus accessible by
> 
>> the kernel (instead of firmware only).
> 
>>
> 
> 
> 
> RTL8116af is a multi-function device. fun0 is a BMC virtual driver and fun1 is
> 
> the nic driver. The BMC virtual driver(fun0) is used for power management,
> 
> while fun1 provides the actual network functionality.
> 
> 
If only purpose of this dummy driver is to bring the device to D3hot during system
suspend, then this may be a question to the PCI subsystem maintainer(s).
PCI devices are instantiated by the PCI core, just that in case of the device here
no driver gets attached. Still PCI core applies a default suspend handling to each
device.