From: Leon Romanovsky <leon@kernel.org>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Ilan Tayari <ilant@mellanox.com>,
Guy Shapiro <guysh@mellanox.com>,
Yossi Kuperman <yossiku@mellanox.com>,
Network Development <netdev@vger.kernel.org>,
Sabrina Dubroca <sd@queasysnail.net>
Subject: Re: [PATCH net] xfrm: always flush state and policy upon NETDEV_DOWN/NETDEV_UNREGISTER events
Date: Wed, 28 Jan 2026 14:35:46 +0200 [thread overview]
Message-ID: <20260128123546.GC40916@unreal> (raw)
In-Reply-To: <83d06aca-4437-4d61-9c99-ac19b797a243@I-love.SAKURA.ne.jp>
On Wed, Jan 28, 2026 at 07:44:02PM +0900, Tetsuo Handa wrote:
> On 2026/01/28 19:24, Leon Romanovsky wrote:
> > I think this can work, but IMHO the more robust approach is to ensure that all
> > states and policies are removed when the NETIF_F_HW_ESP feature bit is cleared.
>
> The transaction will become complicated, for dev->features manipulation
> function can fail.
Line above returning NOTIFY_OK, check that NETIF_F_HW_ESP is cleared,
and remove everything.
>
> >
> > Would it be possible to handle this in NETDEV_FEAT_CHANGE?
> >
>
> Is there a guarantee that xfrm_dev_event(NETDEV_FEAT_CHANGE) is called
> regardless of other callback functions, for it can return NOTIFY_BAD ?
I don't know.
Thanks
>
>
next prev parent reply other threads:[~2026-01-28 12:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 15:32 [PATCH net] xfrm: always flush state and policy upon NETDEV_DOWN/NETDEV_UNREGISTER events Tetsuo Handa
2026-01-28 10:24 ` Leon Romanovsky
2026-01-28 10:44 ` Tetsuo Handa
2026-01-28 12:35 ` Leon Romanovsky [this message]
2026-01-29 8:06 ` Tetsuo Handa
2026-01-29 9:09 ` Leon Romanovsky
2026-01-29 10:16 ` Tetsuo Handa
2026-01-29 10:32 ` Tetsuo Handa
2026-01-29 16:05 ` Sabrina Dubroca
2026-02-01 13:12 ` Leon Romanovsky
2026-02-01 14:17 ` Tetsuo Handa
2026-01-29 15:59 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128123546.GC40916@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guysh@mellanox.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=ilant@mellanox.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=sd@queasysnail.net \
--cc=steffen.klassert@secunet.com \
--cc=yossiku@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox