From: "Łukasz Majewski" <lukasz.majewski@mailbox.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Jakub Kicinski <kuba@kernel.org>,
festevam@gmail.com, linux-arm-kernel@lists.infradead.org,
s.hauer@pengutronix.de, kernel@pengutronix.de, horms@kernel.org,
shawnguo@kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, wahrenst@gmx.net, pabeni@redhat.com,
davem@davemloft.net, netdev@vger.kernel.org,
richardcochran@gmail.com, edumazet@google.com,
andrew+netdev@lunn.ch, robh@kernel.org, krzk+dt@kernel.org
Subject: Re: [net-next,v20,2/7] net: mtip: The L2 switch driver for imx287
Date: Wed, 28 Jan 2026 23:47:36 +0100 [thread overview]
Message-ID: <20260128234736.49bd70b3@wsk> (raw)
In-Reply-To: <ed0e1af1-0210-4461-8939-3e4e35d74dae@lunn.ch>
Hi Andrew,
> On Wed, Jan 28, 2026 at 10:41:25PM +0100, Łukasz Majewski wrote:
> > Hi Jakub,
> >
> > > This is an AI-generated review
> >
> > AI is going to take the "Maintainer's" job :D
>
> We had a bit of a discussion about this.
>
> Our observations so far is that AI finds different sorts of issues,
> which human reviewer often don't spot. It also does get things wrong,
> so we spend some time sanity checking its reports. So overall, it
> might actually increase the workload, but also increase the quality of
> the code which gets committed.
>
Frankly - from the MTIP L2 switch patch set review - the AI review does
a _really_ good job ...
It finds non trivial issues - with very deep insights to function's
call dependencies.
> Andrew
--
Best regards,
Łukasz Majewski
next prev parent reply other threads:[~2026-01-28 22:47 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:33 [net-next v20 0/7] net: mtip: Add support for MTIP imx287 L2 switch driver Lukasz Majewski
2026-01-26 10:33 ` [net-next v20 1/7] dt-bindings: net: Add MTIP L2 switch description Lukasz Majewski
2026-01-26 10:33 ` [net-next v20 2/7] net: mtip: The L2 switch driver for imx287 Lukasz Majewski
2026-01-28 2:25 ` [net-next,v20,2/7] " Jakub Kicinski
2026-01-28 21:41 ` Łukasz Majewski
2026-01-28 22:00 ` Andrew Lunn
2026-01-28 22:47 ` Łukasz Majewski [this message]
2026-01-26 10:33 ` [net-next v20 3/7] net: mtip: Add buffers management functions to the L2 switch driver Lukasz Majewski
2026-01-28 2:25 ` [net-next,v20,3/7] " Jakub Kicinski
2026-01-28 21:48 ` Łukasz Majewski
2026-01-26 10:33 ` [net-next v20 4/7] net: mtip: Add net_device_ops " Lukasz Majewski
2026-01-28 2:25 ` [net-next,v20,4/7] " Jakub Kicinski
2026-01-28 21:55 ` Łukasz Majewski
2026-01-29 2:05 ` Jakub Kicinski
2026-01-26 10:33 ` [net-next v20 5/7] net: mtip: Add mtip_switch_{rx|tx} " Lukasz Majewski
2026-01-26 10:33 ` [net-next v20 6/7] net: mtip: Extend the L2 switch driver with management operations Lukasz Majewski
2026-01-26 10:34 ` [net-next v20 7/7] net: mtip: Extend the L2 switch driver for imx287 with bridge operations Lukasz Majewski
2026-01-28 2:26 ` [net-next,v20,7/7] " Jakub Kicinski
2026-01-28 22:58 ` Łukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260128234736.49bd70b3@wsk \
--to=lukasz.majewski@mailbox.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=horms@kernel.org \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox