Re: [net-next] amd-xgbe: add support rx alignment and length errors

[Jakub Kicinski <kuba@kernel.org>]

This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.

For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
amd-xgbe: add support rx alignment and length errors

This patch adds support for reading rx alignment errors from the hardware
MMC registers and updates the rtnl_link_stats64 structure.

> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> index b5a60a048896..ebc5fe8324ea 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-drv.c
> @@ -1838,6 +1838,8 @@ static void xgbe_get_stats64(struct net_device *netdev,
>  	s->rx_length_errors = pstats->rxlengtherror;
>  	s->rx_crc_errors = pstats->rxcrcerror;
>  	s->rx_over_errors = pstats->rxfifooverflow;
> +	s->rx_frame_errors = pstats->rxalignmenterror;
> +	s->rx_length_errors = pstats->rxlengtherror;

Is this line a duplicate? The assignment to s->rx_length_errors already
appears three lines above. Perhaps this was intended to be a different
assignment?
-- 
pw-bot: cr