From: Jakub Kicinski <kuba@kernel.org>
To: Antony Antony <antony.antony@secunet.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
<netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Shuah Khan <shuah@kernel.org>, <devel@linux-ipsec.org>,
<linux-kselftest@vger.kernel.org>,
Tobias Brunner <tobias@strongswan.org>,
Simon Horman <horms@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/2] selftests: net: add ICMP error source address test over xfrm tunnel
Date: Thu, 29 Jan 2026 18:43:18 -0800 [thread overview]
Message-ID: <20260129184318.53b1dabf@kernel.org> (raw)
In-Reply-To: <af9a189bee31f7d8f3759ed71d09ab5a82437592.1769595011.git.antony.antony@secunet.com>
On Wed, 28 Jan 2026 11:20:45 +0100 Antony Antony wrote:
> Test that ICMP error messages generated by an IPsec gateway use
> the correct source address (the gateway's address, not the
> unreachable destination).
could you check / fix shellcheck warnings?
+In xfrm_state.sh line 115:
+ $ksft_skip)
+ ^--------^ SC2254 (warning): Quote expansions in case patterns to match literally rather than as a glob.
+In xfrm_state.sh line 157:
+ [ -n "${NS_R1}" ] && ns_r1="ip netns exec ${NS_R1}" && ns_active="${ns_active} $NS_R1"
+ ^---^ SC2034 (warning): ns_r1 appears unused. Verify use (or export if used externally).
+
+
+In xfrm_state.sh line 162:
+ [ -n "${NS_B}" ] && ns_b="ip netns exec ${NS_B}" && ns_active="${ns_active} $NS_B"
+ ^--^ SC2034 (warning): ns_b appears unused. Verify use (or export if used externally).
+In xfrm_state.sh line 166:
+ local ns_cmd=$(nscmd $1)
+ ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
--
pw-bot: cr
next prev parent reply other threads:[~2026-01-30 2:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 10:19 [PATCH net-next v4 0/2] icmp: Fix icmp error source address over xfrm tunnel Antony Antony
2026-01-28 10:20 ` [PATCH net-next v4 2/2] selftests: net: add ICMP error source address test " Antony Antony
2026-01-30 2:43 ` Jakub Kicinski [this message]
2026-02-02 12:15 ` [devel-ipsec] " Antony Antony
2026-01-28 10:25 ` [PATCH net-next v4 1/2] icmp: fix ICMP error source address when xfrm policy matches Antony Antony
2026-01-30 2:45 ` Jakub Kicinski
2026-02-02 12:07 ` [devel-ipsec] " Antony Antony
2026-02-02 14:53 ` Paul Wouters
2026-02-02 15:16 ` Tobias Brunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260129184318.53b1dabf@kernel.org \
--to=kuba@kernel.org \
--cc=antony.antony@secunet.com \
--cc=davem@davemloft.net \
--cc=devel@linux-ipsec.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=tobias@strongswan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox