public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Chan <michael.chan@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
	pabeni@redhat.com, andrew+netdev@lunn.ch, horms@kernel.org,
	pavan.chebbi@broadcom.com, asml.silence@gmail.com
Subject: Re: [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW
Date: Thu, 29 Jan 2026 18:51:19 -0800	[thread overview]
Message-ID: <20260129185119.3182f59a@kernel.org> (raw)
In-Reply-To: <CACKFLi=bzz+HcTGO+fKXEwpxPMN_9fYndmFDnKfBqcKC1RnQDg@mail.gmail.com>

On Thu, 29 Jan 2026 18:36:07 -0800 Michael Chan wrote:
> On Thu, Jan 29, 2026 at 6:23 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > On Wed, 28 Jan 2026 11:32:58 -0800 Jakub Kicinski wrote:  
> > > The driver now depends on the core to tell it what the rx page size
> > > should be for the agg ring. We must populate the ndo_default_qcfg
> > > callback even if we don't support any queue ops.
> > >
> > > This fixes:
> > >   Oops: divide error: 0000 [#1] SMP DEBUG_PAGEALLOC KASAN
> > >   RIP: 0010:bnxt_alloc_rx_page_pool (drivers/net/ethernet/broadcom/bnxt/bnxt.c:3852)
> > >
> > > with fw version 225.1.109.0.
> > >
> > > Link: https://lore.kernel.org/20250421222827.283737-20-kuba@kernel.org
> > > Fixes: f96e1b35779e ("eth: bnxt: support qcfg provided rx page size")
> > > Signed-off-by: Jakub Kicinski <kuba@kernel.org>  
> >
> > Can I get an ack here? This prevents machines from booting so
> > it'd be great to fix before too many people waste their time.  
> 
> Yes, it looks good to me.  Thanks.
> Reviewed-by: Michael Chan <michael.chan@broadcom.com>

Thank you!

  reply	other threads:[~2026-01-30  2:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 19:32 [PATCH net-next] eth: bnxt: make sure we populate the qcfg defaults on old FW/HW Jakub Kicinski
2026-01-30  2:23 ` Jakub Kicinski
2026-01-30  2:36   ` Michael Chan
2026-01-30  2:51     ` Jakub Kicinski [this message]
2026-01-30  3:00 ` patchwork-bot+netdevbpf
2026-01-30 10:38 ` Pavel Begunkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129185119.3182f59a@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=asml.silence@gmail.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.chebbi@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox