From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0FE4366565; Fri, 30 Jan 2026 04:00:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769745618; cv=none; b=sB1P9vDoIq9si76IiA7rQoz67gyud4SgUWQg7F+8WPiyNRUDaSb/i4NGvlJDZy13maPemPRgds9A9gLfZkuhyNIyxpUj/vVc28KmecpbeI3cRfQqL/fy9D5qOCvO6EQtveYA/Qv5NRrh2+hS5jlMTflyoT2ytiN5jIXZUyQQ6RE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769745618; c=relaxed/simple; bh=I7bre0Oy+P+gB8UF2lL4L2MjU4tkQEwcT3SYMz2fgLU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=LFs9BdIz2ICRRfZiHol8AKkfMClj1ilgSGD8A8nL82hNma6oF3B741TIKESqarS8JKtnsoWMajbFf0lQ08FP6/gaZqBc4QqFdBBr1k++0dP9OC3zfK4vgSkuhQ+5Om0j+FVue2FyQFhuv15Abg0b1U52+4zAO+LFIw9UjGbEK34= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y9IK7izv; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y9IK7izv" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 502D3C4CEF7; Fri, 30 Jan 2026 04:00:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769745618; bh=I7bre0Oy+P+gB8UF2lL4L2MjU4tkQEwcT3SYMz2fgLU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y9IK7izvEYA+znAowwVBRaVxWezmGITXL3ZZQkoCGt5JIQNGE8FQtrg0pylwfDOp8 bsyMwzekdZoIeN3JVvvc1Rf09graMQaWHPGpWC9qFIHT340ZYNNp6DgDLVGE7G+z1N D1x/KTwrHaYqH/pLgHSNubkpLuvX47Ozcew/WSvFweBApGFGtwHP2BJ2hNovxAoGsU pYobbIEmabwQMM/SDKUyzTEyEXOvtgCCb5g2GeXOTZZuNfQTICrDzyH2ZPl8JzEIEM C2M9jblvlOQhlLOSQW8rixNBarKRURqaw0mdVygqngPUYm9XfUUYSO4o6L9UgdSUaX Kp2WHDRYiFx2A== From: Jakub Kicinski To: maxime.chevallier@bootlin.com Cc: Jakub Kicinski , daniel@makrotopia.org, christophe.leroy@csgroup.eu, kabel@kernel.org, kory.maincent@bootlin.com, f.fainelli@gmail.com, vladimir.oltean@nxp.com, netdev@vger.kernel.org, horms@kernel.org, mwojtas@chromium.org, o.rempel@pengutronix.de, romain.gantois@bootlin.com, herve.codina@bootlin.com, dimitri.fedrau@liebherr.com, hkallweit1@gmail.com, nicveronese@gmail.com, linux-kernel@vger.kernel.org, edumazet@google.com, pabeni@redhat.com, thomas.petazzoni@bootlin.com, andrew@lunn.ch, davem@davemloft.net, linux@armlinux.org.uk Subject: Re: [net-next,v2,09/12] net: phy: phy_port: Store information about a MII port's occupancy Date: Thu, 29 Jan 2026 20:00:16 -0800 Message-ID: <20260130040016.707823-1-kuba@kernel.org> X-Mailer: git-send-email 2.52.0 In-Reply-To: <20260128204526.170927-10-maxime.chevallier@bootlin.com> References: <20260128204526.170927-10-maxime.chevallier@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit This is an AI-generated review of your patch. The human sending this email has considered the AI review valid, or at least plausible. For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html --- net: phy: phy_port: Store information about a MII port's occupancy This patch adds an "occupied" bitfield to struct phy_port to track whether an MII port has an SFP module inserted. The field is set in connect_nophy callbacks and cleared in disconnect_nophy callbacks. > diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c > index 21af1dffa837..bb257e91cdf6 100644 > --- a/drivers/net/phy/phylink.c > +++ b/drivers/net/phy/phylink.c [ ... ] > @@ -4047,6 +4047,8 @@ static int phylink_sfp_connect_nophy(void *upstream) > } > } > > + pl->sfp_bus_port->occupied = true; Note that phylink_sfp_connect_nophy() has a NULL check for sfp_bus_port at the start of the function that returns early if it is NULL. > + > pl->mod_port = port; > > return 0; > @@ -4056,6 +4058,8 @@ static void phylink_sfp_disconnect_nophy(void *upstream) > { > struct phylink *pl = upstream; > > + pl->sfp_bus_port->occupied = false; Can this dereference a NULL pointer? When phylink is created with PHYLINK_DEV type (rather than PHYLINK_NETDEV), pl->netdev is NULL and phylink_create_sfp_port() returns early without setting sfp_bus_port. The callbacks are still registered via sfp_bus_add_upstream(), so when a PHY-less SFP module is later inserted and removed, this function would be called with sfp_bus_port being NULL. The connect function checks for NULL sfp_bus_port, but the disconnect function does not. Should this have a similar guard? > + > if (pl->netdev) > phy_link_topo_del_port(pl->netdev, pl->mod_port);