* [PATCH net-next] net: can: ctucanfd: remove useless copy of PCI_DEVICE_DATA macro
@ 2026-01-30 11:41 Ethan Nelson-Moore
2026-01-31 15:25 ` Marc Kleine-Budde
0 siblings, 1 reply; 2+ messages in thread
From: Ethan Nelson-Moore @ 2026-01-30 11:41 UTC (permalink / raw)
To: netdev, linux-can
Cc: Ethan Nelson-Moore, Pavel Pisa, Ondrej Ille, Marc Kleine-Budde,
Vincent Mailhol
The ctucanfd driver has its own copy of the PCI_DEVICE_DATA macro. I
assume this was done to support older kernel versions where it didn't
exist, but that is irrelevant once the driver is in the mainline
kernel. Remove it.
Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
---
drivers/net/can/ctucanfd/ctucanfd_pci.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/net/can/ctucanfd/ctucanfd_pci.c b/drivers/net/can/ctucanfd/ctucanfd_pci.c
index 9da09e7dd63a..35edac9c0a5c 100644
--- a/drivers/net/can/ctucanfd/ctucanfd_pci.c
+++ b/drivers/net/can/ctucanfd/ctucanfd_pci.c
@@ -22,14 +22,6 @@
#include "ctucanfd.h"
-#ifndef PCI_DEVICE_DATA
-#define PCI_DEVICE_DATA(vend, dev, data) \
-.vendor = PCI_VENDOR_ID_##vend, \
-.device = PCI_DEVICE_ID_##vend##_##dev, \
-.subvendor = PCI_ANY_ID, .subdevice = PCI_ANY_ID, 0, 0, \
-.driver_data = (kernel_ulong_t)(data)
-#endif
-
#ifndef PCI_VENDOR_ID_TEDIA
#define PCI_VENDOR_ID_TEDIA 0x1760
#endif
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: can: ctucanfd: remove useless copy of PCI_DEVICE_DATA macro
2026-01-30 11:41 [PATCH net-next] net: can: ctucanfd: remove useless copy of PCI_DEVICE_DATA macro Ethan Nelson-Moore
@ 2026-01-31 15:25 ` Marc Kleine-Budde
0 siblings, 0 replies; 2+ messages in thread
From: Marc Kleine-Budde @ 2026-01-31 15:25 UTC (permalink / raw)
To: Ethan Nelson-Moore
Cc: netdev, linux-can, Pavel Pisa, Ondrej Ille, Vincent Mailhol
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On 30.01.2026 03:41:33, Ethan Nelson-Moore wrote:
> The ctucanfd driver has its own copy of the PCI_DEVICE_DATA macro. I
> assume this was done to support older kernel versions where it didn't
> exist, but that is irrelevant once the driver is in the mainline
> kernel. Remove it.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Added linux-can-next
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-31 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-30 11:41 [PATCH net-next] net: can: ctucanfd: remove useless copy of PCI_DEVICE_DATA macro Ethan Nelson-Moore
2026-01-31 15:25 ` Marc Kleine-Budde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox