From: Jakub Kicinski <kuba@kernel.org>
To: Ingyu Jang <ingyujang25@korea.ac.kr>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com
Subject: Re: [Question] Dead code in rawv6_mh_filter_register()?
Date: Sat, 31 Jan 2026 10:04:35 -0800 [thread overview]
Message-ID: <20260131100435.36c2aa34@kernel.org> (raw)
In-Reply-To: <20260131150212.3292929-1-ingyujang25@korea.ac.kr>
On Sun, 1 Feb 2026 00:02:12 +0900 Ingyu Jang wrote:
> Since rawv6_mh_filter_register() never fails, this error path
> appears to be dead code. The same applies to
> rawv6_mh_filter_unregister() in mip6_fini().
Please do not send such reports for networking.
register and alloc functions should always be assumed to
need error handling, so that we don't have to fix all
the callers once they do and check why there's no error
checking when reviewing the code..
prev parent reply other threads:[~2026-01-31 18:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 15:02 [Question] Dead code in rawv6_mh_filter_register()? Ingyu Jang
2026-01-31 18:04 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260131100435.36c2aa34@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=ingyujang25@korea.ac.kr \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox