From: Kohei Enju <kohei@enjuk.jp>
To: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Vitaly Lifshits <vitaly.lifshits@intel.com>,
Simon Horman <horms@kernel.org>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>,
kohei.enju@gmail.com, Kohei Enju <kohei@enjuk.jp>
Subject: [PATCH v2 iwl-next 0/3] igc: add RSS key get/set support
Date: Sat, 31 Jan 2026 16:29:35 +0000 [thread overview]
Message-ID: <20260131163037.88108-1-kohei@enjuk.jp> (raw)
This series adds ethtool get/set support for the RSS hash key.
Without patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
Operation not supported
# ethtool -X $DEV hkey be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef
Cannot set RX flow hash configuration:
Hash key setting not supported
With patch:
# ethtool -x $DEV | grep key -A1
RSS hash key:
dd:7c:1f:06:1a:42:dc:e5:7e:90:2c:48:aa:3f:5d:5a:d7:da:ec:44:3e:3f:df:78:89:1e:3c:68:2e:59:da:a0:23:5a:32:5c:cf:5e:7e:7b
# ethtool -X $DEV hkey be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef
# ethtool -x $DEV | grep key -A1
RSS hash key:
be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef:be:ef
Also tested with rss_api.py and toeplitz.py.
# ./tools/testing/selftests/drivers/net/hw/rss_api.py | grep rss_api.test_rxfh_nl_set_key
ok 6 rss_api.test_rxfh_nl_set_key
# tools/testing/selftests/drivers/net/hw/toeplitz.py | grep "# Totals"
# Totals: pass:12 fail:0 xfail:0 xpass:0 skip:0 error:0
Notes:
Since the 2/3 patch is unchanged, I preserved Tested-by and Reviewed-by
tags for the patch.
Changes:
v2:
- call netdev_rss_key_fill() in igc_sw_init(), not in
igc_setup_mrqc()
- add documentation for igc_write_rss_key()
- drop has_user_rss_key flag, since rss_key is never cleared except
for user operations
- change email address from @amazon.com to @enjuk.jp
v1: https://lore.kernel.org/intel-wired-lan/20251025150136.47618-1-enjuk@amazon.com/
Kohei Enju (3):
igc: prepare for RSS key get/set support
igc: expose RSS key via ethtool get_rxfh
igc: allow configuring RSS key via ethtool set_rxfh
drivers/net/ethernet/intel/igc/igc.h | 3 +
drivers/net/ethernet/intel/igc/igc_ethtool.c | 67 +++++++++++++++-----
drivers/net/ethernet/intel/igc/igc_main.c | 8 +--
3 files changed, 57 insertions(+), 21 deletions(-)
--
2.51.0
next reply other threads:[~2026-01-31 16:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 16:29 Kohei Enju [this message]
2026-01-31 16:29 ` [PATCH v2 iwl-next 1/3] igc: prepare for RSS key get/set support Kohei Enju
2026-02-02 7:59 ` Loktionov, Aleksandr
2026-02-02 9:06 ` Kohei Enju
2026-02-02 9:08 ` Loktionov, Aleksandr
2026-02-24 13:34 ` [Intel-wired-lan] " Dahan, AvigailX
2026-02-04 10:29 ` Simon Horman
2026-01-31 16:29 ` [PATCH v2 iwl-next 2/3] igc: expose RSS key via ethtool get_rxfh Kohei Enju
2026-01-31 16:29 ` [PATCH v2 iwl-next 3/3] igc: allow configuring RSS key via ethtool set_rxfh Kohei Enju
2026-02-04 10:29 ` Simon Horman
2026-02-24 13:39 ` [Intel-wired-lan] " Dahan, AvigailX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260131163037.88108-1-kohei@enjuk.jp \
--to=kohei@enjuk.jp \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kohei.enju@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox