From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE0C9389460; Sat, 31 Jan 2026 23:35:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769902550; cv=none; b=HzIapRPsANxBg+78PbtY3wWarvAi1e0E3JyLR9w7S9m0bic4kOr1MKn0SLvhcvTq4/Gs5XFXfjLWBsr8vd1pqgkMXGH/M7XWy7bvfJpyr12WOjfVwNSN3lFULc2R/DDXY94u3Kd+4/I7bTD917LgREOzM7HrWfy4KAf1ul/dUU4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769902550; c=relaxed/simple; bh=YxQxR5RBGA/cueGC6OApDWXUJ2mKskXesnAySbcpXyk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=kHzn1OfRbOXHyyFCnj6dt14hQDvj/iboKNkcTXRuR1bOp+qaqPJ0lEw1ga47UQIz+CUW8r7EN91BoH0XVv0P56+zN15c7zGaZ1KXR5IIq/NaFyjBN0tUn1ikFkPg1MWAHp0S0od56TnsnEkc6mwSp9UEsegUcQoRTtBH5xbSJkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=cu+74xMP; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=wJBMUF0l; arc=none smtp.client-ip=80.241.56.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="cu+74xMP"; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="wJBMUF0l" Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4f3TlM06bgz9tk7; Sun, 1 Feb 2026 00:35:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1769902543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+/iDZb19qLWAZlTBVyRu0n5z9gZTCJ8IChPxp3+DBE=; b=cu+74xMPRBoD8VAUm+wXlt1grHPZgUuwO2gkAzOHFZGSXPStVFqZkdqvPaqzZGNYmtGgkU bks2mi/cVHP9bbvR6iVPledwY8pe9o9bCwOyLjzvsMM7IfcR8uTXO5SyPTqNc4lTnVBr9/ 3tMtlvsQ5/89jotX4gTBK6iKPK7BX1E7lpJYCOlty51a45UWnj2ngco6xfDeaq27lQ3VtD 7OON86bZJbspXRYDGrimZSefrbX/IQBzfwbk2E4yQJ8Ya+3VKEGQVbKwUMLBCEYIF1+vOJ 8Dc7C4JYXO8y3X4fzYTLDQgvdXiffvKVhU9Vc4WgSrttYazjp0he5ITFrp25Zw== From: Lukasz Majewski DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1769902541; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q+/iDZb19qLWAZlTBVyRu0n5z9gZTCJ8IChPxp3+DBE=; b=wJBMUF0l4EnFYp3YpES8gkkVp/6Vc/6vKHoHVLGVmushAMPx1Dx+Sh9TavZ9bYkAoRR3ck SVtaOLOHDczVHOyr1Yzi8z0i1zkgLtcuEJYoz5FI1VZFEvPDN1Vb+lztTetRaOzjZyPCfm cJoSzd9S7NregCBoxYRxillQeiqX/jVtJhqJQnRVlTTlmQoZA4ZDvB6eugBvmpopLNuI47 /ItGpwUiH4b5uJqrRf2KpOcDQSMpbCQuMLgJI9TdiKGvDcywu3D5XEDurS3sW8S+O+Y6yL L2Y4fGx0bXrk2ATMzUeLXe9XK7uSW7YQaDqgrvzsx3bDXijbi/RRVBiy4WxjBQ== To: Andrew Lunn , davem@davemloft.net, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo Cc: Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Richard Cochran , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Stefan Wahren , Simon Horman , Lukasz Majewski Subject: [net-next v22 3/7] net: mtip: Add buffers management functions to the L2 switch driver Date: Sun, 1 Feb 2026 00:34:55 +0100 Message-Id: <20260131233459.1625279-4-lukasz.majewski@mailbox.org> In-Reply-To: <20260131233459.1625279-1-lukasz.majewski@mailbox.org> References: <20260131233459.1625279-1-lukasz.majewski@mailbox.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-RS-META: uioi9jnnmndcjmmmxqr8hggqakb9n1nu X-MBO-RS-ID: 2d942a3fd4e7d4d74e6 This patch provides buffers management funcions' content for MTIP L2 switch. Signed-off-by: Lukasz Majewski --- Changes for v14: - New patch - created by excluding some code from large (i.e. v13 and earlier) MTIP driver Changes for v15 - v20: - None Changes for v21: - Add check if fep->page[i] is not NULL before returning it to page pool Changes for v22: - Add fep->tx_bounce[i] = NULL; in the mtip_free_buffers --- .../net/ethernet/freescale/mtipsw/mtipl2sw.c | 90 +++++++++++++++++++ 1 file changed, 90 insertions(+) diff --git a/drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c b/drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c index 45a7dfd253de..12df1170e394 100644 --- a/drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c +++ b/drivers/net/ethernet/freescale/mtipsw/mtipl2sw.c @@ -888,11 +888,101 @@ static void mtip_get_drvinfo(struct net_device *dev, static void mtip_free_buffers(struct net_device *dev) { + struct mtip_ndev_priv *priv = netdev_priv(dev); + struct switch_enet_private *fep = priv->fep; + int i; + + for (i = 0; i < RX_RING_SIZE; i++) { + if (!fep->page[i]) + continue; + + page_pool_put_full_page(fep->page_pool, + fep->page[i], false); + fep->page[i] = NULL; + } + + page_pool_destroy(fep->page_pool); + fep->page_pool = NULL; + + for (i = 0; i < TX_RING_SIZE; i++) { + kfree(fep->tx_bounce[i]); + fep->tx_bounce[i] = NULL; + } +} + +static int mtip_create_page_pool(struct switch_enet_private *fep, int size) +{ + struct page_pool_params pp_params = { + .order = 0, + .flags = PP_FLAG_DMA_MAP | PP_FLAG_DMA_SYNC_DEV, + .pool_size = size, + .nid = dev_to_node(&fep->pdev->dev), + .dev = &fep->pdev->dev, + .dma_dir = DMA_FROM_DEVICE, + .offset = 0, + .max_len = MTIP_SWITCH_RX_FRSIZE, + }; + int ret = 0; + + fep->page_pool = page_pool_create(&pp_params); + if (IS_ERR(fep->page_pool)) { + ret = PTR_ERR(fep->page_pool); + fep->page_pool = NULL; + } + + return ret; } static int mtip_alloc_buffers(struct net_device *dev) { + struct mtip_ndev_priv *priv = netdev_priv(dev); + struct switch_enet_private *fep = priv->fep; + struct cbd_t *bdp; + struct page *page; + int i, ret; + + ret = mtip_create_page_pool(fep, RX_RING_SIZE); + if (ret < 0) { + dev_err(&fep->pdev->dev, "Failed to create page pool\n"); + return ret; + } + + bdp = fep->rx_bd_base; + for (i = 0; i < RX_RING_SIZE; i++) { + page = page_pool_dev_alloc_pages(fep->page_pool); + if (!page) { + dev_err(&fep->pdev->dev, + "Failed to allocate page for rx buffer\n"); + goto err; + } + + bdp->cbd_bufaddr = page_pool_get_dma_addr(page); + fep->page[i] = page; + + bdp->cbd_sc = BD_ENET_RX_EMPTY; + bdp++; + } + + mtip_set_last_buf_to_wrap(bdp); + + bdp = fep->tx_bd_base; + for (i = 0; i < TX_RING_SIZE; i++) { + fep->tx_bounce[i] = kmalloc(MTIP_SWITCH_TX_FRSIZE, GFP_KERNEL); + if (!fep->tx_bounce[i]) + goto err; + + bdp->cbd_sc = 0; + bdp->cbd_bufaddr = 0; + bdp++; + } + + mtip_set_last_buf_to_wrap(bdp); + return 0; + + err: + mtip_free_buffers(dev); + return -ENOMEM; } static int mtip_rx_napi(struct napi_struct *napi, int budget) -- 2.39.5