From: Alice Mikityanska <alice.projects@fastmail.im>
To: Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Xin Long <lucien.xin@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Ahern <dsahern@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <stfomichev@gmail.com>,
netdev@vger.kernel.org, Alice Mikityanska <alice@isovalent.com>
Subject: [PATCH net-next v3 04/11] net/ipv6: Remove jumbo_remove step from TX path
Date: Mon, 2 Feb 2026 21:23:31 +0200 [thread overview]
Message-ID: <20260202192338.2373930-5-alice.projects@fastmail.im> (raw)
In-Reply-To: <20260202192338.2373930-1-alice.projects@fastmail.im>
From: Alice Mikityanska <alice@isovalent.com>
Now that the kernel doesn't insert HBH for BIG TCP IPv6 packets, remove
unnecessary steps from the GSO TX path, that used to check and remove
HBH.
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
---
net/core/dev.c | 6 ++----
net/ipv6/ip6_offload.c | 5 +----
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 43de5af0d6ec..ac6bcb2a0784 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3813,8 +3813,7 @@ static netdev_features_t gso_features_check(const struct sk_buff *skb,
(skb_shinfo(skb)->gso_type & SKB_GSO_UDP_L4 &&
vlan_get_protocol(skb) == htons(ETH_P_IPV6))) &&
skb_transport_header_was_set(skb) &&
- skb_network_header_len(skb) != sizeof(struct ipv6hdr) &&
- !ipv6_has_hopopt_jumbo(skb))
+ skb_network_header_len(skb) != sizeof(struct ipv6hdr))
features &= ~(NETIF_F_IPV6_CSUM | NETIF_F_TSO6 | NETIF_F_GSO_UDP_L4);
return features;
@@ -3917,8 +3916,7 @@ int skb_csum_hwoffload_help(struct sk_buff *skb,
if (features & (NETIF_F_IP_CSUM | NETIF_F_IPV6_CSUM)) {
if (vlan_get_protocol(skb) == htons(ETH_P_IPV6) &&
- skb_network_header_len(skb) != sizeof(struct ipv6hdr) &&
- !ipv6_has_hopopt_jumbo(skb))
+ skb_network_header_len(skb) != sizeof(struct ipv6hdr))
goto sw_checksum;
switch (skb->csum_offset) {
diff --git a/net/ipv6/ip6_offload.c b/net/ipv6/ip6_offload.c
index c44bb5812484..bd7f780e37a5 100644
--- a/net/ipv6/ip6_offload.c
+++ b/net/ipv6/ip6_offload.c
@@ -94,7 +94,7 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb,
struct sk_buff *segs = ERR_PTR(-EINVAL);
struct ipv6hdr *ipv6h;
const struct net_offload *ops;
- int proto, err;
+ int proto;
struct frag_hdr *fptr;
unsigned int payload_len;
u8 *prevhdr;
@@ -104,9 +104,6 @@ static struct sk_buff *ipv6_gso_segment(struct sk_buff *skb,
bool gso_partial;
skb_reset_network_header(skb);
- err = ipv6_hopopt_jumbo_remove(skb);
- if (err)
- return ERR_PTR(err);
nhoff = skb_network_header(skb) - skb_mac_header(skb);
if (unlikely(!pskb_may_pull(skb, sizeof(*ipv6h))))
goto out;
--
2.52.0
next prev parent reply other threads:[~2026-02-02 19:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 19:23 [PATCH net-next v3 00/11] BIG TCP without HBH in IPv6 Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 01/11] net/ipv6: Introduce payload_len helpers Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 02/11] net/ipv6: Drop HBH for BIG TCP on TX side Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 03/11] net/ipv6: Drop HBH for BIG TCP on RX side Alice Mikityanska
2026-02-02 19:23 ` Alice Mikityanska [this message]
2026-02-02 19:23 ` [PATCH net-next v3 05/11] net/mlx5e: Remove jumbo_remove step from TX path Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 06/11] net/mlx4: " Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 07/11] ice: " Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 08/11] bnxt_en: " Alice Mikityanska
2026-02-02 22:57 ` Michael Chan
2026-02-02 19:23 ` [PATCH net-next v3 09/11] gve: " Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 10/11] net: mana: " Alice Mikityanska
2026-02-02 19:23 ` [PATCH net-next v3 11/11] net/ipv6: Remove HBH helpers Alice Mikityanska
2026-02-02 19:49 ` [PATCH net-next v3 00/11] BIG TCP without HBH in IPv6 Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260202192338.2373930-5-alice.projects@fastmail.im \
--to=alice.projects@fastmail.im \
--cc=alice@isovalent.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox