public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Allison Henderson <achender@kernel.org>
To: netdev@vger.kernel.org
Cc: linux-kselftest@vger.kernel.org, pabeni@redhat.com,
	edumazet@google.com, rds-devel@oss.oracle.com, kuba@kernel.org,
	horms@kernel.org, linux-rdma@vger.kernel.org,
	allison.henderson@oracle.com
Subject: [PATCH net-next v5 5/8] net/rds: Clear reconnect pending bit
Date: Mon,  2 Feb 2026 22:57:20 -0700	[thread overview]
Message-ID: <20260203055723.1085751-6-achender@kernel.org> (raw)
In-Reply-To: <20260203055723.1085751-1-achender@kernel.org>

From: Håkon Bugge <haakon.bugge@oracle.com>

When canceling the reconnect worker, care must be taken to reset the
reconnect-pending bit. If the reconnect worker has not yet been
scheduled before it is canceled, the reconnect-pending bit will stay
on forever.

Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
---
 net/rds/connection.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/net/rds/connection.c b/net/rds/connection.c
index 3f26a67f3180..4b7715eb2111 100644
--- a/net/rds/connection.c
+++ b/net/rds/connection.c
@@ -442,6 +442,8 @@ void rds_conn_shutdown(struct rds_conn_path *cp)
 	 * to the conn hash, so we never trigger a reconnect on this
 	 * conn - the reconnect is always triggered by the active peer. */
 	cancel_delayed_work_sync(&cp->cp_conn_w);
+
+	clear_bit(RDS_RECONNECT_PENDING, &cp->cp_flags);
 	rcu_read_lock();
 	if (!hlist_unhashed(&conn->c_hash_node)) {
 		rcu_read_unlock();
-- 
2.43.0


  parent reply	other threads:[~2026-02-03  5:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  5:57 [PATCH net-next v5 0/8] net/rds: RDS-TCP protocol and extension improvements Allison Henderson
2026-02-03  5:57 ` [PATCH net-next v5 1/8] net/rds: new extension header: rdma bytes Allison Henderson
2026-02-03  5:57 ` [PATCH net-next v5 2/8] net/rds: Encode cp_index in TCP source port Allison Henderson
2026-02-03  5:57 ` [PATCH net-next v5 3/8] net/rds: rds_tcp_conn_path_shutdown must not discard messages Allison Henderson
2026-02-03  5:57 ` [PATCH net-next v5 4/8] net/rds: Kick-start TCP receiver after accept Allison Henderson
2026-02-03  5:57 ` Allison Henderson [this message]
2026-02-03  5:57 ` [PATCH net-next v5 6/8] net/rds: Update struct rds_statistics to use u64 instead of uint64_t Allison Henderson
2026-02-03  5:57 ` [PATCH net-next v5 7/8] net/rds: Use the first lane until RDS_EXTHDR_NPATHS arrives Allison Henderson
2026-02-03  5:57 ` [PATCH net-next v5 8/8] net/rds: Trigger rds_send_ping() more than once Allison Henderson
2026-02-05  5:00 ` [PATCH net-next v5 0/8] net/rds: RDS-TCP protocol and extension improvements patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260203055723.1085751-6-achender@kernel.org \
    --to=achender@kernel.org \
    --cc=allison.henderson@oracle.com \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rds-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox