From: Takashi Kozu <takkozu@amazon.com>
To: <horms@kernel.org>
Cc: <aleksandr.loktionov@intel.com>, <andrew+netdev@lunn.ch>,
<anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
<edumazet@google.com>, <enjuk@amazon.com>,
<intel-wired-lan@lists.osuosl.org>, <kuba@kernel.org>,
<netdev@vger.kernel.org>, <pabeni@redhat.com>,
<piotr.kwapulinski@intel.com>, <pmenzel@molgen.mpg.de>,
<przemyslaw.kitszel@intel.com>, <takkozu@amazon.com>
Subject: Re: [Intel-wired-lan] [iwl-next, v5, 3/3] igb: allow configuring RSS key via ethtool set_rxfh
Date: Tue, 3 Feb 2026 21:31:37 +0900 [thread overview]
Message-ID: <20260203123136.25423-2-takkozu@amazon.com> (raw)
In-Reply-To: <20260202102520.1844644-1-horms@kernel.org>
> From: Simon Horman <horms@kernel.org>
> To: takkozu@amazon.com
> Cc: Simon Horman <horms@kernel.org>,
> anthony.l.nguyen@intel.com, andrew+netdev@lunn.ch,
> davem@davemloft.net, aleksandr.loktionov@intel.com,
> przemyslaw.kitszel@intel.com, kuba@kernel.org,
> netdev@vger.kernel.org, enjuk@amazon.com, pabeni@redhat.com,
> intel-wired-lan@lists.osuosl.org, edumazet@google.com,
> piotr.kwapulinski@intel.com, pmenzel@molgen.mpg.de
> Subject: Re: [iwl-next,v5,3/3] igb: allow configuring RSS key via ethtool set_rxfh
> Date: Mon, 2 Feb 2026 10:25:20 +0000 [thread overview]
> Message-ID: <20260202102520.1844644-1-horms@kernel.org> (raw)
> In-Reply-To: <20260127085410.79645-8-takkozu@amazon.com>
>
> This is an AI-generated review of your patch. The human sending this
> email says "I'm releasing this report for completeness. And while I
> do think it is correct. I don't think it needs to block progress"
>
> For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
> ---
> igb: allow configuring RSS key via ethtool set_rxfh
>
> This patch adds support for configuring the RSS key via ethtool's
> set_rxfh interface. The change accepts a userspace-provided RSS key,
> stores it in the adapter structure, and writes it to hardware registers.
>
> > Change igc_set_rxfh() to accept and save a userspace-provided
> > RSS key.
>
> This isn't a code bug, but the commit message references "igc_set_rxfh()"
> when the function being modified is actually igb_set_rxfh() in
> drivers/net/ethernet/intel/igb/igb_ethtool.c. This typo was noted by
> Aleksandr Loktionov in the v1 review:
> https://lore.kernel.org/intel-wired-lan/IA3PR11MB89860A16782937C7E8C2E2DEE5A7A@IA3PR11MB8986.namprd11.prod.outlook.com/
>
> Should this be corrected to igb_set_rxfh() to match the actual code?
Thank you for pointing out.
I'll fix it and send it as v6.
next prev parent reply other threads:[~2026-02-03 12:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 8:54 [PATCH iwl-next v5 0/3] igb: add RSS key get/set support Takashi Kozu
2026-01-27 8:54 ` [PATCH iwl-next v5 1/3] igb: prepare for " Takashi Kozu
2026-01-27 8:54 ` [PATCH iwl-next v5 2/3] igb: expose RSS key via ethtool get_rxfh Takashi Kozu
2026-01-27 8:54 ` [PATCH iwl-next v5 3/3] igb: allow configuring RSS key via ethtool set_rxfh Takashi Kozu
2026-01-28 7:27 ` Kohei Enju
2026-02-02 10:25 ` [iwl-next,v5,3/3] " Simon Horman
2026-02-03 12:31 ` Takashi Kozu [this message]
2026-02-02 10:29 ` [PATCH iwl-next v5 0/3] igb: add RSS key get/set support Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203123136.25423-2-takkozu@amazon.com \
--to=takkozu@amazon.com \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enjuk@amazon.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=piotr.kwapulinski@intel.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox