From: Jakub Kicinski <kuba@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: netdev@vger.kernel.org, Chris Snook <chris.snook@gmail.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk> (maintainer:SFF/SFP/SFP+
MODULE SUPPORT:Keyword:phylink\.h|struct\s+phylink|\.phylink|>,
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH net 3/3] net: ag71xx: call phylink_destroy on failure
Date: Tue, 3 Feb 2026 19:32:50 -0800 [thread overview]
Message-ID: <20260203193250.6059a63c@kernel.org> (raw)
In-Reply-To: <20260202214634.72738-3-rosenp@gmail.com>
On Mon, 2 Feb 2026 13:46:34 -0800 Rosen Penev wrote:
> phylink_create has no devm equivalent and must therefore be handled
> manually in probe and remove.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Missing a fixes tag. Also missing (in patch 1) the ability to compile.
I defer to the phy folks on the question of using
devm_add_action_or_reset
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-04 3:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 21:46 [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev" Rosen Penev
2026-02-02 21:46 ` [PATCH net 2/3] Revert "net: ag71xx: remove platform_set_drvdata" Rosen Penev
2026-02-02 21:46 ` [PATCH net 3/3] net: ag71xx: call phylink_destroy on failure Rosen Penev
2026-02-04 3:32 ` Jakub Kicinski [this message]
2026-02-03 10:28 ` [PATCH net 1/3] Revert "net: ag71xx: use devm for register_netdev" Bartosz Golaszewski
2026-02-03 19:52 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260203193250.6059a63c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chris.snook@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox