From: Jakub Kicinski <kuba@kernel.org>
To: Matthieu Baerts <matttbe@kernel.org>
Cc: Mat Martineau <martineau@kernel.org>,
Geliang Tang <geliang@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Shuah Khan <shuah@kernel.org>,
netdev@vger.kernel.org, mptcp@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
Gang Yan <yangang@kylinos.cn>
Subject: Re: [PATCH net-next 07/15] mptcp: allow overridden write_space to be invoked
Date: Wed, 4 Feb 2026 18:44:39 -0800 [thread overview]
Message-ID: <20260204184439.4f1a65a0@kernel.org> (raw)
In-Reply-To: <8037fb73-4e18-4ed1-9eaf-e4cd8b2c9d53@kernel.org>
On Wed, 4 Feb 2026 11:47:13 +0100 Matthieu Baerts wrote:
> > diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
> > index f4bfe91ca7f9..0bd1ee860316 100644
> > --- a/net/mptcp/protocol.h
> > +++ b/net/mptcp/protocol.h
> > @@ -975,7 +975,7 @@ static inline void mptcp_write_space(struct sock *sk)
> > /* pairs with memory barrier in mptcp_poll */
> > smp_mb();
> > if (mptcp_stream_memory_free(sk, 1))
> > - sk_stream_write_space(sk);
> > + INDIRECT_CALL_1(sk->sk_write_space, sk_stream_write_space, sk);
>
> Is it possible to drop only this patch from this series? It is
> independent of the rest, and the AI review tool spotted that
> sk->sk_write_space is not sk_stream_write_space by default.
>
> I can send a v2 without this patch if preferred.
Ack, looks like this is the last patch in terms of real code
so can do. BTW I've been offering other sub-maintainers to
run the AI stuff on their patchwork instances. Looks like
there's a mptcp instance in k.org patchwork.
LMK if you want me to hook it up (..when time allows).
next prev parent reply other threads:[~2026-02-05 2:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 18:41 [PATCH net-next 00/15] mptcp: misc. features for v6.20/7.0 Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 01/15] mptcp: do not account for OoO in mptcp_rcvbuf_grow() Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 02/15] mptcp: fix receive space timestamp initialization Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 03/15] mptcp: consolidate rcv space init Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 04/15] trace: mptcp: add mptcp_rcvbuf_grow tracepoint Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 05/15] mptcp: pm: align endpoint flags size with the NL specs Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 06/15] mptcp: Change some dubious min_t(int, ...) to min() Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 07/15] mptcp: allow overridden write_space to be invoked Matthieu Baerts (NGI0)
2026-02-04 10:47 ` Matthieu Baerts
2026-02-05 2:44 ` Jakub Kicinski [this message]
2026-02-05 8:23 ` Matthieu Baerts
2026-02-03 18:41 ` [PATCH net-next 08/15] selftests: mptcp: diag: sort all #include Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 09/15] selftests: mptcp: join: wait for estab event instead of MPJ Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 10/15] selftests: mptcp: join: fix wait_mpj helper Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 11/15] selftests: mptcp: join: userspace: wait for new events Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 12/15] selftests: mptcp: join chk_stale_nr: avoid dup stats Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 13/15] selftests: mptcp: join: avoid declaring i if not used Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 14/15] selftests: mptcp: connect cleanup TFO setup Matthieu Baerts (NGI0)
2026-02-03 18:41 ` [PATCH net-next 15/15] selftests: mptcp: join: no SKIP mark for group checks Matthieu Baerts (NGI0)
2026-02-05 2:50 ` [PATCH net-next 00/15] mptcp: misc. features for v6.20/7.0 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204184439.4f1a65a0@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geliang@kernel.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=martineau@kernel.org \
--cc=matttbe@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=yangang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox