public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Rishikesh Jethwani <rjethwani@purestorage.com>
Cc: netdev@vger.kernel.org, saeedm@nvidia.com, tariqt@nvidia.com,
	mbloch@nvidia.com, borisp@nvidia.com, john.fastabend@gmail.com,
	sd@queasysnail.net, davem@davemloft.net, pabeni@redhat.com,
	edumazet@google.com, leon@kernel.org
Subject: Re: [PATCH v6 4/4] selftests: tls: add two-node hardware offload test
Date: Wed, 4 Feb 2026 18:52:20 -0800	[thread overview]
Message-ID: <20260204185220.0ef1aed9@kernel.org> (raw)
In-Reply-To: <20260203184835.3619101-5-rjethwani@purestorage.com>

On Tue,  3 Feb 2026 11:48:35 -0700 Rishikesh Jethwani wrote:
> Add tls_hw_offload, a test program for validating TLS hardware offload
> functionality across two physical nodes. Unlike existing selftests that
> use loopback or veth pairs, this test requires separate server and
> client machines to trigger actual NIC hardware offload.
> 
> Features:
>   - Server/client mode for two-node testing
>   - TLS 1.2 and TLS 1.3 support
>   - AES-GCM-128 and AES-GCM-256 cipher selection
>   - TLS 1.3 KeyUpdate (rekey) testing with configurable count
>   - Verification of /proc/net/tls_stat counters
>   - Echo protocol with data integrity verification
>   - Configurable buffer sizes (fixed or random)
> 
> The test validates that TLS connections use hardware offload by checking
> TlsTxDevice/TlsRxDevice counters, and verifies rekey operations through
> TlsTxRekeyOk/TlsRxRekeyOk counters. It accepts both hardware and software
> TLS paths, reporting which was used.

I appreciate the LLM tokens spent on this. Please get this rewritten 
to use our existing driver test setup instead of creating your own.
See tools/testing/selftests/drivers/net/README.rst and the existing
tests under tools/testing/selftests/drivers/net/hw/

Please switch to posting as RFC until we get a review from Sabrina,
the merge window is soon, anyways..

  reply	other threads:[~2026-02-05  2:52 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03 18:48 [PATCH v6 0/4] tls: Add TLS 1.3 hardware offload support Rishikesh Jethwani
2026-02-03 18:48 ` [PATCH v6 1/4] tls: add " Rishikesh Jethwani
2026-02-03 18:48 ` [PATCH v6 2/4] tls: add hardware offload key update support Rishikesh Jethwani
2026-02-03 18:48 ` [PATCH v6 3/4] mlx5: TLS 1.3 hardware offload support Rishikesh Jethwani
2026-02-03 18:48 ` [PATCH v6 4/4] selftests: tls: add two-node hardware offload test Rishikesh Jethwani
2026-02-05  2:52   ` Jakub Kicinski [this message]
2026-02-04 23:42 ` [PATCH v6 0/4] tls: Add TLS 1.3 hardware offload support Sabrina Dubroca
2026-02-05  2:49   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260204185220.0ef1aed9@kernel.org \
    --to=kuba@kernel.org \
    --cc=borisp@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=leon@kernel.org \
    --cc=mbloch@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rjethwani@purestorage.com \
    --cc=saeedm@nvidia.com \
    --cc=sd@queasysnail.net \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox