From: Jakub Kicinski <kuba@kernel.org>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/3] net: dsa: yt921x: Refactor port error message
Date: Wed, 4 Feb 2026 21:07:28 -0800 [thread overview]
Message-ID: <20260204210728.1c1f0463@kernel.org> (raw)
In-Reply-To: <20260203171305.95085-2-mmyangfl@gmail.com>
On Wed, 4 Feb 2026 01:12:41 +0800 David Yang wrote:
> +#define print_port_err(dev, port, res, action) dev_err( \
> + (dev), "Failed to %s port %d: %i\n", (action), (port), (res))
functions are preferred over macros when possible per kernel coding
guide
next prev parent reply other threads:[~2026-02-05 5:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 17:12 [PATCH net-next 0/3] net: dsa: yt921x: Use u64_stats_t for MIB stats David Yang
2026-02-03 17:12 ` [PATCH net-next 1/3] net: dsa: yt921x: Refactor port error message David Yang
2026-02-05 5:07 ` Jakub Kicinski [this message]
2026-02-03 17:12 ` [PATCH net-next 2/3] net: dsa: yt921x: Return early for failed MIB read David Yang
2026-02-05 5:08 ` [net-next,2/3] " Jakub Kicinski
2026-02-03 17:12 ` [PATCH net-next 3/3] net: dsa: yt921x: Use u64_stats_t for MIB stats David Yang
2026-02-05 5:12 ` Jakub Kicinski
2026-02-05 5:32 ` David Yang
2026-02-05 15:39 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204210728.1c1f0463@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox