From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Saeed Mahameed <saeedm@nvidia.com>,
"Mark Bloch" <mbloch@nvidia.com>,
Leon Romanovsky <leon@kernel.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
Dragos Tatulea <dtatulea@nvidia.com>
Subject: Re: [PATCH net-next 2/5] net/mlx5e: Report hw_gro_packets and hw_gro_bytes netdev stats
Date: Wed, 4 Feb 2026 21:23:34 -0800 [thread overview]
Message-ID: <20260204212334.72b392af@kernel.org> (raw)
In-Reply-To: <20260204193315.1722983-3-tariqt@nvidia.com>
On Wed, 4 Feb 2026 21:33:12 +0200 Tariq Toukan wrote:
> + stats->hw_gro_packets =
> + rq_stats->gro_packets + xskrq_stats->gro_packets;
> + stats->hw_gro_bytes = rq_stats->gro_bytes + xskrq_stats->gro_bytes;
Doesn't look right..
mlx5e_shampo_flush_skb(struct mlx5e_rq *rq, struct mlx5_cqe64 *cqe, bool match)
{
struct sk_buff *skb = rq->hw_gro_data->skb;
struct mlx5e_rq_stats *stats = rq->stats;
u16 gro_count = NAPI_GRO_CB(skb)->count;
if (likely(skb_shinfo(skb)->nr_frags))
mlx5e_shampo_align_fragment(skb, rq->mpwqe.log_stride_sz);
if (gro_count > 1) {
stats->gro_skbs++;
stats->gro_packets += gro_count;
And:
-
name: rx-hw-gro-packets
doc: |
Number of packets that were coalesced from smaller packets by the
device. Counts only packets coalesced with the HW-GRO netdevice
feature, LRO-coalesced packets are not counted.
-
name: rx-hw-gro-wire-packets
doc: |
Number of packets that were coalesced to bigger packetss with the
HW-GRO netdevice feature. LRO-coalesced packets are not counted.
type: uint
Your gro_packets are "gro-wire-packets" and "gro-packets" are your
gro_skbs.
I really wish the AI was clever enough to catch uAPI mis-reading :(
--
pw-bot: cr
next prev parent reply other threads:[~2026-02-05 5:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 19:33 [PATCH net-next 0/5] net/mlx5e: Report more netdev stats Tariq Toukan
2026-02-04 19:33 ` [PATCH net-next 1/5] net/mlx5e: Report hw_gso_packets and hw_gso_bytes " Tariq Toukan
2026-02-04 19:33 ` [PATCH net-next 2/5] net/mlx5e: Report hw_gro_packets and hw_gro_bytes " Tariq Toukan
2026-02-05 5:23 ` Jakub Kicinski [this message]
2026-02-05 7:43 ` Gal Pressman
2026-02-04 19:33 ` [PATCH net-next 3/5] net/mlx5e: Report TX csum " Tariq Toukan
2026-02-04 19:33 ` [PATCH net-next 4/5] net/mlx5e: Report RX " Tariq Toukan
2026-02-04 19:33 ` [PATCH net-next 5/5] net/mlx5e: Report stop and wake TX queue stats Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260204212334.72b392af@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox