From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 498A32367AC; Thu, 5 Feb 2026 05:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770269016; cv=none; b=E9fF6Kcj4rj7g7c+ZFOhZLWoAacPi750hwEr1jTbJGfcFMU8CCRoV0VV5oXHR2wPBO5Kh8DY1dFAGlTgTOQusQQTGBqjGeoXiM9X6qsP580vcA2sAU6J/AtAyc6M1Ws7IkgN8T1brkvKXoomTiD/RqJQ5tTeyWgV+3/9nIOwzAw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770269016; c=relaxed/simple; bh=rpQgaMbYOmoPSA+lSQAE3dsBM1LM68YW/eZGMaQU2BA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=nWJ4sx1gjqhyVxlMcrrXDtmAKeh0kgkaDISwEe0YTTqM5VLu65kiJMqeo3JLYy3gQs1zI+cYRXDCv1m5KXUdGCozv44XnMh5tpCOCFXf9EOdm1Ux3u9qb8w8hGFtO9ACvYJvaxdUBlzpyjEy368Hzzd7/azP7vTK8qbmLcJfUo8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=i0cMBLpO; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="i0cMBLpO" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 714C4C4CEF7; Thu, 5 Feb 2026 05:23:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770269016; bh=rpQgaMbYOmoPSA+lSQAE3dsBM1LM68YW/eZGMaQU2BA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=i0cMBLpO5CB0sXlAtjWjv/4YsBOYhiXX7/geSoUpEVRX0WKsd5TpTsNGxoX3s7sZr 1uDIqBoNTjbaG2VIipFUoCd6TCLqAb+x1Ri7gQfDRC7RTbjCxi2xK8zDwQO3FLcXuE wFOzzOqDUcn4R6rSKdfWT2NcGYmgQjDo5iPoPxvjNN1v77PMd3d9Imjr8gXIe/ekC5 kdCj9GN747pDAiBqpS20PZIDghzQfn5UKGej2zmKgek1UosLWsFD7xx9waxw55nn2R +XYt1OwG8CFsiNSXRVGtGLJmL2fTxL1o/t6ZNkL0dUT5oddbZZX9vlC2aWEgKeC/mt xaC3i2kIRD9SQ== Date: Wed, 4 Feb 2026 21:23:34 -0800 From: Jakub Kicinski To: Tariq Toukan Cc: Eric Dumazet , Paolo Abeni , Andrew Lunn , "David S. Miller" , Saeed Mahameed , "Mark Bloch" , Leon Romanovsky , , , , Gal Pressman , Moshe Shemesh , Dragos Tatulea Subject: Re: [PATCH net-next 2/5] net/mlx5e: Report hw_gro_packets and hw_gro_bytes netdev stats Message-ID: <20260204212334.72b392af@kernel.org> In-Reply-To: <20260204193315.1722983-3-tariqt@nvidia.com> References: <20260204193315.1722983-1-tariqt@nvidia.com> <20260204193315.1722983-3-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 4 Feb 2026 21:33:12 +0200 Tariq Toukan wrote: > + stats->hw_gro_packets = > + rq_stats->gro_packets + xskrq_stats->gro_packets; > + stats->hw_gro_bytes = rq_stats->gro_bytes + xskrq_stats->gro_bytes; Doesn't look right.. mlx5e_shampo_flush_skb(struct mlx5e_rq *rq, struct mlx5_cqe64 *cqe, bool match) { struct sk_buff *skb = rq->hw_gro_data->skb; struct mlx5e_rq_stats *stats = rq->stats; u16 gro_count = NAPI_GRO_CB(skb)->count; if (likely(skb_shinfo(skb)->nr_frags)) mlx5e_shampo_align_fragment(skb, rq->mpwqe.log_stride_sz); if (gro_count > 1) { stats->gro_skbs++; stats->gro_packets += gro_count; And: - name: rx-hw-gro-packets doc: | Number of packets that were coalesced from smaller packets by the device. Counts only packets coalesced with the HW-GRO netdevice feature, LRO-coalesced packets are not counted. - name: rx-hw-gro-wire-packets doc: | Number of packets that were coalesced to bigger packetss with the HW-GRO netdevice feature. LRO-coalesced packets are not counted. type: uint Your gro_packets are "gro-wire-packets" and "gro-packets" are your gro_skbs. I really wish the AI was clever enough to catch uAPI mis-reading :( -- pw-bot: cr