From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: davem@davemloft.net, Andrew Lunn <andrew@lunn.ch>,
Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Russell King <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: "Maxime Chevallier" <maxime.chevallier@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"Herve Codina" <herve.codina@bootlin.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Köry Maincent" <kory.maincent@bootlin.com>,
"Marek Behún" <kabel@kernel.org>,
"Oleksij Rempel" <o.rempel@pengutronix.de>,
"Nicolò Veronese" <nicveronese@gmail.com>,
"Simon Horman" <horms@kernel.org>,
mwojtas@chromium.org,
"Romain Gantois" <romain.gantois@bootlin.com>,
"Daniel Golle" <daniel@makrotopia.org>,
"Dimitri Fedrau" <dimitri.fedrau@liebherr.com>
Subject: [PATCH net-next v5 02/13] net: phy: phy_port: Cleanup the of-parsing logic for phy_port
Date: Thu, 5 Feb 2026 10:23:05 +0100 [thread overview]
Message-ID: <20260205092317.755906-3-maxime.chevallier@bootlin.com> (raw)
In-Reply-To: <20260205092317.755906-1-maxime.chevallier@bootlin.com>
We don't need to maintain a mediums bitfield, let's drop it and drop a
bogus check for empty mediums, as we already check it above.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/phy/phy_port.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/net/phy/phy_port.c b/drivers/net/phy/phy_port.c
index ec93c8ca051e..a269e9ea12c4 100644
--- a/drivers/net/phy/phy_port.c
+++ b/drivers/net/phy/phy_port.c
@@ -53,7 +53,7 @@ struct phy_port *phy_of_parse_port(struct device_node *dn)
enum ethtool_link_medium medium;
struct phy_port *port;
const char *med_str;
- u32 pairs = 0, mediums = 0;
+ u32 pairs = 0;
int ret;
ret = fwnode_property_read_string(fwnode, "media", &med_str);
@@ -85,17 +85,12 @@ struct phy_port *phy_of_parse_port(struct device_node *dn)
return ERR_PTR(-EINVAL);
}
- mediums |= BIT(medium);
-
- if (!mediums)
- return ERR_PTR(-EINVAL);
-
port = phy_port_alloc();
if (!port)
return ERR_PTR(-ENOMEM);
port->pairs = pairs;
- port->mediums = mediums;
+ port->mediums = BIT(medium);
return port;
}
--
2.49.0
next prev parent reply other threads:[~2026-02-05 9:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 9:23 [PATCH net-next v5 00/13] net: phy_port: SFP modules representation and phy_port listing Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 01/13] net: phy: initialize the port support based on the PHY's for OF ports Maxime Chevallier
2026-02-11 9:36 ` Christophe Leroy (CS GROUP)
2026-02-05 9:23 ` Maxime Chevallier [this message]
2026-02-11 9:38 ` [PATCH net-next v5 02/13] net: phy: phy_port: Cleanup the of-parsing logic for phy_port Christophe Leroy (CS GROUP)
2026-02-05 9:23 ` [PATCH net-next v5 03/13] net: phy: phy_port: Correctly recompute the port's linkmodes Maxime Chevallier
2026-02-11 9:39 ` Christophe Leroy (CS GROUP)
2026-02-05 9:23 ` [PATCH net-next v5 04/13] net: phy: phy_link_topology: Add a helper for opportunistic alloc Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 05/13] net: phy: phy_link_topology: Track ports in phy_link_topology Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 06/13] net: phylink: Register a phy_port for MAC-driven SFP busses Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 07/13] net: phy: Create SFP phy_port before registering upstream Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 08/13] net: phy: Represent PHY-less SFP modules with phy_port Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 09/13] net: phylink: " Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 10/13] net: phy: phy_port: Store information about a MII port's vacant state Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 11/13] net: phy: phy_link_topology: Add a helper to retrieve ports Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 12/13] netlink: specs: Add ethernet port listing with ethtool Maxime Chevallier
2026-02-05 9:23 ` [PATCH net-next v5 13/13] net: ethtool: Introduce ethtool command to list ports Maxime Chevallier
2026-02-11 4:11 ` [PATCH net-next v5 00/13] net: phy_port: SFP modules representation and phy_port listing Jakub Kicinski
2026-02-11 7:42 ` Maxime Chevallier
2026-02-13 2:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205092317.755906-3-maxime.chevallier@bootlin.com \
--to=maxime.chevallier@bootlin.com \
--cc=andrew@lunn.ch \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dimitri.fedrau@liebherr.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=herve.codina@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kabel@kernel.org \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mwojtas@chromium.org \
--cc=netdev@vger.kernel.org \
--cc=nicveronese@gmail.com \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=romain.gantois@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox