From: Alice Mikityanska <alice.kernel@fastmail.im>
To: Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Xin Long <lucien.xin@gmail.com>,
Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
David Ahern <dsahern@kernel.org>,
Nikolay Aleksandrov <razor@blackwall.org>
Cc: Shuah Khan <shuah@kernel.org>,
Stanislav Fomichev <stfomichev@gmail.com>,
netdev@vger.kernel.org, Alice Mikityanska <alice@isovalent.com>,
Michael Chan <michael.chan@broadcom.com>
Subject: [PATCH net-next v5 08/12] bnxt_en: Remove jumbo_remove step from TX path
Date: Thu, 5 Feb 2026 15:39:21 +0200 [thread overview]
Message-ID: <20260205133925.526371-9-alice.kernel@fastmail.im> (raw)
In-Reply-To: <20260205133925.526371-1-alice.kernel@fastmail.im>
From: Alice Mikityanska <alice@isovalent.com>
Now that the kernel doesn't insert HBH for BIG TCP IPv6 packets, remove
unnecessary steps from the bnxt_en TX path, that used to check and
remove HBH.
Signed-off-by: Alice Mikityanska <alice@isovalent.com>
Acked-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 466e0fc6141f..7d63d6b0d2c2 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -517,9 +517,6 @@ static netdev_tx_t bnxt_start_xmit(struct sk_buff *skb, struct net_device *dev)
return NETDEV_TX_BUSY;
}
- if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
- goto tx_free;
-
length = skb->len;
len = skb_headlen(skb);
last_frag = skb_shinfo(skb)->nr_frags;
@@ -13881,7 +13878,6 @@ static bool bnxt_exthdr_check(struct bnxt *bp, struct sk_buff *skb, int nw_off,
u8 **nextp)
{
struct ipv6hdr *ip6h = (struct ipv6hdr *)(skb->data + nw_off);
- struct hop_jumbo_hdr *jhdr;
int hdr_count = 0;
u8 *nexthdr;
int start;
@@ -13910,24 +13906,7 @@ static bool bnxt_exthdr_check(struct bnxt *bp, struct sk_buff *skb, int nw_off,
if (hdrlen > 64)
return false;
- /* The ext header may be a hop-by-hop header inserted for
- * big TCP purposes. This will be removed before sending
- * from NIC, so do not count it.
- */
- if (*nexthdr == NEXTHDR_HOP) {
- if (likely(skb->len <= GRO_LEGACY_MAX_SIZE))
- goto increment_hdr;
-
- jhdr = (struct hop_jumbo_hdr *)hp;
- if (jhdr->tlv_type != IPV6_TLV_JUMBO || jhdr->hdrlen != 0 ||
- jhdr->nexthdr != IPPROTO_TCP)
- goto increment_hdr;
-
- goto next_hdr;
- }
-increment_hdr:
hdr_count++;
-next_hdr:
nexthdr = &hp->nexthdr;
start += hdrlen;
}
--
2.52.0
next prev parent reply other threads:[~2026-02-05 13:40 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 13:39 [PATCH net-next v5 00/12] BIG TCP without HBH in IPv6 Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 01/12] net/ipv6: Introduce payload_len helpers Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 02/12] net/ipv6: Drop HBH for BIG TCP on TX side Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 03/12] net/ipv6: Drop HBH for BIG TCP on RX side Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 04/12] net/ipv6: Remove jumbo_remove step from TX path Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 05/12] net/mlx5e: " Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 06/12] net/mlx4: " Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 07/12] ice: " Alice Mikityanska
2026-02-05 13:39 ` Alice Mikityanska [this message]
2026-02-05 13:39 ` [PATCH net-next v5 09/12] gve: " Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 10/12] net: mana: " Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 11/12] bng_en: " Alice Mikityanska
2026-02-05 13:39 ` [PATCH net-next v5 12/12] net/ipv6: Remove HBH helpers Alice Mikityanska
2026-02-07 5:20 ` [PATCH net-next v5 00/12] BIG TCP without HBH in IPv6 patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205133925.526371-9-alice.kernel@fastmail.im \
--to=alice.kernel@fastmail.im \
--cc=alice@isovalent.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=lucien.xin@gmail.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
--cc=stfomichev@gmail.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox