From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Cc: "Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
Kurt Kanzenbach <kurt@linutronix.de>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"Kitszel, Przemyslaw" <przemyslaw.kitszel@intel.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
"Gomes, Vinicius" <vinicius.gomes@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] igb: Retrieve Tx timestamp directly from interrupt for i210
Date: Thu, 5 Feb 2026 17:43:41 +0100 [thread overview]
Message-ID: <20260205164341.pJvni8kA@linutronix.de> (raw)
In-Reply-To: <66925f09-ef9f-4401-baec-7d4c82a68ce3@linux.dev>
On 2026-02-05 16:27:03 [+0000], Vadim Fedorenko wrote:
> > So the only thing that bothers me is the read_lock_bh() in
> > skb_may_tx_timestamp() which deadlocks if the socket is write-locked on
> > the same CPU.
>
> Alright. Now you make me think whether we should enforce OPT_TSONLY
> option on socket which doesn't have CAP_NET_RAW? Then we can get rid of this
> check, and in case sysctl was flipped off - drop TX timestamps as
> it's done now?
This would "fix" this problem for all users which do deliver the
timestamp from their IRQ handler instead of napi. There are a few of
those…
This would be considered stable material, right? (despite the fact that
we have it for quite some time and nobody complained so far).
Sebastian
next prev parent reply other threads:[~2026-02-05 16:43 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 7:54 [PATCH iwl-next v3] igb: Retrieve Tx timestamp directly from interrupt for i210 Kurt Kanzenbach
2026-02-05 9:47 ` [Intel-wired-lan] " Loktionov, Aleksandr
2026-02-05 10:03 ` Sebastian Andrzej Siewior
2026-02-05 10:37 ` Loktionov, Aleksandr
2026-02-05 10:52 ` Sebastian Andrzej Siewior
2026-02-05 11:56 ` Vadim Fedorenko
2026-02-05 14:51 ` Sebastian Andrzej Siewior
2026-02-05 16:27 ` Vadim Fedorenko
2026-02-05 16:43 ` Sebastian Andrzej Siewior [this message]
2026-02-05 16:48 ` Vadim Fedorenko
2026-02-05 21:41 ` Willem de Bruijn
2026-02-06 7:44 ` Sebastian Andrzej Siewior
2026-02-06 10:12 ` Vadim Fedorenko
2026-02-08 16:25 ` Willem de Bruijn
2026-02-09 9:06 ` Sebastian Andrzej Siewior
2026-02-09 10:43 ` Vadim Fedorenko
2026-02-09 11:48 ` Sebastian Andrzej Siewior
2026-02-09 12:24 ` Vadim Fedorenko
2026-02-09 12:46 ` Willem de Bruijn
2026-02-10 12:12 ` Sebastian Andrzej Siewior
2026-02-10 16:14 ` Willem de Bruijn
2026-02-11 12:08 ` Kurt Kanzenbach
2026-02-11 16:29 ` Willem de Bruijn
2026-02-12 18:33 ` Sebastian Andrzej Siewior
2026-02-14 23:26 ` Sebastian Andrzej Siewior
2026-02-11 18:54 ` Jakub Kicinski
2026-02-12 16:28 ` Sebastian Andrzej Siewior
2026-02-11 19:29 ` Jacob Keller
2026-02-11 21:44 ` Jakub Kicinski
2026-02-12 16:47 ` Sebastian Andrzej Siewior
2026-02-05 11:58 ` Kurt Kanzenbach
2026-02-05 12:20 ` Loktionov, Aleksandr
2026-02-06 0:05 ` Jacob Keller
2026-02-05 12:12 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205164341.pJvni8kA@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=aleksandr.loktionov@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmenzel@molgen.mpg.de \
--cc=przemyslaw.kitszel@intel.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vinicius.gomes@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox