From: kernel test robot <lkp@intel.com>
To: Amery Hung <ameryhung@gmail.com>, bpf@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
netdev@vger.kernel.org, alexei.starovoitov@gmail.com,
andrii@kernel.org, daniel@iogearbox.net, memxor@gmail.com,
martin.lau@kernel.org, kpsingh@kernel.org,
yonghong.song@linux.dev, song@kernel.org, haoluo@google.com,
ameryhung@gmail.com, kernel-team@meta.com
Subject: Re: [PATCH bpf-next v6 09/17] bpf: Prepare for bpf_selem_unlink_nofail()
Date: Thu, 5 Feb 2026 21:48:03 +0800 [thread overview]
Message-ID: <202602052147.PjiFTJlT-lkp@intel.com> (raw)
In-Reply-To: <20260205070208.186382-10-ameryhung@gmail.com>
Hi Amery,
kernel test robot noticed the following build warnings:
[auto build test WARNING on bpf-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Amery-Hung/bpf-Select-bpf_local_storage_map_bucket-based-on-bpf_local_storage/20260205-150959
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20260205070208.186382-10-ameryhung%40gmail.com
patch subject: [PATCH bpf-next v6 09/17] bpf: Prepare for bpf_selem_unlink_nofail()
config: x86_64-buildonly-randconfig-002-20260205 (https://download.01.org/0day-ci/archive/20260205/202602052147.PjiFTJlT-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260205/202602052147.PjiFTJlT-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602052147.PjiFTJlT-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> kernel/bpf/bpf_local_storage.c:289:8: warning: variable 'owner' set but not used [-Wunused-but-set-variable]
289 | void *owner;
| ^
kernel/bpf/bpf_local_storage.c:64:13: warning: unused function 'selem_linked_to_map' [-Wunused-function]
64 | static bool selem_linked_to_map(const struct bpf_local_storage_elem *selem)
| ^~~~~~~~~~~~~~~~~~~
2 warnings generated.
vim +/owner +289 kernel/bpf/bpf_local_storage.c
588d80f1d996ea Amery Hung 2026-02-04 278
450af8d0f6be2e KP Singh 2020-08-25 279 /* local_storage->lock must be held and selem->local_storage == local_storage.
450af8d0f6be2e KP Singh 2020-08-25 280 * The caller must ensure selem->smap is still valid to be
450af8d0f6be2e KP Singh 2020-08-25 281 * dereferenced for its smap->elem_size and smap->cache_idx.
450af8d0f6be2e KP Singh 2020-08-25 282 */
c83597fa5dc6b3 Yonghong Song 2022-10-25 283 static bool bpf_selem_unlink_storage_nolock(struct bpf_local_storage *local_storage,
450af8d0f6be2e KP Singh 2020-08-25 284 struct bpf_local_storage_elem *selem,
0e854e55356908 Amery Hung 2025-11-14 285 struct hlist_head *free_selem_list)
450af8d0f6be2e KP Singh 2020-08-25 286 {
450af8d0f6be2e KP Singh 2020-08-25 287 struct bpf_local_storage_map *smap;
450af8d0f6be2e KP Singh 2020-08-25 288 bool free_local_storage;
450af8d0f6be2e KP Singh 2020-08-25 @289 void *owner;
450af8d0f6be2e KP Singh 2020-08-25 290
0fe4b381a59ebc KP Singh 2021-12-24 291 smap = rcu_dereference_check(SDATA(selem)->smap, bpf_rcu_lock_held());
450af8d0f6be2e KP Singh 2020-08-25 292 owner = local_storage->owner;
450af8d0f6be2e KP Singh 2020-08-25 293
450af8d0f6be2e KP Singh 2020-08-25 294 free_local_storage = hlist_is_singular_node(&selem->snode,
450af8d0f6be2e KP Singh 2020-08-25 295 &local_storage->list);
450af8d0f6be2e KP Singh 2020-08-25 296
588d80f1d996ea Amery Hung 2026-02-04 297 bpf_selem_unlink_storage_nolock_misc(selem, smap, local_storage,
588d80f1d996ea Amery Hung 2026-02-04 298 free_local_storage);
450af8d0f6be2e KP Singh 2020-08-25 299
450af8d0f6be2e KP Singh 2020-08-25 300 hlist_del_init_rcu(&selem->snode);
450af8d0f6be2e KP Singh 2020-08-25 301
5bd5bab76669b1 Martin KaFai Lau 2024-10-23 302 hlist_add_head(&selem->free_node, free_selem_list);
dcf456c9a095a6 KP Singh 2022-04-18 303
450af8d0f6be2e KP Singh 2020-08-25 304 return free_local_storage;
450af8d0f6be2e KP Singh 2020-08-25 305 }
450af8d0f6be2e KP Singh 2020-08-25 306
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2026-02-05 13:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 7:01 [PATCH bpf-next v6 00/17] Remove task and cgroup local storage percpu counters Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 01/17] bpf: Select bpf_local_storage_map_bucket based on bpf_local_storage Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 02/17] bpf: Convert bpf_selem_unlink_map to failable Amery Hung
2026-02-05 7:37 ` bot+bpf-ci
2026-02-05 7:01 ` [PATCH bpf-next v6 03/17] bpf: Convert bpf_selem_link_map " Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 04/17] bpf: Convert bpf_selem_unlink " Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 05/17] bpf: Change local_storage->lock and b->lock to rqspinlock Amery Hung
2026-02-05 7:37 ` bot+bpf-ci
2026-02-05 7:01 ` [PATCH bpf-next v6 06/17] bpf: Remove task local storage percpu counter Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 07/17] bpf: Remove cgroup " Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 08/17] bpf: Remove unused percpu counter from bpf_local_storage_map_free Amery Hung
2026-02-05 7:01 ` [PATCH bpf-next v6 09/17] bpf: Prepare for bpf_selem_unlink_nofail() Amery Hung
2026-02-05 13:43 ` kernel test robot
2026-02-05 13:48 ` kernel test robot [this message]
2026-02-05 7:01 ` [PATCH bpf-next v6 10/17] bpf: Support lockless unlink when freeing map or local storage Amery Hung
2026-02-05 7:02 ` [PATCH bpf-next v6 11/17] bpf: Switch to bpf_selem_unlink_nofail in bpf_local_storage_{map_free, destroy} Amery Hung
2026-02-05 7:02 ` [PATCH bpf-next v6 12/17] selftests/bpf: Update sk_storage_omem_uncharge test Amery Hung
2026-02-05 7:02 ` [PATCH bpf-next v6 13/17] selftests/bpf: Update task_local_storage/recursion test Amery Hung
2026-02-05 7:37 ` bot+bpf-ci
2026-02-05 7:02 ` [PATCH bpf-next v6 14/17] selftests/bpf: Update task_local_storage/task_storage_nodeadlock test Amery Hung
2026-02-05 7:02 ` [PATCH bpf-next v6 15/17] selftests/bpf: Remove test_task_storage_map_stress_lookup Amery Hung
2026-02-05 7:02 ` [PATCH bpf-next v6 16/17] selftests/bpf: Choose another percpu variable in bpf for btf_dump test Amery Hung
2026-02-05 7:02 ` [PATCH bpf-next v6 17/17] selftests/bpf: Fix outdated test on storage->smap Amery Hung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202602052147.PjiFTJlT-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexei.starovoitov@gmail.com \
--cc=ameryhung@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=kernel-team@meta.com \
--cc=kpsingh@kernel.org \
--cc=llvm@lists.linux.dev \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox