From: Breno Leitao <leitao@debian.org>
To: Breno Leitao <leitao@debian.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
pmladek@suse.com, john.ogness@linutronix.de
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
asantostc@gmail.com, efault@gmx.de, gustavold@gmail.com,
calvin@wbinvd.org, jv@jvosburgh.net, mpdesouza@suse.com,
kernel-team@meta.com, Simon Horman <horms@kernel.org>
Subject: [PATCH net-next v7 0/4] net: netconsole: convert to NBCON console infrastructure
Date: Fri, 06 Feb 2026 04:45:28 -0800 [thread overview]
Message-ID: <20260206-nbcon-v7-0-62bda69b1b41@debian.org> (raw)
This series adds support for the nbcon (new buffer console) infrastructure
to netconsole, enabling lock-free, priority-based console operations that
are safer in crash scenarios.
The implementation is introduced in three steps:
0) Extend printk to expose CPU and taskname (task->comm) where the
printk originated from. (Thanks John and Petr for the support in
getting this done)
1) Refactor the message fragmentation logic into a reusable helper function
2) Extend nbcon support to non-extended (basic) consoles using the same
infrastructure.
The initial discussion about it appeared a while ago in [1], in order to
solve Mike's HARDIRQ-safe -> HARDIRQ-unsafe lock order warning, and the root
cause is that some hosts were calling IRQ unsafe locks from inside console
lock.
At that time, we didn't have the CON_NBCON_ATOMIC_UNSAFE yet. John
kindly implemented CON_NBCON_ATOMIC_UNSAFE in 187de7c212e5 ("printk:
nbcon: Allow unsafe write_atomic() for panic"), and now we can
implement netconsole on top of nbcon.
Important to note that netconsole continues to call netpoll and the
network TX helpers with interrupt disable, given the TX are called with
target_list_lock.
Netdev maintainers, Petr suggested that this patchset goes through netdev[2]
Link: https://lore.kernel.org/all/b2qps3uywhmjaym4mht2wpxul4yqtuuayeoq4iv4k3zf5wdgh3@tocu6c7mj4lt/ [1]
Link: https://lore.kernel.org/all/aW9D5M0o9_8hdVvt@pathway.suse.cz/ [2]
Signed-off-by: Breno Leitao <leitao@debian.org>
---
Changes in v7:
- Remove the intermediate CONSOLE_HAS_EXECUTION_CTX config option
- Link to v6: https://patch.msgid.link/20260203-nbcon-v6-0-985f3bdb3267@debian.org
Changes in v6:
- Do not select PRINTK_EXECUTION_CTX in NETCONSOLE_DYNAMIC (Jakub)
- Do not make PRINTK_EXECUTION_CTX user visible (Jakub)
- Link to v5: https://patch.msgid.link/20260128-nbcon-v5-0-93b4ddbc181a@debian.org
Changes in v5:
- Replace the memcpy size from TASK_COMM_LEN to sizeof(wctxt->comm)
(John)
- Add some compilation time asserts (John)
- Change the implementation of printk_info_get_cpu()
- Link to v4: https://patch.msgid.link/20260123-nbcon-v4-0-46a5cf567926@debian.org
Changes in v4:
- Added __acquires/__releases compiler annotations (Simon)
- Rebased on top of net-next, which included changes from Andre
- Netconsole Dynamic now selects PRINTK_EXECUTION_CTX and
CONSOLE_HAS_EXECUTION_CTX
- Link to v3: https://patch.msgid.link/20260122-nbcon-v3-0-a722f2f0dfa5@debian.org
Changes in v3:
- Fixed netconsole selection (s/CONSOLE_HAS_EXECUTION_CTX/PRINTK_EXECUTION_CTX)
- Removed unnecessary "inline" in C file.
- Tried to shrink the get the lines to fit 80-columns
- Link to v2: https://patch.msgid.link/20260120-nbcon-v2-0-b61f960587a8@debian.org
Changes in v2:
- Return if not able to nbcon_enter_unsafe() instead of retrying on
a different target (Marcos)
- Add printk that supports context information, which will be used later
by netconsole sysdata. (John, Petr)
- An extra patch to bring symmetry to send_msg_udp()
- Link to v1: https://patch.msgid.link/20251222-nbcon-v1-0-65b43c098708@debian.org
Changes in V1 from RFC:
* Removed the extra CONFIG for NBCON, given we don't want to support
both console. Move to nbcon as the only console framework supported
* Incorporated the changes from Petr.
* Some renames to make the code more consistent.
* RFC Link: https://lore.kernel.org/all/20251121-nbcon-v1-0-503d17b2b4af@debian.org/
---
Breno Leitao (4):
printk: Add execution context (task name/CPU) to printk_info
netconsole: extract message fragmentation into send_msg_udp()
netconsole: convert to NBCON console infrastructure
netconsole: Use printk context for CPU and task information
drivers/net/Kconfig | 1 +
drivers/net/netconsole.c | 153 +++++++++++++++++++++++---------------
include/linux/console.h | 8 ++
kernel/printk/internal.h | 8 ++
kernel/printk/nbcon.c | 16 ++++
kernel/printk/printk.c | 54 +++++++++++++-
kernel/printk/printk_ringbuffer.h | 5 ++
lib/Kconfig.debug | 12 +++
8 files changed, 197 insertions(+), 60 deletions(-)
---
base-commit: bf2e36c9dab95e41516fbcf7b1cc804539b2d021
change-id: 20251117-nbcon-f24477ca9f3e
Best regards,
--
Breno Leitao <leitao@debian.org>
next reply other threads:[~2026-02-06 12:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 12:45 Breno Leitao [this message]
2026-02-06 12:45 ` [PATCH net-next v7 1/4] printk: Add execution context (task name/CPU) to printk_info Breno Leitao
2026-02-06 14:08 ` John Ogness
2026-02-12 15:28 ` Geert Uytterhoeven
2026-02-06 12:45 ` [PATCH net-next v7 2/4] netconsole: extract message fragmentation into send_msg_udp() Breno Leitao
2026-02-06 12:45 ` [PATCH net-next v7 3/4] netconsole: convert to NBCON console infrastructure Breno Leitao
2026-02-06 12:45 ` [PATCH net-next v7 4/4] netconsole: Use printk context for CPU and task information Breno Leitao
2026-02-11 4:20 ` [PATCH net-next v7 0/4] net: netconsole: convert to NBCON console infrastructure patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206-nbcon-v7-0-62bda69b1b41@debian.org \
--to=leitao@debian.org \
--cc=akpm@linux-foundation.org \
--cc=andrew+netdev@lunn.ch \
--cc=asantostc@gmail.com \
--cc=calvin@wbinvd.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=efault@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=gustavold@gmail.com \
--cc=horms@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=jv@jvosburgh.net \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpdesouza@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox