From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: bridge@lists.linux.dev
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Ido Schimmel" <idosch@nvidia.com>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Simon Horman" <horms@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
"Kuniyuki Iwashima" <kuniyu@google.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Xiao Liang" <shaw.leon@gmail.com>,
"Linus Lüssing" <linus.luessing@c0d3.blue>
Subject: [PATCH net-next v2 09/14] net: bridge: mcast: track active state, VLAN snooping
Date: Fri, 6 Feb 2026 03:52:15 +0100 [thread overview]
Message-ID: <20260206030123.5430-10-linus.luessing@c0d3.blue> (raw)
In-Reply-To: <20260206030123.5430-1-linus.luessing@c0d3.blue>
If VLAN aware multicast snooping is enabled then we need to perform a
few extra checks to figure out if multicast snooping is actually enabled
for a specific VLAN, as there is then an additional per VLAN multicast
snooping toggle.
Signed-off-by: Linus Lüssing <linus.luessing@c0d3.blue>
---
net/bridge/br_multicast.c | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 4bdc3838c3dc..2a2f54009e0f 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1143,6 +1143,26 @@ static void br_multicast_update_active(struct net_bridge_mcast *brmctx)
if (!br_opt_get(brmctx->br, BROPT_MULTICAST_ENABLED))
force_inactive = true;
+ if (br_opt_get(brmctx->br, BROPT_MCAST_VLAN_SNOOPING_ENABLED)) {
+ /* with per-vlan snooping enabled there is an extra per-vlan
+ * toggle to enable/disable snooping which we must check
+ */
+ if (br_multicast_ctx_vlan_global_disabled(brmctx))
+ force_inactive = true;
+
+ /* with per-vlan snooping enabled the non-vlan multicast
+ * snooping context is inactive
+ */
+ if (!br_multicast_ctx_is_vlan(brmctx))
+ force_inactive = true;
+ } else {
+ /* with per-vlan snooping disabled a vlan multicast
+ * snooping context is inactive
+ */
+ if (br_multicast_ctx_is_vlan(brmctx))
+ force_inactive = true;
+ }
+
br_ip4_multicast_update_active(brmctx, force_inactive);
br_ip6_multicast_update_active(brmctx, force_inactive);
--
2.51.0
next prev parent reply other threads:[~2026-02-06 3:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-06 2:52 [PATCH net-next v2 00/14] net: bridge: reduce multicast checks in fast path Linus Lüssing
2026-02-06 2:52 ` [PATCH net-next v2 01/14] net: bridge: mcast: export ip{4,6}_active state to netlink Linus Lüssing
2026-02-08 16:00 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 02/14] net: bridge: mcast: track active state, adding tests Linus Lüssing
2026-02-07 4:58 ` Jakub Kicinski
2026-02-08 16:00 ` Ido Schimmel
2026-02-10 21:06 ` Linus Lüssing
2026-02-11 9:42 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 03/14] net: bridge: mcast: avoid sleeping on bridge-down Linus Lüssing
2026-02-08 11:41 ` Ido Schimmel
2026-02-08 16:01 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 04/14] net: bridge: mcast: track active state, IGMP/MLD querier appearance Linus Lüssing
2026-02-08 16:07 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 05/14] net: bridge: mcast: track active state, foreign IGMP/MLD querier disappearance Linus Lüssing
2026-02-07 4:56 ` [net-next,v2,05/14] " Jakub Kicinski
2026-02-11 3:05 ` Linus Lüssing
2026-02-08 16:08 ` [PATCH net-next v2 05/14] " Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 06/14] net: bridge: mcast: track active state, IPv6 address availability Linus Lüssing
2026-02-08 16:08 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 07/14] net: bridge: mcast: track active state, own MLD querier disappearance Linus Lüssing
2026-02-08 16:09 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 08/14] net: bridge: mcast: track active state, if snooping is enabled Linus Lüssing
2026-02-08 16:09 ` Ido Schimmel
2026-02-06 2:52 ` Linus Lüssing [this message]
2026-02-08 16:10 ` [PATCH net-next v2 09/14] net: bridge: mcast: track active state, VLAN snooping Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 10/14] net: bridge: mcast: track active state, bridge up/down Linus Lüssing
2026-02-08 16:10 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 11/14] net: bridge: mcast: track active state, prepare for outside lock reads Linus Lüssing
2026-02-08 16:11 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 12/14] net: bridge: mcast: use combined active state in netlink Linus Lüssing
2026-02-08 16:11 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 13/14] net: bridge: mcast: use combined active state in fast/data path Linus Lüssing
2026-02-08 16:12 ` Ido Schimmel
2026-02-06 2:52 ` [PATCH net-next v2 14/14] net: bridge: mcast: add inactive state assertions Linus Lüssing
2026-02-08 16:13 ` Ido Schimmel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206030123.5430-10-linus.luessing@c0d3.blue \
--to=linus.luessing@c0d3.blue \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=kuniyu@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=sdf@fomichev.me \
--cc=shaw.leon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox