From: Keita Morisaki <kmta1236@gmail.com>
To: maciej.fijalkowski@intel.com
Cc: aleksandr.loktionov@intel.com, alice.michael@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
intel-wired-lan@lists.osuosl.org, kmta1236@gmail.com,
kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
paul.greenwalt@intel.com, przemyslaw.kitszel@intel.com,
tony.nguyen@intel.com
Subject: Re: [PATCH v2] ice: fix race condition in TX timestamp ring cleanup
Date: Fri, 6 Feb 2026 13:54:26 +0900 [thread overview]
Message-ID: <20260206045426.3547398-1-kmta1236@gmail.com> (raw)
In-Reply-To: <aYSeb42KRzlc4SbA@boxer>
> am I reading this right or you only modified flags to be bitmap on Tx side
> and Rx is left as-is?
>
> Would be nice to reflect this on Rx side as well, but I know it is out of
> the scope for this patch.
>
> Would you like to do a follow-up patch for that which would be sent to
> -next tree?
Yes, I intentionally left RX side as is because it seems less obviously that
rx flags are touched concurrently than tx ones.
But sure, it's a good idea to make the handling more defensive on the rx side as well.
I think it can be a follow-up patch as TX has more obvious race condition.
> Also your patch should contain the tree you are dedicating your work:
> [PATCH net v2] ice: fix race condition in TX timestamp ring cleanup
Didn't know that! Thank you for the comment. I will follow this in future
(I'm also happy to resend the V2 patch with the updated subject if you think it's).
> As for rest of the stuff it makes sense to me, however best if Paul could
> give his ack here.
prev parent reply other threads:[~2026-02-06 4:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 2:43 [PATCH v2] ice: fix race condition in TX timestamp ring cleanup Keita Morisaki
2026-02-05 13:43 ` Maciej Fijalkowski
2026-02-06 4:54 ` Keita Morisaki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206045426.3547398-1-kmta1236@gmail.com \
--to=kmta1236@gmail.com \
--cc=aleksandr.loktionov@intel.com \
--cc=alice.michael@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.greenwalt@intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=tony.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox