From: Jakub Kicinski <kuba@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: netdev@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net,
conor+dt@kernel.org, krzk+dt@kernel.org, chad@monroe.io,
devicetree@vger.kernel.org, lxu@maxlinear.com, frankwu@gmx.de,
linux@armlinux.org.uk, john@phrozen.org, robh@kernel.org,
cezary.wilmanski@adtran.com, hkallweit1@gmail.com,
horms@kernel.org, edumazet@google.com,
linux-kernel@vger.kernel.org, pabeni@redhat.com,
olteanv@gmail.com
Subject: Re: [net-next,v13,2/4] net: dsa: add tag format for MxL862xx switches
Date: Fri, 6 Feb 2026 18:46:27 -0800 [thread overview]
Message-ID: <20260206184627.774c7f71@kernel.org> (raw)
In-Reply-To: <aYVgVgf3nemHNSEF@makrotopia.org>
On Fri, 6 Feb 2026 03:30:30 +0000 Daniel Golle wrote:
> > > +
> > > + /* provide additional space 'MXL862_HEADER_LEN' bytes */
> > > + skb_push(skb, MXL862_HEADER_LEN);
> >
> > [ ... ]
> >
> > > + dsa_alloc_etype_header(skb, MXL862_HEADER_LEN);
> > > +
> > > + /* special tag ingress */
> > ^^^^^^^
> >
> > This comment says "ingress" but mxl862_tag_xmit() is the TX/egress path.
> > Should this say "egress" instead?
>
> "ingress" is the perspective of the switch, and how the tag to be used
> to send frames from the host to the switch is called in the datasheet[1]
Maybe expand on the comment a bit? Or remove it?
Cause reading the code I was also consued why this is called ingress
next prev parent reply other threads:[~2026-02-07 2:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 13:32 [PATCH net-next v13 0/4] net: dsa: initial support for MaxLinear MxL862xx switches Daniel Golle
2026-02-04 13:32 ` [PATCH net-next v13 1/4] dt-bindings: net: dsa: add MaxLinear MxL862xx Daniel Golle
2026-02-04 13:33 ` [PATCH net-next v13 2/4] net: dsa: add tag format for MxL862xx switches Daniel Golle
2026-02-06 2:21 ` [net-next,v13,2/4] " Jakub Kicinski
2026-02-06 3:30 ` Daniel Golle
2026-02-07 2:46 ` Jakub Kicinski [this message]
2026-02-04 13:33 ` [PATCH net-next v13 3/4] net: mdio: add unlocked mdiodev C45 bus accessors Daniel Golle
2026-02-04 13:33 ` [PATCH net-next v13 4/4] net: dsa: add basic initial driver for MxL862xx switches Daniel Golle
2026-02-06 2:21 ` Jakub Kicinski
2026-02-06 3:14 ` Daniel Golle
2026-02-06 13:34 ` Vladimir Oltean
2026-02-06 16:43 ` Daniel Golle
2026-02-07 22:14 ` Vladimir Oltean
2026-02-07 2:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260206184627.774c7f71@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cezary.wilmanski@adtran.com \
--cc=chad@monroe.io \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=frankwu@gmx.de \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=john@phrozen.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lxu@maxlinear.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox