From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E97827F75C; Sat, 7 Feb 2026 04:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770440309; cv=none; b=dt3LeITh5z5mRKsg6osxSoZgUS6fcmmc/0ln6vsajSievzqAUX5xC35TEa0YD26/lve0i1F3m4/jSN5ZAMkSDMdYsfRm7STM8KTzsVvlR/Mnu4sbhFUeJ0aj7+85WlFJSf6gn+AEoL2IOO99RTyAcZzuHQrtFlx1KjUJEJvwZfQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770440309; c=relaxed/simple; bh=Ex5KF5PCMHlYLqzcICn9ya/MIfAwzyWKzw2WzNHii7s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=IbPojjQ5+SxZqbmHTURG3wS6M11CLry7njmgZA+L18on+BNERqLeLjAWfqwbAgMdBpfo0Bxwu00AuWxqUaUUi1xIWfxr4y4NS4FJ7DDiIghiHVXqr48MWTIeP+pRn3wwwc6Lw5N7W0JLFQsA5TyjDfxi/a3iBL9LPHqzV5LB7Uk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bDiqqbhM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bDiqqbhM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4A891C116D0; Sat, 7 Feb 2026 04:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770440308; bh=Ex5KF5PCMHlYLqzcICn9ya/MIfAwzyWKzw2WzNHii7s=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=bDiqqbhMbURHakdL9t+Jvdy6Cmv4m3FqfrDNKMATfPH/+G0Fg3uf30/Umf4gFwyZN 1IquWzQbi268Z5phc5XhvdqMXRb9LX17LICiGIzatlWaeq45RT7Z9m8/6MzPxqbwbc UC4JRrDcjI5e+9hLK5IIS4JF1Paz3RnZYru8zqGkkHTqQ/UuPn1H8rFE37zLknnx+7 BWM+d39D0ZY9BGb+eeC8milNweFQZlsXOCSgk2sb+nQeObSWmIGARER1qI3ecNlAqQ xV7oD1VLoUD/J0Pc+VHKAH44M/YIWnxI69zj0i2l442Br2CZZV05vodAOBoTynwtk/ MG+WZPqlyvB3A== Date: Fri, 6 Feb 2026 20:58:27 -0800 From: Jakub Kicinski To: Linus =?UTF-8?B?TMO8c3Npbmc=?= Cc: bridge@lists.linux.dev, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nikolay Aleksandrov , Ido Schimmel , Andrew Lunn , Simon Horman , Paolo Abeni , Eric Dumazet , "David S . Miller" , Kuniyuki Iwashima , Stanislav Fomichev , Xiao Liang Subject: Re: [PATCH net-next v2 02/14] net: bridge: mcast: track active state, adding tests Message-ID: <20260206205827.567f1c25@kernel.org> In-Reply-To: <20260206030123.5430-3-linus.luessing@c0d3.blue> References: <20260206030123.5430-1-linus.luessing@c0d3.blue> <20260206030123.5430-3-linus.luessing@c0d3.blue> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Fri, 6 Feb 2026 03:52:08 +0100 Linus L=C3=BCssing wrote: > Before making any significant changes to the internals of the Linux > bridge add some tests regarding the multicast activity. This is > also to verify that we have the semantics of the new > *_MCAST_ACTIVE_{V4,V6} netlink attributes as expected. shellcheck has a bunch of complains here, including these two warnings: +In bridge_mdb_active.sh line 124: + if [ $ret -eq 0 -a $state -eq 0 ] || [ $ret -ne 0 -a $state -eq 1 ]; then + ^--^ SC2086 (info): Double quote to prevent globbing and word= splitting. + ^-- SC2166 (warning): Prefer [ p ] && [ q ] as [ p= -a q ] is not well defined. + ^-- SC2166 (warn= ing): Prefer [ p ] && [ q ] as [ p -a q ] is not well defined. > .../net/forwarding/bridge_mdb_active.sh | 682 ++++++++++++++++++ Is there a reason this test is not included in the makefile? --=20 pw-bot: cr