From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f43.google.com (mail-qv1-f43.google.com [209.85.219.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 095E51C860A for ; Sat, 7 Feb 2026 06:22:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770445321; cv=none; b=XFDZN8GmFPIawUyeghEJcGXegoxdmg8ZF+AgTVJ1B1FgMR/T3PAqhBfVRNBHnRYh9PyYPA56Z9N71IrHYu+PGtnbGSNxyN1zZSuvPuVcuy+ewTJUsgDJjlvL7muj9vs0fETqaHpJolgu2iNhaw5izUFleOgN7zg4QUDmWVmhBm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770445321; c=relaxed/simple; bh=khdehHZTZ3iPp0jMZpCIkxyJL29MISIPziLCk4adFEE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=ogXkd9TihWulKT+az1TH6d3RC4VD6BKO/mrJpOKrSwYnJ/gHL1M20qEbavj5NPCUXuHEJKl5XOCIKPNaByK/mNp8ok75b2fw4KManbXhVuztCv+a6hLkZ9d9MO+5kpaewjLsYan0evlmge/ZMgJ26TEIRS6PLd87gIelYmDRQE4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AkNl2v13; arc=none smtp.client-ip=209.85.219.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AkNl2v13" Received: by mail-qv1-f43.google.com with SMTP id 6a1803df08f44-894638da330so30295146d6.1 for ; Fri, 06 Feb 2026 22:22:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770445320; x=1771050120; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=4Jvauz+ENBVr5yYmGZ77a3RAIpmuhMLwQfOQH7uwGMY=; b=AkNl2v13GX3N7oIuzBnxLTUM+e0oV/kd5hBS4dfhSOUplKfEi1VovgzEOpO+GuvAWp 9B6enSbaDkZ5KMtBE2lhBpbEz4Bs3UsqYC0zkiZ4GA3qUjhw4IIzAIhCZmMhdcF939dU gIsLyZU8qdSbyxk4DCqxsXNEFFVl7RfpoUh/G0PIHVHodxrlTkHk4AoKMd9icrgrEiOg Hk4OY2lIqVIwjFGj0uZI3nUbpvtbXoKH0qkWEzQWl3BGjhAr3Cp8j3LWiNrJAdWEi7Kc qfqaeXfgDILk1do9RDqgrgeVIQ/hDNSBfe1VzWfcsZjF53ur1pJgaF+Lm/8XPpa1jqtk WFOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770445320; x=1771050120; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4Jvauz+ENBVr5yYmGZ77a3RAIpmuhMLwQfOQH7uwGMY=; b=V08FDhgZ/bj1/WNt/GJ7FaUVc3sKudepKg+2yCVVOv/tyqUevW8yYOsQf5DlDU3SLG +iSxdGceELRNnU9/B+p6UAGHM1y5rySMXlwSY924lap9vZTsYfQzxMnT7Cu+fGBrWaUE Tp2v0ufZSXskLEOq9Xjqm4HqfGnaKcAhN0NOjehADn18t8HO2azSkCAndijXBu5+3EAR szaSUizpFXvv/UZe2Q/cJjSYWLI0/RvxHJUxm676wxeJO878E4VJtBoGXBP+KYL7O4Hk GniOY3kqZSELlHsuUCUBop26Z2t1BpeO55HuyiKxAVSsQQTJ+umOM/J5pfj8szQBjgLq gtTA== X-Gm-Message-State: AOJu0YzpB7das5d/gTq3iC4p1dmH0lKvKHzvgpN7IpRWkoggIHkgm0Ci p9Fm6CC65H/50QWDkuVODAi6oLAverpFsxN5NO4F1EHyAiTCAeilm+OU X-Gm-Gg: AZuq6aIcRYdof/NKXJMsKIWHy0UbqMwUcKccvSLYdWK/kRQ6GnDUe2PhP+oKtNlQ16P Wo8vVr5YGdbj1JumILo/cCt6WEXorrTU9mDvLRkAakqb+SkXv04JdgTgFXtBadFtUrl6cEiNOVP Iw9OKDkX2+g8mLem0u3y8MG6Zqda7QPJNMMboJ0AIYvO5SE+KtxbhJWuzmU+t7OEjgQcp3nxmrW VRy9gFDDfeVjRIA3eqgaHP8/h7HQRKB9glicMyY+6ZTfCOYXnXIgoNs0craiqvSAVhcCMfbbden Noq+MmFt8ouKHl7hDlNC+2rYFQX/Mm0FrKCwMh/h22MU90CgkxdMkGaDSu97bedacFN5G7oOaL3 lEtPT1qx6BMbdGvHi+PEZcXLIbs6gH4WPY/sf1NG7fUHiIl1l6a2EGsyXhLuSNGmzKrXsEbeKi6 Vck5AM0NNx2tYo/ZaCS8SQ X-Received: by 2002:a05:6214:27e2:b0:895:1855:f174 with SMTP id 6a1803df08f44-8953c8065a2mr72114296d6.24.1770445319801; Fri, 06 Feb 2026 22:21:59 -0800 (PST) Received: from localhost.localdomain ([128.224.253.2]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8953bf58b06sm34858036d6.15.2026.02.06.22.21.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Feb 2026 22:21:59 -0800 (PST) From: Kevin Hao Date: Sat, 07 Feb 2026 14:21:46 +0800 Subject: [PATCH net v3] net: ti: icssg-prueth: Add optional dependency on HSR Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260207-icssg-dep-v3-1-8c47c1937f81@gmail.com> X-B4-Tracking: v=1; b=H4sIAPnZhmkC/22MOQ7CMBBFrxJNjVHGhiBTcQ9E4WWcjEQW2ZEFi nJ3LFcpKP/y3gaJIlOCe7NBpMyJ56kEdWrADWbqSbAvGWQru1a2SrBLqReeFmF1uAUnLSESlP8 SKfCnup4w0QqvUg6c1jl+qz9jnf6oMgoU1jgTrlJdglWPfjT8Prt5rJYsj2R3JGUhtTeE2qKmz h/Jfd9/vjxfyuEAAAA= X-Change-ID: 20260203-icssg-dep-b9f7fc2be11e To: netdev@vger.kernel.org Cc: Kevin Hao , stable@vger.kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Roger Quadros , Mohan Reddy Putluru , MD Danish Anwar , Arnd Bergmann , Sascha Hauer X-Mailer: b4 0.14.2 Commit 95540ad6747c ("net: ti: icssg-prueth: Add support for HSR frame forward offload") introduced support for offloading HSR frame forwarding, which relies on functions such as is_hsr_master() provided by the HSR module. Although HSR provides stubs for configurations with HSR disabled, this driver still requires an optional dependency on HSR. Otherwise, build failures will occur when icssg-prueth is built-in while HSR is configured as a module. ld.lld: error: undefined symbol: is_hsr_master >>> referenced by icssg_prueth.c:710 (drivers/net/ethernet/ti/icssg/icssg_prueth.c:710) >>> drivers/net/ethernet/ti/icssg/icssg_prueth.o:(icssg_prueth_hsr_del_mcast) in archive vmlinux.a >>> referenced by icssg_prueth.c:681 (drivers/net/ethernet/ti/icssg/icssg_prueth.c:681) >>> drivers/net/ethernet/ti/icssg/icssg_prueth.o:(icssg_prueth_hsr_add_mcast) in archive vmlinux.a >>> referenced by icssg_prueth.c:1812 (drivers/net/ethernet/ti/icssg/icssg_prueth.c:1812) >>> drivers/net/ethernet/ti/icssg/icssg_prueth.o:(prueth_netdevice_event) in archive vmlinux.a ld.lld: error: undefined symbol: hsr_get_port_ndev >>> referenced by icssg_prueth.c:712 (drivers/net/ethernet/ti/icssg/icssg_prueth.c:712) >>> drivers/net/ethernet/ti/icssg/icssg_prueth.o:(icssg_prueth_hsr_del_mcast) in archive vmlinux.a >>> referenced by icssg_prueth.c:712 (drivers/net/ethernet/ti/icssg/icssg_prueth.c:712) >>> drivers/net/etherneteth_hsr_del_mcast) in archive vmlinux.a >>> referenced by icssg_prueth.c:683 (drivers/net/ethernet/ti/icssg/icssg_prueth.c:683) >>> drivers/net/ethernet/ti/icssg/icssg_prueth.o:(icssg_prueth_hsr_add_mcast) in archive vmlinux.a >>> referenced 1 more times Fixes: 95540ad6747c ("net: ti: icssg-prueth: Add support for HSR frame forward offload") Signed-off-by: Kevin Hao Cc: stable@vger.kernel.org --- Cc: Andrew Lunn Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Roger Quadros Cc: Mohan Reddy Putluru Cc: MD Danish Anwar Cc: Arnd Bergmann Cc: Sascha Hauer --- Changes in v3: - The implementation of the 'HSR if HSR' syntax has not yet been merged, use 'depends on HSR || !HSR' instead. - Link to v2: https://lore.kernel.org/r/20260206-icssg-dep-v2-1-9dae19b19e6d@gmail.com Changes in v2: - Switch to the optional dependency as recommended by Jakub. - Link to v1: https://lore.kernel.org/r/20260203-icssg-dep-v1-1-bacaf5234fb3@gmail.com --- drivers/net/ethernet/ti/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/ti/Kconfig b/drivers/net/ethernet/ti/Kconfig index fe5b2926d8ab060d83f5a58d91e749a45c6cea18..c60b04921c62cab52983efa5aaafecdb9b7d4da4 100644 --- a/drivers/net/ethernet/ti/Kconfig +++ b/drivers/net/ethernet/ti/Kconfig @@ -192,6 +192,7 @@ config TI_ICSSG_PRUETH depends on NET_SWITCHDEV depends on ARCH_K3 && OF && TI_K3_UDMA_GLUE_LAYER depends on PTP_1588_CLOCK_OPTIONAL + depends on HSR || !HSR help Support dual Gigabit Ethernet ports over the ICSSG PRU Subsystem. This subsystem is available starting with the AM65 platform. --- base-commit: 6d2f142b1e4b203387a92519d9d2e34752a79dbb change-id: 20260203-icssg-dep-b9f7fc2be11e Best regards, -- Kevin Hao