Re: [PATCH] net: stmmac: imx: Disable EEE

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

On Mon, Feb 09, 2026 at 01:12:25PM +0000, Russell King (Oracle) wrote:
> On Mon, Feb 09, 2026 at 01:29:31AM +0200, Laurent Pinchart wrote:
> ...
> > Fix the issue by disabling EEE completely on i.MX8MP.
> > 
> > [1] https://lore.kernel.org/all/20251026122905.29028-1-laurent.pinchart@ideasonboard.com/
> > [2] https://lore.kernel.org/all/20251123053518.8478-1-laurent.pinchart@ideasonboard.com/
> > 
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > This patch depends on https://lore.kernel.org/r/20251026122905.29028-1-laurent.pinchart@ideasonboard.com
> 
> Are you sure? That's the one adding the DT property, not my patch that
> adds the flag you need for this.

Oops, wrong link. I meant

https://lore.kernel.org/all/E1vNUjC-0000000FhjR-0h6P@rmk-PC.armlinux.org.uk/

> > @@ -355,7 +354,8 @@ static struct imx_dwmac_ops imx8mp_dwmac_data = {
> >  	.addr_width = 34,
> >  	.mac_rgmii_txclk_auto_adj = false,
> >  	.set_intf_mode = imx8mp_set_intf_mode,
> > -	.flags = STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY,
> > +	.flags = STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY
> > +	       | STMMAC_FLAG_EEE_DISABLE,
> 
> I thought we had a coding style comment about wrapping like this
> (operators should be trailing on the previous line, not at the
> beginning of the following line) but I can find nothing in
> Documentation/process/coding-style.rst  Confused. Maybe it's
> somewhere else in the re-organised documentation.

I'll move it at the end of the line, no problem. It's one of those
pieces of coding style where different driver authors and subsystems
have different opinion so I'm never quite sure what to do when
submitting patches for areas of the kernel I don't usually touch. I
should have looked at the rest of the file, sorry about missing it.

-- 
Regards,

Laurent Pinchart