From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610C32040B6 for ; Mon, 9 Feb 2026 13:21:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770643302; cv=none; b=ki1tgGEbAFYmAkIP1R1kxw/urTQ31lpkHFcY3i5dDT2SdjYPsxMzEPKY7Txyre3nonWDA/FspaGAzBsNcWI0vv85UOsJ/HXbSjV/vKUa0jIM4e2T9tTfl5VDukyShrDargz4HFkbDX6IkpgGsV2Qee44KhXaQDgtpM+nN4Rb1/Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770643302; c=relaxed/simple; bh=7ovSodLbOpn2W27nDVgvF+GU2exE6mG03PG81HU6Tok=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bQNzf8v0rED2pGiYa59lrLpa2KWKmbG+kCw66bmJnD4o5bydaZi1u2Tv26KPFswMUYRLQ+Gspk6ObK/cEVU1NX9QpYrjAgbDRANCPRtGiGyZZdmuF0jlEqBkFWERbCsoTJaGRNpwn18knGEXrkuB6KpozVjkrJLzW7W2VeGNq0o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ogqu1sL8; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ogqu1sL8" Received: from killaraus.ideasonboard.com (2001-14ba-703d-e500--2a1.rev.dnainternet.fi [IPv6:2001:14ba:703d:e500::2a1]) by perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id F0DDB454; Mon, 9 Feb 2026 14:20:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1770643254; bh=7ovSodLbOpn2W27nDVgvF+GU2exE6mG03PG81HU6Tok=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ogqu1sL8zkEDDFjyCVDcTsVWUQk2mNJ+aATnmwhyu5XSrwbGmYqwzi/Byk7b6g/qY WbnYgly/qwg8VKu7YgS3AQwulcYhNlyIRgxNR85c44I3bjWOW+aVxEjlgqqxX35z4d +sx/rXQCCwIGjM0wFrZBHnGyM7YNDlE1t4tTV3G0= Date: Mon, 9 Feb 2026 15:21:38 +0200 From: Laurent Pinchart To: "Russell King (Oracle)" Cc: netdev@vger.kernel.org, imx@lists.linux.dev, Andrew Lunn , Clark Wang , "David S. Miller" , Eric Dumazet , Fabio Estevam , Fabio Estevam , Francesco Dolcini , Frank Li , Heiko Schocher , Jakub Kicinski , Joakim Zhang , Joy Zou , Kieran Bingham , Marcel Ziswiler , Marco Felsch , Martyn Welch , Mathieu Othacehe , Paolo Abeni , Pengutronix Kernel Team , Richard Hu , Sascha Hauer , Shawn Guo , Shenwei Wang , Stefan Klug , Stefano Radaelli , Wei Fang , Xiaoliang Yang , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] net: stmmac: imx: Disable EEE Message-ID: <20260209132138.GF2302514@killaraus.ideasonboard.com> References: <20260208232931.2272237-1-laurent.pinchart@ideasonboard.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Mon, Feb 09, 2026 at 01:12:25PM +0000, Russell King (Oracle) wrote: > On Mon, Feb 09, 2026 at 01:29:31AM +0200, Laurent Pinchart wrote: > ... > > Fix the issue by disabling EEE completely on i.MX8MP. > > > > [1] https://lore.kernel.org/all/20251026122905.29028-1-laurent.pinchart@ideasonboard.com/ > > [2] https://lore.kernel.org/all/20251123053518.8478-1-laurent.pinchart@ideasonboard.com/ > > > > Signed-off-by: Laurent Pinchart > > --- > > This patch depends on https://lore.kernel.org/r/20251026122905.29028-1-laurent.pinchart@ideasonboard.com > > Are you sure? That's the one adding the DT property, not my patch that > adds the flag you need for this. Oops, wrong link. I meant https://lore.kernel.org/all/E1vNUjC-0000000FhjR-0h6P@rmk-PC.armlinux.org.uk/ > > @@ -355,7 +354,8 @@ static struct imx_dwmac_ops imx8mp_dwmac_data = { > > .addr_width = 34, > > .mac_rgmii_txclk_auto_adj = false, > > .set_intf_mode = imx8mp_set_intf_mode, > > - .flags = STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY, > > + .flags = STMMAC_FLAG_HWTSTAMP_CORRECT_LATENCY > > + | STMMAC_FLAG_EEE_DISABLE, > > I thought we had a coding style comment about wrapping like this > (operators should be trailing on the previous line, not at the > beginning of the following line) but I can find nothing in > Documentation/process/coding-style.rst Confused. Maybe it's > somewhere else in the re-organised documentation. I'll move it at the end of the line, no problem. It's one of those pieces of coding style where different driver authors and subsystems have different opinion so I'm never quite sure what to do when submitting patches for areas of the kernel I don't usually touch. I should have looked at the rest of the file, sorry about missing it. -- Regards, Laurent Pinchart