From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28C8723D291; Mon, 9 Feb 2026 16:25:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770654310; cv=none; b=OLB02WbfJzKnd90P469g7FTS/7tGerVtHvI3+JhS9K0MuIrnAC7/pOOSR7+kZGsohjA0bgfJSZ8gZoGOedn+UMOzPyFAz/nY9a3yA7Wp35jGShItH97knCaXgAWJ5inGg9KTAvqVQxSo2RPkZFRWJk+z9z5vuE9G3XD1YWlAalg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770654310; c=relaxed/simple; bh=YiyUpq4yLFMnusX9o9WUFew3CYw+pNregIbvTpT83M0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=LLc4Fg1jMoqRKrdSUE9zhlnq6uScYAN5HTSlaDarH1VyVgrCtcsyNXpQn+nELgzeSuf9BkdsyekkSMUGPvHlFhjQxg8ngBS5Rr3bQISyJ3bZCj4hBi1wB2gZPJRM6T35QwstLJYCr/WECava52FqSddgMgU573nSxZi5DH3Pl80= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nYsaIaY9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nYsaIaY9" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 907FDC19423; Mon, 9 Feb 2026 16:25:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770654309; bh=YiyUpq4yLFMnusX9o9WUFew3CYw+pNregIbvTpT83M0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nYsaIaY9LUNkTbpZ47L62Dcxp3Ykz3vn0n+/tyYH7/m6gPKmCKODwefqlR6gSRiZ4 QNH71InDZQOYUkH9aAkqvL4A0AJI7qKkqcBqAJ1SQrG6adeUY720ScVOek9e5nl8zk W/FnNIvvdmZZ/ie6NBxWvHWZdvIgLUErNE2dneRRqmal584UEHphuD2c4Q84d/qB/N +bMwAgzyC/IjoXfqFZn/ZTluu3AxtHvgWevNxvqU9qxbhteDuf6BnWey/xsPPT/sCM 1N1mwRlFcwNUg9nPrHUMobTGi6cb9z2N5PCWasZy5y3iMXxJo22a/TW9+E0yywpV6Y 408PkZHn0GlOw== Date: Mon, 9 Feb 2026 16:25:03 +0000 From: Simon Horman To: Maxime Chevallier Cc: davem@davemloft.net, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , Heiner Kallweit , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Christophe Leroy , Herve Codina , Florian Fainelli , Vladimir Oltean , =?utf-8?B?S8O2cnk=?= Maincent , Marek =?utf-8?B?QmVow7pu?= , Oleksij Rempel , =?utf-8?Q?Nicol=C3=B2?= Veronese , mwojtas@chromium.org, Romain Gantois , Daniel Golle , Dimitri Fedrau Subject: Re: [PATCH net-next v3 05/11] net: phy: Create SFP phy_port before registering usptream Message-ID: <20260209162503.GA2478520@horms.kernel.org> References: <20260201151249.642015-1-maxime.chevallier@bootlin.com> <20260201151249.642015-6-maxime.chevallier@bootlin.com> <7150d811-df6a-488d-a7d8-96aec01365db@bootlin.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7150d811-df6a-488d-a7d8-96aec01365db@bootlin.com> On Tue, Feb 03, 2026 at 07:09:23PM +0100, Maxime Chevallier wrote: > Hi Simon, > > On 03/02/2026 18:52, Simon Horman wrote: > > >> - if (!ret && phydev->sfp_bus) > >> - ret = phy_setup_sfp_port(phydev); > >> + ret = sfp_bus_add_upstream(bus, phydev, &sfp_phydev_ops); > >> + sfp_bus_put(bus); > >> + > >> + if (ret && port) { > > > > Hi Maxime, > > > > If bus is NULL then port will not be set here. > > Arg... I though smatch was running in the NIPA ingst-mdir script, but I > was wrong :( FWWIW, I think it would be nice if it did. But I'm also not sure how well it works when applied to a full allmodconfig build. Which, AFAIK, is how NIPA tends to run. > > I'll address that in V5 as the problme is still in V4, thank you for the > report > > Maxime > > >