public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Teresa Remmet <t.remmet@phytec.de>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	upstream@lists.phytec.de, Yannic Moog <y.moog@phytec.de>,
	Benjamin Hahn <b.hahn@phytec.de>,
	Yashwanth Varakala <y.varakala@phytec.de>,
	Jan Remmet <j.remmet@phytec.de>
Subject: Re: [PATCH 1/2] dt-bindings: dp83867: add binding for ti,output-impedance property
Date: Tue, 10 Feb 2026 08:48:49 -0600	[thread overview]
Message-ID: <20260210144849.GB2675838-robh@kernel.org> (raw)
In-Reply-To: <20260129-wip-t-remmet-phytec-de-bspimx95-132_upstream-v1-1-8deccd658d16@phytec.de>

On Thu, Jan 29, 2026 at 03:13:33PM +0100, Teresa Remmet wrote:
> Add an optional device tree property, "ti,output-impedance", which
> specifies the output impedance using a raw register field value from
> 0x0 to 0x1f.
> 
> 0x0 corresponds to the highest impedance (approximately 70 ohms),
> while 0x1f represents the lowest (approximately 35 ohms).
> 
> This property allows the impedance to be configured through the
> device-tree to any required value rather than being limited to fixed
> minimum or maximum settings.
> 
> Signed-off-by: Teresa Remmet <t.remmet@phytec.de>
> ---
>  Documentation/devicetree/bindings/net/ti,dp83867.yaml | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83867.yaml b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> index 4bc1f98fd9fe..a8d8bfb68bee 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83867.yaml
> @@ -52,11 +52,20 @@ properties:
>      description: |
>        MAC Interface Impedance control to set the programmable output impedance
>        to a maximum value (70 ohms).
> -      Note: Specifying an io_impedance_ctrl nvmem cell or one of the
> -        ti,min-output-impedance, ti,max-output-impedance properties
> -        are mutually exclusive. If more than one is present, an nvmem
> -        cell takes precedence over ti,max-output-impedance, which in
> -        turn takes precedence over ti,min-output-impedance.
> +      Note: Specifying an io_impedance_ctrl nvmem cell, ti,output-impedance
> +        or one of the boolean ti,min-output-impedance and ti,max-output-impedance
> +        properties is mutually exclusive.
> +        If more than one is present the priority order is nvmem cell,
> +        ti,output-impedance, ti,max-output-impedance and last
> +        ti,min-output-impedance.
> +
> +  ti,output-impedance:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description:
> +      MAC Interface Impedance control to set the raw register value from 0x0
> +      (approx. 70 ohms) to 0x1f (approx. 35 ohms).
> +    minimum: 0
> +    maximum: 31

How does this compare to 'mac-termination-ohms'? Seems like this should 
be a common property whether it's the same or for a different location.

Rob

  reply	other threads:[~2026-02-10 14:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 14:13 [PATCH 0/2] net: phy: dp83867: add numeric impedance DT property Teresa Remmet
2026-01-29 14:13 ` [PATCH 1/2] dt-bindings: dp83867: add binding for ti,output-impedance property Teresa Remmet
2026-02-10 14:48   ` Rob Herring [this message]
2026-02-11 12:50     ` Teresa Remmet
2026-02-11 14:02       ` Andrew Lunn
2026-02-17 13:51         ` Teresa Remmet
2026-01-29 14:13 ` [PATCH 2/2] net: phy: dp83867: add numeric io impedance DT property Teresa Remmet
2026-01-29 16:25   ` Jakub Kicinski
2026-01-29 17:31 ` [PATCH 0/2] net: phy: dp83867: add numeric " Andrew Davis
2026-02-10 14:42   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260210144849.GB2675838-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=afd@ti.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=b.hahn@phytec.de \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=j.remmet@phytec.de \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=t.remmet@phytec.de \
    --cc=upstream@lists.phytec.de \
    --cc=y.moog@phytec.de \
    --cc=y.varakala@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox