* [PATCH v2] selftests/net: add test for IPv4-in-IPv6 tunneling
@ 2026-02-09 19:00 Linus Heckemann
2026-02-10 1:59 ` Hangbin Liu
2026-02-11 2:14 ` Jakub Kicinski
0 siblings, 2 replies; 3+ messages in thread
From: Linus Heckemann @ 2026-02-09 19:00 UTC (permalink / raw)
To: edumazet, liuhangbin
Cc: davem, eric.dumazet, horms, kuba, morikw2, netdev, pabeni,
syzbot+d4dda070f833dc5dc89a, Linus Heckemann
commit 81c734dae203 ("ip6_tunnel: use skb_vlan_inet_prepare() in
__ip6_tnl_rcv()") was fine in and of itself, but its backport to 6.12
(and 6.6) broke IPv4-in-IPv6 tunneling, see [1]. This adds a self-test
for basic IPv4-in-IPv6 and IPv6-in-IPv6 functionality.
[1]: https://lore.kernel.org/all/CAA2RiuSnH_2xc+-W6EnFEG00XjS-dszMq61JEvRjcGS31CBw=g@mail.gmail.com/
--
Thanks for the review, Hangbin!
---
tools/testing/selftests/net/Makefile | 1 +
tools/testing/selftests/net/ip6_tunnel.sh | 43 +++++++++++++++++++++++
2 files changed, 44 insertions(+)
create mode 100644 tools/testing/selftests/net/ip6_tunnel.sh
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
index 45c4ea381bc36..5037a344ad826 100644
--- a/tools/testing/selftests/net/Makefile
+++ b/tools/testing/selftests/net/Makefile
@@ -43,6 +43,7 @@ TEST_PROGS := \
io_uring_zerocopy_tx.sh \
ioam6.sh \
ip6_gre_headroom.sh \
+ ip6_tunnel.sh \
ip_defrag.sh \
ip_local_port_range.sh \
ipv6_flowlabel.sh \
diff --git a/tools/testing/selftests/net/ip6_tunnel.sh b/tools/testing/selftests/net/ip6_tunnel.sh
new file mode 100644
index 0000000000000..4886618fd2689
--- /dev/null
+++ b/tools/testing/selftests/net/ip6_tunnel.sh
@@ -0,0 +1,43 @@
+#!/bin/bash
+# Test that IPv4-over-IPv6 tunneling works.
+
+source lib.sh
+
+setup_prepare() {
+ ip link add transport1 type veth peer name transport2
+
+ setup_ns ns1
+ ip link set transport1 netns $ns1
+ ip -n $ns1 address add 2001:db8::1/64 dev transport1 nodad
+ ip -n $ns1 address add 2001:db8::3/64 dev transport1 nodad
+ ip -n $ns1 link set transport1 up
+ ip -n $ns1 link add link transport1 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::1 remote 2001:db8::2
+ ip -n $ns1 address add 172.0.0.1/32 peer 172.0.0.2/32 dev tunnel4
+ ip -n $ns1 link set tunnel4 up
+ ip -n $ns1 link add link transport1 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::3 remote 2001:db8::4
+ ip -n $ns1 address add 2001:db8:6::1/64 dev tunnel6
+ ip -n $ns1 link set tunnel6 up
+
+ setup_ns ns2
+ ip link set transport2 netns $ns2
+ ip -n $ns2 address add 2001:db8::2/64 dev transport2 nodad
+ ip -n $ns2 address add 2001:db8::4/64 dev transport2 nodad
+ ip -n $ns2 link set transport2 up
+ ip -n $ns2 link add link transport2 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::2 remote 2001:db8::1
+ ip -n $ns2 address add 172.0.0.2/32 peer 172.0.0.1/32 dev tunnel4
+ ip -n $ns2 link set tunnel4 up
+ ip -n $ns2 link add link transport2 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::4 remote 2001:db8::3
+ ip -n $ns2 address add 2001:db8:6::2/64 dev tunnel6
+ ip -n $ns2 link set tunnel6 up
+}
+
+cleanup() {
+ cleanup_all_ns
+ # in case the namespaces haven't been set up yet
+ ip link delete transport1 || true
+}
+
+trap cleanup EXIT
+setup_prepare
+ip netns exec $ns1 ping -W1 -c1 172.0.0.2
+ip netns exec $ns1 ping -W1 -c1 2001:db8:6::2
--
2.52.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] selftests/net: add test for IPv4-in-IPv6 tunneling
2026-02-09 19:00 [PATCH v2] selftests/net: add test for IPv4-in-IPv6 tunneling Linus Heckemann
@ 2026-02-10 1:59 ` Hangbin Liu
2026-02-11 2:14 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Hangbin Liu @ 2026-02-10 1:59 UTC (permalink / raw)
To: Linus Heckemann
Cc: edumazet, davem, eric.dumazet, horms, kuba, morikw2, netdev,
pabeni, syzbot+d4dda070f833dc5dc89a
Hi Linus,
For the subject, please also provide the target repo. e.g. [PATCH v2 net-next]
On Mon, Feb 09, 2026 at 08:00:09PM +0100, Linus Heckemann wrote:
> commit 81c734dae203 ("ip6_tunnel: use skb_vlan_inet_prepare() in
> __ip6_tnl_rcv()") was fine in and of itself, but its backport to 6.12
> (and 6.6) broke IPv4-in-IPv6 tunneling, see [1]. This adds a self-test
> for basic IPv4-in-IPv6 and IPv6-in-IPv6 functionality.
>
> [1]: https://lore.kernel.org/all/CAA2RiuSnH_2xc+-W6EnFEG00XjS-dszMq61JEvRjcGS31CBw=g@mail.gmail.com/
>
> --
> Thanks for the review, Hangbin!
> ---
> tools/testing/selftests/net/Makefile | 1 +
> tools/testing/selftests/net/ip6_tunnel.sh | 43 +++++++++++++++++++++++
> 2 files changed, 44 insertions(+)
> create mode 100644 tools/testing/selftests/net/ip6_tunnel.sh
>
> diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile
> index 45c4ea381bc36..5037a344ad826 100644
> --- a/tools/testing/selftests/net/Makefile
> +++ b/tools/testing/selftests/net/Makefile
> @@ -43,6 +43,7 @@ TEST_PROGS := \
> io_uring_zerocopy_tx.sh \
> ioam6.sh \
> ip6_gre_headroom.sh \
> + ip6_tunnel.sh \
> ip_defrag.sh \
> ip_local_port_range.sh \
> ipv6_flowlabel.sh \
> diff --git a/tools/testing/selftests/net/ip6_tunnel.sh b/tools/testing/selftests/net/ip6_tunnel.sh
> new file mode 100644
> index 0000000000000..4886618fd2689
> --- /dev/null
> +++ b/tools/testing/selftests/net/ip6_tunnel.sh
> @@ -0,0 +1,43 @@
> +#!/bin/bash
> +# Test that IPv4-over-IPv6 tunneling works.
> +
> +source lib.sh
> +
> +setup_prepare() {
> + ip link add transport1 type veth peer name transport2
> +
> + setup_ns ns1
> + ip link set transport1 netns $ns1
> + ip -n $ns1 address add 2001:db8::1/64 dev transport1 nodad
> + ip -n $ns1 address add 2001:db8::3/64 dev transport1 nodad
> + ip -n $ns1 link set transport1 up
> + ip -n $ns1 link add link transport1 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::1 remote 2001:db8::2
> + ip -n $ns1 address add 172.0.0.1/32 peer 172.0.0.2/32 dev tunnel4
> + ip -n $ns1 link set tunnel4 up
> + ip -n $ns1 link add link transport1 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::3 remote 2001:db8::4
> + ip -n $ns1 address add 2001:db8:6::1/64 dev tunnel6
> + ip -n $ns1 link set tunnel6 up
> +
> + setup_ns ns2
> + ip link set transport2 netns $ns2
> + ip -n $ns2 address add 2001:db8::2/64 dev transport2 nodad
> + ip -n $ns2 address add 2001:db8::4/64 dev transport2 nodad
> + ip -n $ns2 link set transport2 up
> + ip -n $ns2 link add link transport2 name tunnel4 type ip6tnl mode ipip6 local 2001:db8::2 remote 2001:db8::1
> + ip -n $ns2 address add 172.0.0.2/32 peer 172.0.0.1/32 dev tunnel4
> + ip -n $ns2 link set tunnel4 up
> + ip -n $ns2 link add link transport2 name tunnel6 type ip6tnl mode ip6ip6 local 2001:db8::4 remote 2001:db8::3
> + ip -n $ns2 address add 2001:db8:6::2/64 dev tunnel6
> + ip -n $ns2 link set tunnel6 up
> +}
> +
> +cleanup() {
> + cleanup_all_ns
> + # in case the namespaces haven't been set up yet
> + ip link delete transport1 || true
Maybe
ip link delete transport1 &> /dev/null || true
since this cmd usually would fail and report
Cannot find device "transport1"
> +}
You forgot to add `set -e`,
> +
> +trap cleanup EXIT
> +setup_prepare
> +ip netns exec $ns1 ping -W1 -c1 172.0.0.2
> +ip netns exec $ns1 ping -W1 -c1 2001:db8:6::2
So if the first ping failed, and the second ping pass, the total test will
still return 0.
Thanks
Hangbin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v2] selftests/net: add test for IPv4-in-IPv6 tunneling
2026-02-09 19:00 [PATCH v2] selftests/net: add test for IPv4-in-IPv6 tunneling Linus Heckemann
2026-02-10 1:59 ` Hangbin Liu
@ 2026-02-11 2:14 ` Jakub Kicinski
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2026-02-11 2:14 UTC (permalink / raw)
To: Linus Heckemann
Cc: edumazet, liuhangbin, davem, eric.dumazet, horms, morikw2, netdev,
pabeni, syzbot+d4dda070f833dc5dc89a
On Mon, 9 Feb 2026 20:00:09 +0100 Linus Heckemann wrote:
> commit 81c734dae203 ("ip6_tunnel: use skb_vlan_inet_prepare() in
> __ip6_tnl_rcv()") was fine in and of itself, but its backport to 6.12
> (and 6.6) broke IPv4-in-IPv6 tunneling, see [1]. This adds a self-test
> for basic IPv4-in-IPv6 and IPv6-in-IPv6 functionality.
>
> [1]: https://lore.kernel.org/all/CAA2RiuSnH_2xc+-W6EnFEG00XjS-dszMq61JEvRjcGS31CBw=g@mail.gmail.com/
Missing your Signed-off-by: ...
Is this the output you expect (ignore the first two numbers, they are
just output timing within our infra):
TAP version 13
1..1
# overriding timeout to 7200
# selftests: net: ip6_tunnel.sh
# Warning: file ip6_tunnel.sh is not executable
# 1.17 [+1.17] PING 172.0.0.2 (172.0.0.2) 56(84) bytes of data.
# 1.18 [+0.00] 64 bytes from 172.0.0.2: icmp_seq=1 ttl=64 time=2.31 ms
# 1.18 [+0.00]
# 1.18 [+0.00] --- 172.0.0.2 ping statistics ---
# 1.19 [+0.00] 1 packets transmitted, 1 received, 0% packet loss, time 0ms
# 1.19 [+0.00] rtt min/avg/max/mdev = 2.311/2.311/2.311/0.000 ms
# 1.24 [+0.05] PING 2001:db8:6::2 (2001:db8:6::2) 56 data bytes
# 1.24 [+0.00] 64 bytes from 2001:db8:6::2: icmp_seq=1 ttl=64 time=0.368 ms
# 1.25 [+0.00]
# 1.25 [+0.00] --- 2001:db8:6::2 ping statistics ---
# 1.25 [+0.00] 1 packets transmitted, 1 received, 0% packet loss, time 0ms
# 1.25 [+0.00] rtt min/avg/max/mdev = 0.368/0.368/0.368/0.000 ms
# 1.58 [+0.33] Cannot find device "transport1"
ok 1 selftests: net: ip6_tunnel.sh
Tests don't usually print raw ping output to stdout, plus the
Cannot find device "transport1"
looks a bit off?
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-11 2:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-09 19:00 [PATCH v2] selftests/net: add test for IPv4-in-IPv6 tunneling Linus Heckemann
2026-02-10 1:59 ` Hangbin Liu
2026-02-11 2:14 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox