public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>,
	 David Ahern <dsahern@kernel.org>
Cc: netdev@vger.kernel.org, mptcp@lists.linux.dev,
	 "Matthieu Baerts (NGI0)" <matttbe@kernel.org>
Subject: [PATCH iproute2 1/2] mptcp: monitor: also show iface name
Date: Wed, 11 Feb 2026 13:03:17 +0100	[thread overview]
Message-ID: <20260211-mptcp-color-v1-1-01832777611d@kernel.org> (raw)
In-Reply-To: <20260211-mptcp-color-v1-0-01832777611d@kernel.org>

Previously, only the interface index was printed.

It is helpful to display the interface name, instead of letting the
reader doing the translation from the index to the name.

Because the index was already displayed before, keep it instead of
replacing it, just not to break some possible scripts parsing this
output.

Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
---
 ip/ipmptcp.c | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/ip/ipmptcp.c b/ip/ipmptcp.c
index acd008f3..5f194aca 100644
--- a/ip/ipmptcp.c
+++ b/ip/ipmptcp.c
@@ -471,6 +471,17 @@ static void print_addr(const char *key, int af, struct rtattr *value)
 		printf(" %s=%s", key, str);
 }
 
+static void print_iface(int index)
+{
+	const char *ifname;
+
+	printf(" ifindex=%d", index);
+
+	ifname = index ? ll_index_to_name(index) : NULL;
+	if (ifname)
+		printf(" dev=%s", ifname);
+}
+
 static int mptcp_monitor_msg(struct rtnl_ctrl_data *ctrl,
 			     struct nlmsghdr *n, void *arg)
 {
@@ -530,7 +541,7 @@ static int mptcp_monitor_msg(struct rtnl_ctrl_data *ctrl,
 	if (tb[MPTCP_ATTR_TIMEOUT])
 		printf(" timeout=%u", rta_getattr_u32(tb[MPTCP_ATTR_TIMEOUT]));
 	if (tb[MPTCP_ATTR_IF_IDX])
-		printf(" ifindex=%d", rta_getattr_s32(tb[MPTCP_ATTR_IF_IDX]));
+		print_iface(rta_getattr_s32(tb[MPTCP_ATTR_IF_IDX]));
 	if (tb[MPTCP_ATTR_RESET_REASON])
 		printf(" reset_reason=%u", rta_getattr_u32(tb[MPTCP_ATTR_RESET_REASON]));
 	if (tb[MPTCP_ATTR_RESET_FLAGS])

-- 
2.51.0


  reply	other threads:[~2026-02-11 12:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 12:03 [PATCH iproute2 0/2] mptcp: support colors & display iface name Matthieu Baerts (NGI0)
2026-02-11 12:03 ` Matthieu Baerts (NGI0) [this message]
2026-02-18 18:31   ` [PATCH iproute2 1/2] mptcp: monitor: also show " Stephen Hemminger
2026-02-18 19:03     ` Matthieu Baerts
2026-02-19 17:11       ` Stephen Hemminger
2026-02-19 17:38         ` Matthieu Baerts
2026-02-19 19:22           ` Stephen Hemminger
2026-02-19 19:26             ` Matthieu Baerts
2026-02-11 12:03 ` [PATCH iproute2 2/2] mptcp: display addr & ifname in color Matthieu Baerts (NGI0)
2026-02-18  4:00 ` [PATCH iproute2 0/2] mptcp: support colors & display iface name patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260211-mptcp-color-v1-1-01832777611d@kernel.org \
    --to=matttbe@kernel.org \
    --cc=dsahern@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox