* [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages
@ 2026-02-11 5:43 Erni Sri Satya Vennela
2026-02-11 18:42 ` Jakub Kicinski
0 siblings, 1 reply; 5+ messages in thread
From: Erni Sri Satya Vennela @ 2026-02-11 5:43 UTC (permalink / raw)
To: ernis, kys, haiyangz, wei.liu, decui, longli, andrew+netdev,
davem, edumazet, kuba, pabeni, dipayanroy, ernis, shradhagupta,
shirazsaleem, gargaditya, linux-hyperv, netdev, linux-kernel
Add MAC address to vPort configuration success message and update error
message to be more specific about HWC message errors in
mana_send_request and mana_hwc_send_request.
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
---
Changes in v3:
* Remove the changes from v2 and Update commit message.
* Use "Enabled vPort ..." instead of "Configured vPort" in
mana_cfg_vport.
* Update error logs in mana_hwc_send_request.
Changes in v2:
* Update commit message.
* Use "Enabled vPort ..." instead of "Configured vPort" in
mana_cfg_vport.
* Add info log in mana_uncfg_vport, mana_gd_verify_vf_version,
mana_gd_query_max_resources, mana_query_device_cfg and
mana_query_vport_cfg.
---
.../net/ethernet/microsoft/mana/hw_channel.c | 19 +++++++++++--------
drivers/net/ethernet/microsoft/mana/mana_en.c | 8 ++++----
2 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index aa4e2731e2ba..d4fd513dc1d6 100644
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -853,6 +853,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
struct hwc_caller_ctx *ctx;
u32 dest_vrcq = 0;
u32 dest_vrq = 0;
+ u32 command;
u16 msg_id;
int err;
@@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
tx_wr = &txq->msg_buf->reqs[msg_id];
if (req_len > tx_wr->buf_len) {
- dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len,
- tx_wr->buf_len);
+ dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n",
+ __func__, __LINE__, req_len, tx_wr->buf_len);
err = -EINVAL;
goto out;
}
@@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
req_msg->req.hwc_msg_id = msg_id;
tx_wr->msg_size = req_len;
+ command = req_msg->req.msg_type;
if (gc->is_pf) {
dest_vrq = hwc->pf_dest_vrq_id;
@@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false);
if (err) {
- dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err);
+ dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n",
+ __func__, __LINE__, err);
goto out;
}
if (!wait_for_completion_timeout(&ctx->comp_event,
(msecs_to_jiffies(hwc->hwc_timeout)))) {
if (hwc->hwc_timeout != 0)
- dev_err(hwc->dev, "HWC: Request timed out: %u ms\n",
- hwc->hwc_timeout);
+ dev_err(hwc->dev, "%s:%d: Command 0x%x timed out: %u ms\n",
+ __func__, __LINE__, command, hwc->hwc_timeout);
/* Reduce further waiting if HWC no response */
if (hwc->hwc_timeout > 1)
@@ -914,9 +917,9 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
err = -EOPNOTSUPP;
goto out;
}
- if (req_msg->req.msg_type != MANA_QUERY_PHY_STAT)
- dev_err(hwc->dev, "HWC: Failed hw_channel req: 0x%x\n",
- ctx->status_code);
+ if (command != MANA_QUERY_PHY_STAT)
+ dev_err(hwc->dev, "%s:%d: Command 0x%x failed with status: 0x%x\n",
+ __func__, __LINE__, command, ctx->status_code);
err = -EPROTO;
goto out;
}
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 9b5a72ada5c4..53f24244de75 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -1023,8 +1023,8 @@ static int mana_send_request(struct mana_context *ac, void *in_buf,
if (req->req.msg_type != MANA_QUERY_PHY_STAT &&
mana_need_log(gc, err))
- dev_err(dev, "Failed to send mana message: %d, 0x%x\n",
- err, resp->status);
+ dev_err(dev, "Command 0x%x failed with status: 0x%x, err: %d\n",
+ req->req.msg_type, resp->status, err);
return err ? err : -EPROTO;
}
@@ -1337,8 +1337,8 @@ int mana_cfg_vport(struct mana_port_context *apc, u32 protection_dom_id,
apc->tx_shortform_allowed = resp.short_form_allowed;
apc->tx_vp_offset = resp.tx_vport_offset;
- netdev_info(apc->ndev, "Configured vPort %llu PD %u DB %u\n",
- apc->port_handle, protection_dom_id, doorbell_pg_id);
+ netdev_info(apc->ndev, "Enabled vPort %llu PD %u DB %u MAC %pM\n",
+ apc->port_handle, protection_dom_id, doorbell_pg_id, apc->mac_addr);
out:
if (err)
mana_uncfg_vport(apc);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages
2026-02-11 5:43 [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages Erni Sri Satya Vennela
@ 2026-02-11 18:42 ` Jakub Kicinski
0 siblings, 0 replies; 5+ messages in thread
From: Jakub Kicinski @ 2026-02-11 18:42 UTC (permalink / raw)
To: Erni Sri Satya Vennela
Cc: ernis, kys, haiyangz, wei.liu, decui, longli, andrew+netdev,
davem, edumazet, pabeni, dipayanroy, shradhagupta, shirazsaleem,
gargaditya, linux-hyperv, netdev, linux-kernel
On Tue, 10 Feb 2026 21:43:24 -0800 Erni Sri Satya Vennela wrote:
> Add MAC address to vPort configuration success message and update error
> message to be more specific about HWC message errors in
> mana_send_request and mana_hwc_send_request.
## Form letter - net-next-closed
We have already submitted our pull request with net-next material for v7.0,
and therefore net-next is closed for new drivers, features, code refactoring
and optimizations. We are currently accepting bug fixes only.
Please repost when net-next reopens after Feb 23rd.
RFC patches sent for review only are obviously welcome at any time.
See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle
--
pw-bot: defer
pv-bot: closed
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages
@ 2026-02-23 4:08 Erni Sri Satya Vennela
2026-02-24 12:22 ` Paolo Abeni
0 siblings, 1 reply; 5+ messages in thread
From: Erni Sri Satya Vennela @ 2026-02-23 4:08 UTC (permalink / raw)
To: Erni Sri Satya Vennela, kys, haiyangz, wei.liu, decui, longli,
andrew+netdev, davem, edumazet, kuba, pabeni, dipayanroy, ssengar,
shradhagupta, ernis, shirazsaleem, gargaditya, linux-hyperv,
netdev, linux-kernel
Add MAC address to vPort configuration success message and update error
message to be more specific about HWC message errors in
mana_send_request and mana_hwc_send_request.
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
---
Changes in v3:
* Remove the changes from v2 and Update commit message.
* Use "Enabled vPort ..." instead of "Configured vPort" in
mana_cfg_vport.
* Update error logs in mana_hwc_send_request.
Changes in v2:
* Update commit message.
* Use "Enabled vPort ..." instead of "Configured vPort" in
mana_cfg_vport.
* Add info log in mana_uncfg_vport, mana_gd_verify_vf_version,
mana_gd_query_max_resources, mana_query_device_cfg and
mana_query_vport_cfg.
---
.../net/ethernet/microsoft/mana/hw_channel.c | 19 +++++++++++--------
drivers/net/ethernet/microsoft/mana/mana_en.c | 8 ++++----
2 files changed, 15 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/microsoft/mana/hw_channel.c b/drivers/net/ethernet/microsoft/mana/hw_channel.c
index aa4e2731e2ba..d4fd513dc1d6 100644
--- a/drivers/net/ethernet/microsoft/mana/hw_channel.c
+++ b/drivers/net/ethernet/microsoft/mana/hw_channel.c
@@ -853,6 +853,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
struct hwc_caller_ctx *ctx;
u32 dest_vrcq = 0;
u32 dest_vrq = 0;
+ u32 command;
u16 msg_id;
int err;
@@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
tx_wr = &txq->msg_buf->reqs[msg_id];
if (req_len > tx_wr->buf_len) {
- dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len,
- tx_wr->buf_len);
+ dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n",
+ __func__, __LINE__, req_len, tx_wr->buf_len);
err = -EINVAL;
goto out;
}
@@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
req_msg->req.hwc_msg_id = msg_id;
tx_wr->msg_size = req_len;
+ command = req_msg->req.msg_type;
if (gc->is_pf) {
dest_vrq = hwc->pf_dest_vrq_id;
@@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false);
if (err) {
- dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err);
+ dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n",
+ __func__, __LINE__, err);
goto out;
}
if (!wait_for_completion_timeout(&ctx->comp_event,
(msecs_to_jiffies(hwc->hwc_timeout)))) {
if (hwc->hwc_timeout != 0)
- dev_err(hwc->dev, "HWC: Request timed out: %u ms\n",
- hwc->hwc_timeout);
+ dev_err(hwc->dev, "%s:%d: Command 0x%x timed out: %u ms\n",
+ __func__, __LINE__, command, hwc->hwc_timeout);
/* Reduce further waiting if HWC no response */
if (hwc->hwc_timeout > 1)
@@ -914,9 +917,9 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
err = -EOPNOTSUPP;
goto out;
}
- if (req_msg->req.msg_type != MANA_QUERY_PHY_STAT)
- dev_err(hwc->dev, "HWC: Failed hw_channel req: 0x%x\n",
- ctx->status_code);
+ if (command != MANA_QUERY_PHY_STAT)
+ dev_err(hwc->dev, "%s:%d: Command 0x%x failed with status: 0x%x\n",
+ __func__, __LINE__, command, ctx->status_code);
err = -EPROTO;
goto out;
}
diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c
index 9b5a72ada5c4..53f24244de75 100644
--- a/drivers/net/ethernet/microsoft/mana/mana_en.c
+++ b/drivers/net/ethernet/microsoft/mana/mana_en.c
@@ -1023,8 +1023,8 @@ static int mana_send_request(struct mana_context *ac, void *in_buf,
if (req->req.msg_type != MANA_QUERY_PHY_STAT &&
mana_need_log(gc, err))
- dev_err(dev, "Failed to send mana message: %d, 0x%x\n",
- err, resp->status);
+ dev_err(dev, "Command 0x%x failed with status: 0x%x, err: %d\n",
+ req->req.msg_type, resp->status, err);
return err ? err : -EPROTO;
}
@@ -1337,8 +1337,8 @@ int mana_cfg_vport(struct mana_port_context *apc, u32 protection_dom_id,
apc->tx_shortform_allowed = resp.short_form_allowed;
apc->tx_vp_offset = resp.tx_vport_offset;
- netdev_info(apc->ndev, "Configured vPort %llu PD %u DB %u\n",
- apc->port_handle, protection_dom_id, doorbell_pg_id);
+ netdev_info(apc->ndev, "Enabled vPort %llu PD %u DB %u MAC %pM\n",
+ apc->port_handle, protection_dom_id, doorbell_pg_id, apc->mac_addr);
out:
if (err)
mana_uncfg_vport(apc);
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages
2026-02-23 4:08 Erni Sri Satya Vennela
@ 2026-02-24 12:22 ` Paolo Abeni
2026-02-25 17:36 ` Erni Sri Satya Vennela
0 siblings, 1 reply; 5+ messages in thread
From: Paolo Abeni @ 2026-02-24 12:22 UTC (permalink / raw)
To: Erni Sri Satya Vennela, Erni Sri Satya Vennela, kys, haiyangz,
wei.liu, decui, longli, andrew+netdev, davem, edumazet, kuba,
dipayanroy, ssengar, shradhagupta, shirazsaleem, gargaditya,
linux-hyperv, netdev, linux-kernel
On 2/23/26 5:08 AM, Erni Sri Satya Vennela wrote:
> @@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> tx_wr = &txq->msg_buf->reqs[msg_id];
>
> if (req_len > tx_wr->buf_len) {
> - dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len,
> - tx_wr->buf_len);
> + dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n",
> + __func__, __LINE__, req_len, tx_wr->buf_len);
I fail to see any relevant information added here ...
> err = -EINVAL;
> goto out;
> }
> @@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> req_msg->req.hwc_msg_id = msg_id;
>
> tx_wr->msg_size = req_len;
> + command = req_msg->req.msg_type;
>
> if (gc->is_pf) {
> dest_vrq = hwc->pf_dest_vrq_id;
> @@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
>
> err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false);
> if (err) {
> - dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err);
> + dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n",
> + __func__, __LINE__, err);
... and here. The string message should be (and apparently is) enough to
locate the relevant code inside the tree. Please don't included
unneeded/irrelevant changes.
Thanks,
Paolo
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages
2026-02-24 12:22 ` Paolo Abeni
@ 2026-02-25 17:36 ` Erni Sri Satya Vennela
0 siblings, 0 replies; 5+ messages in thread
From: Erni Sri Satya Vennela @ 2026-02-25 17:36 UTC (permalink / raw)
To: Paolo Abeni
Cc: Erni Sri Satya Vennela, kys, haiyangz, wei.liu, decui, longli,
andrew+netdev, davem, edumazet, kuba, dipayanroy, ssengar,
shradhagupta, shirazsaleem, gargaditya, linux-hyperv, netdev,
linux-kernel
On Tue, Feb 24, 2026 at 01:22:58PM +0100, Paolo Abeni wrote:
> On 2/23/26 5:08 AM, Erni Sri Satya Vennela wrote:
> > @@ -861,8 +862,8 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> > tx_wr = &txq->msg_buf->reqs[msg_id];
> >
> > if (req_len > tx_wr->buf_len) {
> > - dev_err(hwc->dev, "HWC: req msg size: %d > %d\n", req_len,
> > - tx_wr->buf_len);
> > + dev_err(hwc->dev, "%s:%d: req msg size: %d > %d\n",
> > + __func__, __LINE__, req_len, tx_wr->buf_len);
>
> I fail to see any relevant information added here ...
>
> > err = -EINVAL;
> > goto out;
> > }
> > @@ -878,6 +879,7 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> > req_msg->req.hwc_msg_id = msg_id;
> >
> > tx_wr->msg_size = req_len;
> > + command = req_msg->req.msg_type;
> >
> > if (gc->is_pf) {
> > dest_vrq = hwc->pf_dest_vrq_id;
> > @@ -886,15 +888,16 @@ int mana_hwc_send_request(struct hw_channel_context *hwc, u32 req_len,
> >
> > err = mana_hwc_post_tx_wqe(txq, tx_wr, dest_vrq, dest_vrcq, false);
> > if (err) {
> > - dev_err(hwc->dev, "HWC: Failed to post send WQE: %d\n", err);
> > + dev_err(hwc->dev, "%s:%d: Failed to post send WQE: %d\n",
> > + __func__, __LINE__, err);
>
> ... and here. The string message should be (and apparently is) enough to
> locate the relevant code inside the tree. Please don't included
> unneeded/irrelevant changes.
>
> Thanks,
>
> Paolo
Thank you for the clarification, Paolo. I’ll drop these changes in the
next revision.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-25 17:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-11 5:43 [PATCH net-next v3] net: mana: Add MAC address to vPort logs and clarify error messages Erni Sri Satya Vennela
2026-02-11 18:42 ` Jakub Kicinski
-- strict thread matches above, loose matches on Subject: below --
2026-02-23 4:08 Erni Sri Satya Vennela
2026-02-24 12:22 ` Paolo Abeni
2026-02-25 17:36 ` Erni Sri Satya Vennela
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox