From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59A21345725; Wed, 11 Feb 2026 17:03:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770829424; cv=none; b=d7MHBE3SOvHb7AdLPvtkQaCAzPALr93qh/o+NFEYcJJrDTUFXQcK0mN/3YOBrsdbB2NVr+wkJrsYCcPKUa3I5d7cSN4bVKqUY4IpmxarXnpYyB4yoh9kq3Cl5x7NygE5TxDqc/aV4WOFHCIsVT1TKX8l+K5n8VFWTqI+7eHMcE4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770829424; c=relaxed/simple; bh=E99E2loPe1XNp/4rNcxLKLp/1fEYb2lWU2cfOaniQfc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Ax1ucAFObH52a3dhINqu9CzwffVQglEf1VHFjS2kFe3TOMZfYK/foPLe21l6HYrg8xvotcuPQ6UVvZvZ6HC3dsK3+AOq0y0M4DR3VG+WqAmXrATqC8oXQm766Thjx9zpGWeP2w/2kLvKxtKyz+mruzDSQKR8R2jjPOcbNueySK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jMFlzRlF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jMFlzRlF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 731C0C19423; Wed, 11 Feb 2026 17:03:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770829423; bh=E99E2loPe1XNp/4rNcxLKLp/1fEYb2lWU2cfOaniQfc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jMFlzRlFXIsiNrEqUqXhlSVsdXOgiUqKehMm6RtDeDD0gdBAuiB4Nrxx7miCl27Dv 47577Cbis/av4coUEQfVSRhzfwgx8g2LzgsRy3nuOVBl3Rx7afW75c5xSTavkV993R ypqKS/7ypaOVauvJITohr1PpKpO+C4sGWmO7XVvem/0D0+j83D/2p9Gsv9l942EkiK tBp/+KNeUxhi1pXeNMasd6ORr1ruhpv9CQ8oJXeoAfFUh9KJ+Ok+Bv/D2SIf9b3bNi FPdBrI4H5OQtrgLiZVw7zPXwdk92EERZhSYpkRJ0uNOhlseq5T0F/0V+MgIL/jEp1E 1z3zaG2V74psA== Date: Wed, 11 Feb 2026 09:03:42 -0800 From: Jakub Kicinski To: Yohei Kojima Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Jonathan Corbet , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2] docs: ethtool: clarify the bit-by-bit bitset format description Message-ID: <20260211090342.561a9d54@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 7 Feb 2026 19:25:38 +0900 Yohei Kojima wrote: > Clarify the bit-by-bit bitset format's behavior around mandatory > attributes and bit identification. More specifically, the following > changes are made: > > * Rephrase a misleading sentence which implies name and index are > mutually exclusive > * Describe that ETHTOOL_A_BITSET_BITS nest is mandatory > * Describe that a request fails if inconsistent identifiers are given > > Signed-off-by: Yohei Kojima I'm no native speaker but FWIW: Reviewed-by: Jakub Kicinski