From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3C124C81 for ; Thu, 12 Feb 2026 14:40:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770907259; cv=none; b=LNwtyV7Kdain+SHTaQDTq6Zfc+CJwpWkJ5CGrm6l5AsNFT6hLDD0ZCvC3PiP64HJ73l73C1AZ0Wz5SIOZpc1/D/t9UAkU9xSVbpbbzxlQN3cVakP8iRplUhuu/4ZxWCXfCKyzhLFEhSgN7ihP8R/SAiFGQ/AJUNeb4MIubSJ2qU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770907259; c=relaxed/simple; bh=MV+loLSfbym18ym6CF0ldD6FyGE5WQufzZjWV/GujiQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pKyMoMfUONWvBDjGaYfmuqg637HMmgnJG/JONHC9KOsq45pbhsxt7j10dCBuiT6z/5ubVDUI9fLt1CSVkKOW1FTNtVaafnuVLfSG4sksE26ezFFSlp5hZhGn3gMVV7UaJZEFKWpHalB6b5de2dDLSQtPPbV2ncxZTR/ibQlAN2Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=TNixEaD5; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=rTEPpnE+; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TNixEaD5"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="rTEPpnE+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770907256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uDKQzbGUuJRbgtDN0hG7BvdewQ/ExGQehaybklKCcDA=; b=TNixEaD5l9D11nSoZRWPhhZnrVG2Kq7+S2OSyRyIuJwv6XzPhjg0KUNZeqAe8LlpoRD7Su xqc/o+YsHoKq7kwQxfry4NOo5jVEob+pCbesAwREETFX5mwXsj7gPErhGXNVO+iNkY7TfM bEAGlkVY0/usreLTmuTpmi25Ql9Iqo4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-25-nA8zpBljNnex-zIxv4k27w-1; Thu, 12 Feb 2026 09:40:55 -0500 X-MC-Unique: nA8zpBljNnex-zIxv4k27w-1 X-Mimecast-MFC-AGG-ID: nA8zpBljNnex-zIxv4k27w_1770907255 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-480717a8ef9so18685275e9.1 for ; Thu, 12 Feb 2026 06:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770907254; x=1771512054; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=uDKQzbGUuJRbgtDN0hG7BvdewQ/ExGQehaybklKCcDA=; b=rTEPpnE+eEoCgviilZ+8SMHp5jquRmqyuD/CvRqequ+2GOrNuBnpy9Dtf7geh7GWRR PA2zzOuYfpURp3uwNfZnmwkPy9gdbMSQHsGcZrenYlRhVEIA23UM8C7hasnAfseYQhVW xszuZZRdXyDvH0rw173ZE2rkBS27CWQwiT4wrfts+uQNi61jV5r845x5lUIBE18izqpb rCVQHgqQBOxCD3stIq7t/jLou8qVyG5Kv1kvEiPe3JBp0u9/kYQLyVjx9GL37ZNSI7C6 eMvku0Fku5AJnh6wDIsSeUG1Qg5e141/YHbLb18Gr8vRMUGS64Y0eFfHraWD27n0n82f VBSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770907254; x=1771512054; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uDKQzbGUuJRbgtDN0hG7BvdewQ/ExGQehaybklKCcDA=; b=CYf1Z8mER/TXOG4OSiurcO2xi8uW3WmmDEUcgBcDDG0BlbVAqo7pOAAImP7E9GvyDR zgQihRuohD6E+N+hnYyn0xb6JUFoJifU57QqFCaHHClwvgYXAX4xjsTy5SZtpv9RwvaK 4SRldvbfYN6jXxPcNtlktEC8URzdOV21ur4VcugRgQg3d2G5vS41dUheSg5R5aPh4/l+ 8gvP5ezPeDZ+o9dZA54fA87TCN/LLK6gcEoqzRmOaEKkGKp0Ifibdp0FJylvqOZ+W89t 3giik53g29u9yQts/yUVLlvTTb1hzzKEAG1mTjPZ6j7JrOJNKHGn5yYDdskRz0qdMciM qSeA== X-Gm-Message-State: AOJu0Yz3K6jtLM1U9/403qJQP/VAaSu6fG8QwD49EmVjLnVytdgA/B3B PrhAgMTH1+iJ0yGMJ+3pPDp5U2NBfm9vVb1+eBiylWLImzvzU4VUoyAgAd82cHVP8cu31WswylF JD6LN/Qy+vNdM3pUWvIV5XpgDkxzu5BK/Qlt7j94f1b84SRqAKi1Y7LSzSA== X-Gm-Gg: AZuq6aKKZfTxq+ImOSU/JRdpx/a+2T0RvfKDdqAgC2Tx2zAW0pm+LvBiGpJRdu9Lc5X 5iF1oQnN92BUbANRGtjrX7j4kiKJy92uB6/zivMeMA/5Mk/43yGEm7SaLSbsGKqlxEiaGU/j5jV 7DrLYOPzjR6p7X8EM960N9gzKFUXztDFmnLrP7kKVer8kfqk8TjbPqH7YnKYm/YPuVt8AxuYuBO yN6zgehpc3DDS67k9zqT2tVz2+4evmZYjkKaRIjydOyJuCpgTr/QpGwszpHsQ2G0YWsK1Os6mCd VVL0VgApMCKgToViu9LI8mYbokzo7C7P5OllL1qJuHJa5VaMI1v76YOOkT434OF+0zWSbFlfPeU g/du9ycNcivzyRfgPE2XhZpqBdD6ZDLWf1fk9uHr3ItWyUQ== X-Received: by 2002:a05:600c:4d06:b0:47e:e7de:7c41 with SMTP id 5b1f17b1804b1-483660306b6mr26987365e9.16.1770907254301; Thu, 12 Feb 2026 06:40:54 -0800 (PST) X-Received: by 2002:a05:600c:4d06:b0:47e:e7de:7c41 with SMTP id 5b1f17b1804b1-483660306b6mr26986955e9.16.1770907253657; Thu, 12 Feb 2026 06:40:53 -0800 (PST) Received: from redhat.com (IGLD-80-230-34-155.inter.net.il. [80.230.34.155]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4835ba1670fsm77265075e9.4.2026.02.12.06.40.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Feb 2026 06:40:53 -0800 (PST) Date: Thu, 12 Feb 2026 09:40:49 -0500 From: "Michael S. Tsirkin" To: Srujana Challa Cc: netdev@vger.kernel.org, virtualization@lists.linux.dev, pabeni@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, eperezma@redhat.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, ndabilpuram@marvell.com, kshankar@marvell.com, stable@vger.kernel.org Subject: Re: [PATCH v3,net] virtio_net: Improve RSS key size validation Message-ID: <20260212093707-mutt-send-email-mst@kernel.org> References: <20260212130340.3540415-1-schalla@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260212130340.3540415-1-schalla@marvell.com> On Thu, Feb 12, 2026 at 06:33:40PM +0530, Srujana Challa wrote: > Replace hardcoded RSS max key size limit with a type based definition. > Add validation for RSS key size against spec minimum (40 bytes). When > validation fails, gracefully disable RSS features and continue > initialization rather than failing completely. > > Cc: stable@vger.kernel.org > Fixes: 3f7d9c1964fc ("virtio_net: Add hash_key_length check") > Signed-off-by: Srujana Challa > > v3: > - Moved RSS key validation checks to virtnet_validate. > - Add fixes: tag and CC -stable > --- > drivers/net/virtio_net.c | 29 +++++++++++++++++++++-------- > 1 file changed, 21 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index db88dcaefb20..e61cea50dcab 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -381,7 +381,9 @@ struct receive_queue { > struct xdp_buff **xsk_buffs; > }; > > -#define VIRTIO_NET_RSS_MAX_KEY_SIZE 40 > +#define VIRTIO_NET_RSS_MAX_KEY_SIZE \ > + (type_max(((struct virtio_net_config *)0)->rss_max_key_size) + 1) +1 here really unintuitive. It does not look like it's still used, though? > +#define VIRTIO_NET_RSS_MIN_KEY_SIZE 40 > > /* Control VQ buffers: protected by the rtnl lock */ > struct control_buf { > @@ -6627,6 +6629,24 @@ static int virtnet_validate(struct virtio_device *vdev) > __virtio_clear_bit(vdev, VIRTIO_NET_F_STANDBY); > } > > + if (virtio_has_feature(vdev, VIRTIO_NET_F_RSS) || > + virtio_has_feature(vdev, VIRTIO_NET_F_HASH_REPORT)) { > + u8 key_sz = virtio_cread8(vdev, > + offsetof(struct virtio_net_config, > + rss_max_key_size)); > + /* Spec requires at least 40 bytes */ move the define here then? > + if (key_sz < VIRTIO_NET_RSS_MIN_KEY_SIZE) { > + dev_warn(&vdev->dev, > + "rss_max_key_size=%u is less than spec minimum %u, disabling RSS\n", > + key_sz, VIRTIO_NET_RSS_MIN_KEY_SIZE); > + if (virtio_has_feature(vdev, VIRTIO_NET_F_RSS)) > + __virtio_clear_bit(vdev, VIRTIO_NET_F_RSS); > + if (virtio_has_feature(vdev, VIRTIO_NET_F_HASH_REPORT)) > + __virtio_clear_bit(vdev, > + VIRTIO_NET_F_HASH_REPORT); why not clear them unconditionally? > + } > + } > + > return 0; > } > > @@ -6839,13 +6859,6 @@ static int virtnet_probe(struct virtio_device *vdev) > if (vi->has_rss || vi->has_rss_hash_report) { > vi->rss_key_size = > virtio_cread8(vdev, offsetof(struct virtio_net_config, rss_max_key_size)); > - if (vi->rss_key_size > VIRTIO_NET_RSS_MAX_KEY_SIZE) { > - dev_err(&vdev->dev, "rss_max_key_size=%u exceeds the limit %u.\n", > - vi->rss_key_size, VIRTIO_NET_RSS_MAX_KEY_SIZE); > - err = -EINVAL; > - goto free; > - } > - > vi->rss_hash_types_supported = > virtio_cread32(vdev, offsetof(struct virtio_net_config, supported_hash_types)); > vi->rss_hash_types_supported &= > -- > 2.25.1