public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Junjie Cao <junjie.cao@intel.com>
To: miriam.rachel.korenblit@intel.com, johannes.berg@intel.com,
	linux-wireless@vger.kernel.org, richardcochran@gmail.com
Cc: horms@kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, yedidya.ben.shimol@intel.com,
	avraham.stern@intel.com, daniel.gabay@intel.com,
	krishnanand.prabhu@intel.com, luciano.coelho@intel.com,
	gregory.greenman@intel.com, stable@vger.kernel.org
Subject: Re: [PATCH] wifi: iwlwifi: ptp: Fix potential race condition in PTP removal
Date: Thu, 12 Feb 2026 18:24:02 +0800	[thread overview]
Message-ID: <20260212102402.1283533-1-junjie.cao@intel.com> (raw)
In-Reply-To: <DM3PPF63A6024A9E1EF4081E342AF4BED81A365A@DM3PPF63A6024A9.namprd11.prod.outlook.com>

Hi Miri,

You're right -- cancel_delayed_work_sync() handles re-arming by design,
and the work is scheduled with a 1-hour delay (IWL_PTP_WRAP_TIME =
3600 * HZ), so it cannot realistically fire again during the
microsecond-scale teardown window.

The real issue is simply that the delayed work can execute between
ptp_clock_unregister() and cancel_delayed_work_sync(), observing
partially cleared PTP state.

I'll send a v2 with a corrected commit message, and also split the
patch into two (one per sub-driver) as Simon suggested.

Thanks for the review!

Junjie

  reply	other threads:[~2026-02-12 10:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 16:15 [PATCH] wifi: iwlwifi: ptp: Fix potential race condition in PTP removal Junjie Cao
2026-01-19 17:29 ` Simon Horman
2026-01-19 21:32 ` Vadim Fedorenko
2026-02-09  8:32 ` Korenblit, Miriam Rachel
2026-02-12 10:24   ` Junjie Cao [this message]
2026-02-12 12:50   ` [PATCH v2 1/2] wifi: iwlwifi: mvm: fix " Junjie Cao
2026-02-12 12:50     ` [PATCH v2 2/2] wifi: iwlwifi: mld: " Junjie Cao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212102402.1283533-1-junjie.cao@intel.com \
    --to=junjie.cao@intel.com \
    --cc=avraham.stern@intel.com \
    --cc=daniel.gabay@intel.com \
    --cc=gregory.greenman@intel.com \
    --cc=horms@kernel.org \
    --cc=johannes.berg@intel.com \
    --cc=krishnanand.prabhu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=yedidya.ben.shimol@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox