From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24936221726; Fri, 13 Feb 2026 03:05:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770951936; cv=none; b=Ri0n5zgVws0EYqviGbvmqvcscr/H1CtrW6LoJzfDm8Rewtm9LPdXQgiTjh4ggdqS44uvKB9k7bu0FI3n/atgqCsUAy9OzzKYfOEEBuj2HVtkFBQn5JUaKUNDkF5DTKQ+0a0sPkAw97jCkUFs161QEjxiSR8o4xAzoXVBOuQfLrw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770951936; c=relaxed/simple; bh=xy1H1KWisVrqdFCNDf6YZe11NWXWdfjP3WJvVZI50/0=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CiYJ8uWzKOIz35M6VVM3NxeItIqGYlos8kK7S9jRSJ/BN8YBx4E1oMgHqlieLDeHU2ysgbVDcxxWHgM+qScVs8iF/eW/t9adAA5NzKfqMc58R+hTTHRiSys8bWkD+zkI5DGoOcpLQiD5c7eqmAptfOi8PeVvq6E/fhiYfoTy9rs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AvAYX/Vy; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AvAYX/Vy" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 564E7C19422; Fri, 13 Feb 2026 03:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770951935; bh=xy1H1KWisVrqdFCNDf6YZe11NWXWdfjP3WJvVZI50/0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=AvAYX/VybRQDKfBqGIse30m1sc/96Y1356IAkLiD7lhY0jPB7FHEr0MvpGlHm1yp1 BgRvHGPVyDvKyvLZBMhz86HvpH7PesCSfblXboASu7ZUyrY/zLdc2w5ayBybR/zlrl PEnSThEpO3tKfFINiWSfueUE/BcGwi9G7tAB8/dgPyVALKUjF/Z3Wr390p4CMPx5gQ MHSAvP1uQ516t/0nyjh4Fr4Lxu4XARbdKiVEQuOxQe5x/LoyJPoSOgURJiexvqZCLu Bn5FVIU9ac9QE6F6g8JvGoEFbbKHJjTn7JydhKrnpEuLtIZYCOQD5+MpPoXlvxiGgg vMuDj9pAA7fIQ== Date: Thu, 12 Feb 2026 19:05:34 -0800 From: Jakub Kicinski To: Allison Henderson Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, rds-devel@oss.oracle.com, horms@kernel.org, linux-rdma@vger.kernel.org, allison.henderson@oracle.com Subject: Re: [PATCH net v2] net/rds: rds_sendmsg should not discard payload_len Message-ID: <20260212190534.7faf2878@kernel.org> In-Reply-To: <20260210170952.1836306-1-achender@kernel.org> References: <20260210170952.1836306-1-achender@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 10 Feb 2026 10:09:52 -0700 Allison Henderson wrote: > Commit 3db6e0d172c9 ("rds: use RCU to synchronize work-enqueue with > connection teardown") modifies rds_sendmsg to avoid enqueueing work > while a tear down is in progress. However, it also changed the return > value of rds_sendmsg to that of rds_send_xmit instead of the > payload_len. This means the user may incorrectly receive errno values > when it should have simply received a payload of 0 while the peer > attempts a reconnections. So this patch corrects the teardown handling > code to only use the out error path in that case, thus restoring the > original payload_len return value. net-next now became net so this no longer applies. Please rebase? -- pw-bot: cr