public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Antonio Quartulli <antonio@openvpn.net>
To: netdev@vger.kernel.org
Cc: Antonio Quartulli <antonio@openvpn.net>,
	Sabrina Dubroca <sd@queasysnail.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: [PATCH net 0/3] pull request: ovpn for net 2026-02-12
Date: Thu, 12 Feb 2026 22:03:26 +0100	[thread overview]
Message-ID: <20260212210340.11260-1-antonio@openvpn.net> (raw)

Hi netdev-team,

In this batch you can three fixes:

1) ensure that sk_user_data is set before configuring socket callbacks.
This way we avoid dropping early packets received by the CB when the
ovpn data is not yet configured.

2) fix use-after-free in ovpn_net_xmit by not blindly assuming that the
first skb segment will always be valid. It may actually be released by
skb_share_check.

3) properly increase TX stats, by counting bytes of all segments that
have been properly processed, instead of just counting the first segment
only.

Please pull or let me know of any issue!

Thanks a lot.
Antonio,

The following changes since commit bf9cf80cab81e39701861a42877a28295ade266f:

  net: macb: Fix tx/rx malfunction after phy link down and up (2026-02-11 13:13:41 +0100)

are available in the Git repository at:

  https://github.com/OpenVPN/ovpn-net-next.git tags/ovpn-net-20260212

for you to fetch changes up to b660b13d4c6379ca6360f24aaef8c5807fefd237:

  ovpn: fix VPN TX bytes counting (2026-02-12 15:28:59 +0100)

----------------------------------------------------------------
This batch includes the following fixes:
* set sk_user_data before installing callbacks, to avoid dropping early
  packets
* fix use-after-free in ovpn_net_xmit when accessing shared skbs that
  got released
* fix TX bytes stats by adding-up every positively processed GSO
  segment

----------------------------------------------------------------
Ralf Lici (3):
      ovpn: set sk_user_data before overriding callbacks
      ovpn: fix possible use-after-free in ovpn_net_xmit
      ovpn: fix VPN TX bytes counting

 drivers/net/ovpn/io.c     | 55 +++++++++++++++++++++++++++++------------------
 drivers/net/ovpn/socket.c | 39 +++++++++++++++++----------------
 drivers/net/ovpn/tcp.c    |  9 ++++++--
 drivers/net/ovpn/udp.c    |  1 +
 4 files changed, 63 insertions(+), 41 deletions(-)

             reply	other threads:[~2026-02-12 21:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12 21:03 Antonio Quartulli [this message]
2026-02-12 21:03 ` [PATCH net 1/3] ovpn: set sk_user_data before overriding callbacks Antonio Quartulli
2026-02-17 10:30   ` patchwork-bot+netdevbpf
2026-02-12 21:03 ` [PATCH net 2/3] ovpn: fix possible use-after-free in ovpn_net_xmit Antonio Quartulli
2026-02-12 21:03 ` [PATCH net 3/3] ovpn: fix VPN TX bytes counting Antonio Quartulli
2026-02-17 14:35 ` [PATCH net 0/3] pull request: ovpn for net 2026-02-12 Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260212210340.11260-1-antonio@openvpn.net \
    --to=antonio@openvpn.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sd@queasysnail.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox