From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CE321EBA19 for ; Fri, 13 Feb 2026 09:16:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770974176; cv=none; b=u28D0/IwjSbqY89YCuVACTOe9ISwNTDngh5Eglc+lnBdqtxE3ySAd+mVLqCNMRC9gMOOaA76Xnge/wzqrY8LSiHh0I0qKwC58hsNlKWXDLDEfDAVVi2WocoHTATz81AzGW+rHb5PfRCwCPhfENaIx/KDSWn0YMcPeRls6VOlEio= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770974176; c=relaxed/simple; bh=uWdHmJii4Eltf3Y7DYQHeGLCQWqE8sMNnU5SgG5a1H8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZXgwQZqKz1w3R8mivOYUJUYzATjjgqEQvU1Vy9SDTRnqszAjVARkIRQJ+FbPLPPUOtUMySXc5tAZYWLNTzVowsMeKkTbkGAoULvdIstRHlNqonZhLN/k/PBnEGuBpGo+LXlFXSmQJI+DEb/0vqG3crWuRqSswaBpHKcjD1b11t0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ShnHXq8B; arc=none smtp.client-ip=209.85.208.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ShnHXq8B" Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-65a1b17a99aso1241987a12.3 for ; Fri, 13 Feb 2026 01:16:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1770974174; x=1771578974; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+YW2XpxsF2GL4nTKdafPvtP9xVrfkFTi55NUblNEfP8=; b=ShnHXq8BX0fK1i9naB1KwHnhuepAhIUJ4E3oOJKoCe3SIKkNV/nX0+CCKoKHax71P0 mW7ioaHBVTzH08tcKN3yUYpr6gkwx4QwYvJUqDJacnu7zVm9j6EE3WKS3b7qPqqUiP9X DgUF77SyMVcnE5X1uQHfnpzWi3d5Mnv2VEJPoAEEjG/Qno9h+5I9P2ctEqRUGNmfURxv zA+hcNrQ6zxU+qW4m7wbkC2ZJhY7HvNi/N+qin8moN3p3M0XKqDU0HtVZ1wrHFuRcxUf V4eOJr55YElF9taWLT4JjOXWRqbeX6MeA65ys5bRs2xJ5HsOArSM949jSZv1eVIr/+sq F7KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770974174; x=1771578974; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+YW2XpxsF2GL4nTKdafPvtP9xVrfkFTi55NUblNEfP8=; b=Mx8+/sSOLcIIS4K5fs2YoyTE4SUwjb9bJ4bSE0lMDguSNyFz1+t4c7b9Cd2pCUaC5/ Ow/i+NDocdX1DdXXITNOa+3Xv5J9c+GeJd7Sv72J4GFWqToTPs26AFchewepQLGHDBj3 XXmL4daTKGBeyzjp43r4f/OzajEEh4ghgWi6PF/kFgfdyZq7hWULBlJFB+WLweKLUxVy 94JNPmfFAFhj4cjFiGCwPXdmw1c4YKWzRT2a+FSB6wFKFZDWjlvxAdKjl6NZcDNvmmHh vWv1HDJ6Sjmljrb6HgPEYkKxjKShoFm5TB8diyocAxjR4kw+5FdIvhOTnIt9+8ksVrkm M4tQ== X-Forwarded-Encrypted: i=1; AJvYcCV6XokvmSUXsBNiZapDCDEI1tJ8R/Fs0spO9D+iyJYO0I4265OGoF90b4i3SiIIK+RFjG7RkdI=@vger.kernel.org X-Gm-Message-State: AOJu0YzyFdeLOrp2CFCaVfP4viIEbeZ0yDNsmqcDMDpoAWiZTFx3AL91 CoZ9HTB3eoD8crAPqUUoW+eoG01ZO7oRjrhIzpw/ZnmHdAKcwMYmSxVm X-Gm-Gg: AZuq6aJDV9WMROQePHNIeLIrpJjz7geDZvh+RsvvNB2MuPGHXU3MPzRx2oul2sKEAq7 onpZHVBV1faaRWAQb0D1O3Ce74sxMgNca1LWL60AC/yTxCw3aQoSg64F2ZTnyDEXKPVLgpblDKl Kq9h66zBnvt7ChzwEHMdOsWrzsh6yW54VovyY5VdQJ7ZAuc/Vl9pbSIuFlefMR0+l+/7Q74yifv cKmiGOMPfRWNhJJ1lBUncZG/ce/fTW6w9PLNxenh4MR0n63W7sT1NmIIPg1l6BVLcI3ncMEQzRx cbhDdUhrRlW/nyHi63LF2/qSkV8RuMq25Kudp/5nVF31j8UaA+MGfC65VIN+NKXnWzioo8sgxVz Sj27DyN/Gmj1vnFPbHXbzS1WrCF/HCfPeC9i4mM+9gLwFW4ibUuTzIftBDPt1EPiPdyWO62hrBa If/PE= X-Received: by 2002:a17:907:94c4:b0:b8e:d13f:e20f with SMTP id a640c23a62f3a-b8fb452e806mr66008166b.55.1770974173219; Fri, 13 Feb 2026 01:16:13 -0800 (PST) Received: from gmail.com ([2a09:bac5:4e20:2705::3e3:35]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8f84bb7b0fsm194556366b.1.2026.02.13.01.16.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 01:16:12 -0800 (PST) From: Qingfang Deng To: linux-ppp@vger.kernel.org, Michal Ostrowski , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Michal Ostrowski , Dianne Skoll , Paul Mackerras , Jaco Kroon , James Carlson , Arnd Bergmann , Guillaume Nault Subject: [PATCH RFC net-next v2] pppoe: remove kernel-mode relay support Date: Fri, 13 Feb 2026 17:16:04 +0800 Message-ID: <20260213091605.132561-1-dqfext@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The kernel-mode PPPoE relay feature and its two associated ioctls (PPPOEIOCSFWD and PPPOEIOCDFWD) are not used by any existing userspace PPPoE implementations. The most commonly-used package, RP-PPPoE [1], handles the relaying entirely in userspace. This legacy code has remained in the driver since its introduction in kernel 2.3.99-pre7 for over two decades, but has served no practical purpose. Remove the unused relay code. [1] https://dianne.skoll.ca/projects/rp-pppoe/ Signed-off-by: Qingfang Deng --- v1: restore .compat_ioctl https://lore.kernel.org/linux-ppp/20260211075547.138904-1-dqfext@gmail.com/ drivers/net/ppp/pppoe.c | 79 ----------------------------------- drivers/net/ppp/pppox.c | 3 -- include/linux/if_pppox.h | 6 --- include/uapi/linux/if_pppox.h | 10 ----- 4 files changed, 98 deletions(-) diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c index 4275b393a454..7a6dcfa421e9 100644 --- a/drivers/net/ppp/pppoe.c +++ b/drivers/net/ppp/pppoe.c @@ -237,25 +237,6 @@ static inline struct pppox_sock *get_item(struct pppoe_net *pn, __be16 sid, return po; } -static inline struct pppox_sock *__get_item_by_addr(struct net *net, - struct sockaddr_pppox *sp) -{ - struct net_device *dev; - struct pppoe_net *pn; - struct pppox_sock *pppox_sock = NULL; - - int ifindex; - - dev = dev_get_by_name_rcu(net, sp->sa_addr.pppoe.dev); - if (dev) { - ifindex = dev->ifindex; - pn = pppoe_pernet(net); - pppox_sock = __get_item(pn, sp->sa_addr.pppoe.sid, - sp->sa_addr.pppoe.remote, ifindex); - } - return pppox_sock; -} - static inline void delete_item(struct pppoe_net *pn, __be16 sid, char *addr, int ifindex) { @@ -369,7 +350,6 @@ static struct notifier_block pppoe_notifier = { static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb) { struct pppox_sock *po = pppox_sk(sk); - struct pppox_sock *relay_po; /* Backlog receive. Semantics of backlog rcv preclude any code from * executing in lock_sock()/release_sock() bounds; meaning sk->sk_state @@ -378,17 +358,6 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb) if (sk->sk_state & PPPOX_BOUND) { ppp_input(&po->chan, skb); - } else if (sk->sk_state & PPPOX_RELAY) { - relay_po = __get_item_by_addr(sock_net(sk), - &po->pppoe_relay); - if (relay_po == NULL) - goto abort_kfree; - - if ((sk_pppox(relay_po)->sk_state & PPPOX_CONNECTED) == 0) - goto abort_kfree; - - if (!__pppoe_xmit(sk_pppox(relay_po), skb)) - goto abort_kfree; } else { if (sock_queue_rcv_skb(sk, skb)) goto abort_kfree; @@ -656,7 +625,6 @@ static int pppoe_connect(struct socket *sock, struct sockaddr_unsized *uservaddr po->pppoe_ifindex = 0; memset(&po->pppoe_pa, 0, sizeof(po->pppoe_pa)); - memset(&po->pppoe_relay, 0, sizeof(po->pppoe_relay)); memset(&po->chan, 0, sizeof(po->chan)); po->next = NULL; po->num = 0; @@ -783,53 +751,6 @@ static int pppoe_ioctl(struct socket *sock, unsigned int cmd, err = 0; break; - case PPPOEIOCSFWD: - { - struct pppox_sock *relay_po; - - err = -EBUSY; - if (sk->sk_state & (PPPOX_BOUND | PPPOX_DEAD)) - break; - - err = -ENOTCONN; - if (!(sk->sk_state & PPPOX_CONNECTED)) - break; - - /* PPPoE address from the user specifies an outbound - PPPoE address which frames are forwarded to */ - err = -EFAULT; - if (copy_from_user(&po->pppoe_relay, - (void __user *)arg, - sizeof(struct sockaddr_pppox))) - break; - - err = -EINVAL; - if (po->pppoe_relay.sa_family != AF_PPPOX || - po->pppoe_relay.sa_protocol != PX_PROTO_OE) - break; - - /* Check that the socket referenced by the address - actually exists. */ - rcu_read_lock(); - relay_po = __get_item_by_addr(sock_net(sk), &po->pppoe_relay); - rcu_read_unlock(); - if (!relay_po) - break; - - sk->sk_state |= PPPOX_RELAY; - err = 0; - break; - } - - case PPPOEIOCDFWD: - err = -EALREADY; - if (!(sk->sk_state & PPPOX_RELAY)) - break; - - sk->sk_state &= ~PPPOX_RELAY; - err = 0; - break; - default: err = -ENOTTY; } diff --git a/drivers/net/ppp/pppox.c b/drivers/net/ppp/pppox.c index 08364f10a43f..5861a2f6ce3e 100644 --- a/drivers/net/ppp/pppox.c +++ b/drivers/net/ppp/pppox.c @@ -102,9 +102,6 @@ EXPORT_SYMBOL(pppox_ioctl); #ifdef CONFIG_COMPAT int pppox_compat_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg) { - if (cmd == PPPOEIOCSFWD32) - cmd = PPPOEIOCSFWD; - return pppox_ioctl(sock, cmd, (unsigned long)compat_ptr(arg)); } diff --git a/include/linux/if_pppox.h b/include/linux/if_pppox.h index db45d6f1c4f4..8bbf676c2a85 100644 --- a/include/linux/if_pppox.h +++ b/include/linux/if_pppox.h @@ -25,8 +25,6 @@ struct pppoe_opt { struct net_device *dev; /* device associated with socket*/ int ifindex; /* ifindex of device associated with socket */ struct pppoe_addr pa; /* what this socket is bound to*/ - struct sockaddr_pppox relay; /* what socket data will be - relayed to (PPPoE relaying) */ struct work_struct padt_work;/* Work item for handling PADT */ }; @@ -53,7 +51,6 @@ struct pppox_sock { #define pppoe_dev proto.pppoe.dev #define pppoe_ifindex proto.pppoe.ifindex #define pppoe_pa proto.pppoe.pa -#define pppoe_relay proto.pppoe.relay static inline struct pppox_sock *pppox_sk(struct sock *sk) { @@ -80,14 +77,11 @@ extern void pppox_unbind_sock(struct sock *sk);/* delete ppp-channel binding */ extern int pppox_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg); extern int pppox_compat_ioctl(struct socket *sock, unsigned int cmd, unsigned long arg); -#define PPPOEIOCSFWD32 _IOW(0xB1 ,0, compat_size_t) - /* PPPoX socket states */ enum { PPPOX_NONE = 0, /* initial state */ PPPOX_CONNECTED = 1, /* connection established ==TCP_ESTABLISHED */ PPPOX_BOUND = 2, /* bound to ppp device */ - PPPOX_RELAY = 4, /* forwarding is enabled */ PPPOX_DEAD = 16 /* dead, useless, please clean me up!*/ }; diff --git a/include/uapi/linux/if_pppox.h b/include/uapi/linux/if_pppox.h index 9abd80dcc46f..8fdf0a681a4e 100644 --- a/include/uapi/linux/if_pppox.h +++ b/include/uapi/linux/if_pppox.h @@ -103,16 +103,6 @@ struct sockaddr_pppol2tpv3in6 { struct pppol2tpv3in6_addr pppol2tp; } __packed; -/********************************************************************* - * - * ioctl interface for defining forwarding of connections - * - ********************************************************************/ - -#define PPPOEIOCSFWD _IOW(0xB1 ,0, size_t) -#define PPPOEIOCDFWD _IO(0xB1 ,1) -/*#define PPPOEIOCGFWD _IOWR(0xB1,2, size_t)*/ - /* Codes to identify message types */ #define PADI_CODE 0x09 #define PADO_CODE 0x07 -- 2.43.0