From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 431472874FA for ; Fri, 13 Feb 2026 17:59:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771005595; cv=none; b=VvmQhv+HYWHR1WE++F8MYmJVYvLpnYpOpszURorkyAG4yDvj6bmvIMC9EYctcAwO9WQPCuIVITWXRFK6ZIgJX7JElWwg2OpYADGcB4MAb+YghaiTwnIp9JYg2TITqPOOFw9pTgsT0ijKa2Q5Mszf00Q5EVVM6LqPLpoDPQSaL5E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771005595; c=relaxed/simple; bh=xffl/tcUCbwQWS0kee51G6+d5C4oaOgdVrvYRW1YsQg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EjvKgpVJhc/QTfRi5cC+aHysDBvDmJrxVLfuZSrBZT/dgNvy53qlNLdvxcRcshT/Gb+lLxC8KS7hTQ2RyNujG1NGMNp1bBxbPPodwyhRwE6sbDT8CLikOar1b8HWRtpiOZyggJ4jQ96iwFR9abZyG3d/TUIu1K4C9sf0OJexF2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LTJqddxE; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LTJqddxE" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-4043b27ddeaso725676fac.1 for ; Fri, 13 Feb 2026 09:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771005592; x=1771610392; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1+HH55yaDIAkLqPY4ZxIlW7GY63xjVHzwe6z7jmBHtY=; b=LTJqddxEzomKNgtOqzrPMXrIVYLcuhL5Zr1SC/YhV1jmN/hLcCSiq+G69VZXREXt1B ELDOjkTgSUaWoZZfkcC96UMnpdVwtfGkbhosLw1rGer/nfcPRsQaqJEcTqiKsUCaast8 zCEuAgazVYHAaZ3KmCRKBq3m+febHpJlEFuX9TiNgBoHJY1v9Q8ekT/FvAh4ocZTiQKB oB3eawC8TLcWaySwMxGJbFaNWPF4p+KNlgu+wYbMzsYbefzbtq1O5WUZ723Zhrmk0RlM 10tuXiBwVGsETEgivP9UrvXxZjqXecQTpwI3uvc0vjMTH4tMLFiRfo4MtQaR7qwPj7Or 3ZDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771005592; x=1771610392; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1+HH55yaDIAkLqPY4ZxIlW7GY63xjVHzwe6z7jmBHtY=; b=fpI31cfeR4xSfwC8gvrWGkHNlKiNvNMq2RTOMygQTkDR1RX+eOHRRYAbv83TaegMon 6lFoPO3FMLUmj8vkU51iD0GWYfe17IWKzU14/EqyoKLcP2EkNI8vpS1onuGokgZIQ9bW ozWrJJlK+TQtScX5dD1woG4jFUIWQfTyzoNTOpxRo9xbnnyzAz5jQkOLkRHs1zUHuXw5 l8G1Y0kQBRU/kYWeZixoz/88z82msK2sCtnBfZP+CwosIYA5RumMlPafOlJjYKRfft0x hrt2OvlLi6+6LS/rcAd/Y2vkbbB4nZ2D/V8QDOUP9odqhAsSLmVSTJvDqfg9dtCG3np0 BrrA== X-Gm-Message-State: AOJu0YyDnwXmamQBMS1BxzeYXWH5ptX40O5UkRwjXGBWhOMsSL+5TxMq m54ufEELEp0IgyxBlxSD8YF7MjxLiGJbRBwrWCvco3GV9hN5cP+3ZlmtYRDr3Q== X-Gm-Gg: AZuq6aIgUyUjQQMNJFKWEu8ye2Kv+MsGwFbbZ5RF8kZpXIucBa9rsov3sFa3/ZpSr8P OjTpYFWCWmpGt4MBvwkPnfwhmRdtCHuJ6QLOaceXEYTKvBNLAP5aHh08YMirZnvIrMQiA7bkFtM aB07FGZth7mvXyUIhDSJr0dgS8xgVrpA1JYxBupaJWnpkQUkxQpyoMab+txEnZGIzWtkXahtD+u FLY0zb+BJAdzHHnj9R9Cbt5onH8S8vuJZ8Mt9ww8rTHL37D+YUO8CETrDzpEKO3YiIq70B/RJ1m h+t112JrWUCKDJso9T9rN2PWfnmBYdPk9XxaugPXqlIulu7QKNzcBRpqTuf/V/ZZpxWqHgHrolO G4A9Hn8akAcE3WAUB5jJ+wPXMj39gkAV+buugRTMAqZIUSngtdC4tKnGwBdJ2q93Qt/0+jaN3Wf mr/MTOo27AXpCI5a/jmegdyZUzOmA8DWbS6Yq+ck9mzdA6WQAhA6yCjm0F5iUmkE94a2bCUdXn X-Received: by 2002:a05:6870:6985:b0:404:3f0a:9351 with SMTP id 586e51a60fabf-40ef40ebc2dmr1412774fac.52.1771005592394; Fri, 13 Feb 2026 09:59:52 -0800 (PST) Received: from ubuntu-BQM5.tailafa00.ts.net (cs244-84-dhcp.cs.colorado.edu. [128.138.244.84]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-40eaeb42708sm7356270fac.0.2026.02.13.09.59.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 09:59:51 -0800 (PST) From: Ruitong Liu To: netdev@vger.kernel.org Cc: jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, linux-kernel@vger.kernel.org, Ruitong Liu , stable@vger.kernel.org, Shuyuan Liu Subject: [PATCH v3] net/sched: act_skbedit: fix divide-by-zero in tcf_skbedit_hash() Date: Sat, 14 Feb 2026 01:59:48 +0800 Message-Id: <20260213175948.1505257-1-cnitlrt@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260211184848.731894-1-cnitlrt@gmail.com> References: <20260211184848.731894-1-cnitlrt@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Commit 38a6f0865796 ("net: sched: support hash selecting tx queue") added SKBEDIT_F_TXQ_SKBHASH support. The inclusive range size is computed as: mapping_mod = queue_mapping_max - queue_mapping + 1; The range size can be 65536 when the requested range covers all possible u16 queue IDs (e.g. queue_mapping=0 and queue_mapping_max=U16_MAX). That value cannot be represented in a u16 and previously wrapped to 0, so tcf_skbedit_hash() could trigger a divide-by-zero: queue_mapping += skb_get_hash(skb) % params->mapping_mod; Compute mapping_mod in a wider type and reject ranges larger than U16_MAX to prevent params->mapping_mod from becoming 0 and avoid the crash. Fixes: 38a6f0865796 ("net: sched: support hash selecting tx queue") Cc: stable@vger.kernel.org # 6.12+ Reported-by: Ruitong Liu Closes: https://lore.kernel.org/all/20260211184848.731894-1-cnitlrt@gmail.com/ Reported-by: Shuyuan Liu Closes: https://lore.kernel.org/all/20260211184848.731894-1-cnitlrt@gmail.com/ Signed-off-by: Ruitong Liu --- net/sched/act_skbedit.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/net/sched/act_skbedit.c b/net/sched/act_skbedit.c index 8c1d1554f657..5450c1293eb5 100644 --- a/net/sched/act_skbedit.c +++ b/net/sched/act_skbedit.c @@ -126,7 +126,7 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, struct tcf_skbedit *d; u32 flags = 0, *priority = NULL, *mark = NULL, *mask = NULL; u16 *queue_mapping = NULL, *ptype = NULL; - u16 mapping_mod = 1; + u32 mapping_mod = 1; bool exists = false; int ret = 0, err; u32 index; @@ -194,6 +194,10 @@ static int tcf_skbedit_init(struct net *net, struct nlattr *nla, } mapping_mod = *queue_mapping_max - *queue_mapping + 1; + if (mapping_mod > U16_MAX) { + NL_SET_ERR_MSG_MOD(extack, "The range of queue_mapping is invalid."); + return -EINVAL; + } flags |= SKBEDIT_F_TXQ_SKBHASH; } if (*pure_flags & SKBEDIT_F_INHERITDSFIELD) -- 2.34.1