From: Chris J Arges <carges@cloudflare.com>
To: michael.chan@broadcom.com, pavan.chebbi@broadcom.com,
hawk@kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
Stanislav Fomichev <sdf@fomichev.me>
Cc: kernel-team@cloudflare.com, jbrandeburg@cloudflare.com,
Chris J Arges <carges@cloudflare.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
bpf@vger.kernel.org
Subject: [PATCH 1/2] bnxt_en: use bnxt_xdp_buff for xdp context
Date: Fri, 13 Feb 2026 13:24:27 -0600 [thread overview]
Message-ID: <20260213192449.1294830-2-carges@cloudflare.com> (raw)
In-Reply-To: <20260213192449.1294830-1-carges@cloudflare.com>
This adds bnxt_xdp_buff which embeds the xdp_buff struct and stores
pointers to hardware RX completion descriptors (rx_cmp and rx_cmp_ext)
along with the completion type.
Signed-off-by: Chris J Arges <carges@cloudflare.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 24 +++++++++++--------
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 7 ++++++
2 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 8419d1eb4035..4c5e50bad783 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2115,7 +2115,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
bool xdp_active = false;
dma_addr_t dma_addr;
struct sk_buff *skb;
- struct xdp_buff xdp;
+ struct bnxt_xdp_buff bnxt_xdp;
u32 flags, misc;
u32 cmpl_ts;
void *data;
@@ -2228,9 +2228,13 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
dma_addr = rx_buf->mapping;
if (bnxt_xdp_attached(bp, rxr)) {
- bnxt_xdp_buff_init(bp, rxr, cons, data_ptr, len, &xdp);
+ bnxt_xdp.rxcmp = rxcmp;
+ bnxt_xdp.rxcmp1 = rxcmp1;
+ bnxt_xdp.cmp_type = cmp_type;
+
+ bnxt_xdp_buff_init(bp, rxr, cons, data_ptr, len, &bnxt_xdp.xdp);
if (agg_bufs) {
- u32 frag_len = bnxt_rx_agg_netmems_xdp(bp, cpr, &xdp,
+ u32 frag_len = bnxt_rx_agg_netmems_xdp(bp, cpr, &bnxt_xdp.xdp,
cp_cons,
agg_bufs,
false);
@@ -2242,12 +2246,12 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
}
if (xdp_active) {
- if (bnxt_rx_xdp(bp, rxr, cons, &xdp, data, &data_ptr, &len, event)) {
+ if (bnxt_rx_xdp(bp, rxr, cons, &bnxt_xdp.xdp, data, &data_ptr, &len, event)) {
rc = 1;
goto next_rx;
}
- if (xdp_buff_has_frags(&xdp)) {
- sinfo = xdp_get_shared_info_from_buff(&xdp);
+ if (xdp_buff_has_frags(&bnxt_xdp.xdp)) {
+ sinfo = xdp_get_shared_info_from_buff(&bnxt_xdp.xdp);
agg_bufs = sinfo->nr_frags;
} else {
agg_bufs = 0;
@@ -2258,7 +2262,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
if (!xdp_active)
skb = bnxt_copy_skb(bnapi, data_ptr, len, dma_addr);
else
- skb = bnxt_copy_xdp(bnapi, &xdp, len, dma_addr);
+ skb = bnxt_copy_xdp(bnapi, &bnxt_xdp.xdp, len, dma_addr);
bnxt_reuse_rx_data(rxr, cons, data);
if (!skb) {
if (agg_bufs) {
@@ -2266,7 +2270,7 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
bnxt_reuse_rx_agg_bufs(cpr, cp_cons, 0,
agg_bufs, false);
else
- bnxt_xdp_buff_frags_free(rxr, &xdp);
+ bnxt_xdp_buff_frags_free(rxr, &bnxt_xdp.xdp);
}
goto oom_next_rx;
}
@@ -2291,10 +2295,10 @@ static int bnxt_rx_pkt(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
goto oom_next_rx;
} else {
skb = bnxt_xdp_build_skb(bp, skb, agg_bufs,
- rxr->page_pool, &xdp);
+ rxr->page_pool, &bnxt_xdp.xdp);
if (!skb) {
/* we should be able to free the old skb here */
- bnxt_xdp_buff_frags_free(rxr, &xdp);
+ bnxt_xdp_buff_frags_free(rxr, &bnxt_xdp.xdp);
goto oom_next_rx;
}
}
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h
index 220285e190fc..5f60b848fcc4 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h
@@ -12,6 +12,13 @@
DECLARE_STATIC_KEY_FALSE(bnxt_xdp_locking_key);
+struct bnxt_xdp_buff {
+ struct xdp_buff xdp;
+ struct rx_cmp *rxcmp;
+ struct rx_cmp_ext *rxcmp1;
+ u8 cmp_type;
+};
+
struct bnxt_sw_tx_bd *bnxt_xmit_bd(struct bnxt *bp,
struct bnxt_tx_ring_info *txr,
dma_addr_t mapping, u32 len,
--
2.43.0
next prev parent reply other threads:[~2026-02-13 19:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 19:24 [PATCH 0/2] bnxt_en: Add XDP RSS hash metadata Chris J Arges
2026-02-13 19:24 ` Chris J Arges [this message]
2026-02-13 19:24 ` [PATCH 2/2] bnxt_en: Implement XDP RSS hash metadata extraction Chris J Arges
2026-02-14 8:00 ` kernel test robot
2026-02-14 22:37 ` kernel test robot
2026-02-13 19:37 ` [PATCH 0/2] bnxt_en: Add XDP RSS hash metadata Chris Arges
2026-02-13 20:09 ` Jakub Kicinski
2026-02-19 3:07 ` Chris Arges
2026-03-03 2:43 ` [PATCH net-next v2 0/4] bnxt_en: add XDP RSS hash metadata support Chris J Arges
2026-03-03 2:43 ` [PATCH net-next v2 1/4] bnxt_en: use bnxt_xdp_buff for xdp context Chris J Arges
2026-03-03 18:41 ` Joe Damato
2026-03-03 2:43 ` [PATCH net-next v2 2/4] bnxt_en: Implement XDP RSS hash metadata extraction Chris J Arges
2026-03-03 18:22 ` Joe Damato
2026-03-05 2:57 ` [net-next,v2,2/4] " Jakub Kicinski
2026-03-03 2:43 ` [PATCH net-next v2 3/4] selftests: net: move common xdp.py functions into lib Chris J Arges
2026-03-03 18:48 ` Joe Damato
2026-03-03 2:43 ` [PATCH net-next v2 4/4] selftests: drv-net: xdp: Add rss_hash metadata tests Chris J Arges
2026-03-03 18:45 ` [PATCH net-next v2 0/4] bnxt_en: add XDP RSS hash metadata support Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260213192449.1294830-2-carges@cloudflare.com \
--to=carges@cloudflare.com \
--cc=andrew+netdev@lunn.ch \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=jbrandeburg@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@cloudflare.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pavan.chebbi@broadcom.com \
--cc=sdf@fomichev.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox