From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1276E3254B3 for ; Fri, 13 Feb 2026 19:25:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771010722; cv=none; b=jOkjNtFH4TO2qMgBdKyH6s2KX/w0iJgwAQNRnIfy7HGbpBaV4xBo3QWq5Xe58v7x6PnBfbfS9yRvQxkVbLA7tIAkxddVeqvBDFoOkZqOmTMTr/bm0FeeuSn4fAvVt72sf/L/McSg4WOQiO6Lc8WS3avUKrUe+lUxwFypce73HFo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771010722; c=relaxed/simple; bh=8b0QYhOGwS2V2AItVoEQ6N4KsyNesW8120oxsVTsrdE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=OS8UrL73o042vYQ9wkXIsT4kdurzY8Xy4sJYd9EbCGV5MYCziKVP41zLlFexcmlwp+VbR4g5urRr2kY+1wCDcIfqEx6Z/LGb/P8XxNZgfLenQ0v8s/Mq0WDxtcvvuj3jvY4VBLdh6mDdwmvxfdmJFta8Di3r8PqEXVQQK7loBts= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com; spf=pass smtp.mailfrom=cloudflare.com; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b=BTwEf+NU; arc=none smtp.client-ip=209.85.210.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cloudflare.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cloudflare.com header.i=@cloudflare.com header.b="BTwEf+NU" Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-7d195166b2cso891258a34.3 for ; Fri, 13 Feb 2026 11:25:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google09082023; t=1771010716; x=1771615516; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rBbOQadYCksTHWu4+/GITak2TLFEO73uM1y/DwDxxcg=; b=BTwEf+NUWikgGP2Z9hEkRrvoiPCotV+yhzrjddIbSRBoZav835hFauvGiWyvA3IhnT qRj+71vzk0MJcnXfBLMDAjWP+khVCFK/552X8FNp5/SDEI7kgiP1CQTX+QQeElXvU2rJ JKaM8HsGr1fAcRMnXyyVUPeVtN9vFaeQvPikb37bhvqlbTjbUCVS74F9ELUIhCkDLZvi +Rc3hZH+Tg40CxxlhTqFmKJ6JfW1LNKbJa2Pyui4Cla2L0UXZFuIsqkt3NbLfcj87OzI xKMvl2hNCCCQkHHaNwtfXFWUqh5ASiigLJ0mfGP6LcqlWn3flfnI2JVKljLERMfjDOQP pWJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771010716; x=1771615516; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rBbOQadYCksTHWu4+/GITak2TLFEO73uM1y/DwDxxcg=; b=nwQRDhugYp7kjfjj3pnEvZ0lK3QPnZR/JbiufGiGYFI0nQeCGQJEvLFu7qM20XkLRB A7gfUIUUiH9nc9QJtQ9fqOSFcC9B9u6k85G3PMyNiHj6OnbSSmoFfH9GOJLU4O1NWaar jinhAFwWX4sbZvQ5eWQOXmGivd9DqEzhS6FLxEdPF4t2u7+FgeR4AC7CmS09hrJpcP6F 0viIGEHoRLKzHYx3nP9pu+O5aj9NgAMP4NomyXxXFfS38JjsrKHQYTEw5mFmGWtU/HO0 z5HwlsZUEqJM5UUOAE0WGTs9UBNLQsTO7NlcSMyxeFvVgbxOtssHDuv6MpdAQcLuJbT4 YbkQ== X-Forwarded-Encrypted: i=1; AJvYcCULyy7bfO5EX2ppY52BPG6QHQXw/iPAJa3iBCBhHy3xE28tUK6ePuATSQh+BzOpcHcjmqK9zho=@vger.kernel.org X-Gm-Message-State: AOJu0YybJLpSluzYistrI3g3smI7Pqh6FJDiTFoxjgs9/d5HK0joIsKJ +CTEMPGkIAOEx9MFywNkTEmuEWNatzOzNSnL5PLzoVBxFCIFi3tS9zzN8JTica6CGyg= X-Gm-Gg: AZuq6aICYYDoGjZF1rxNk+NEpDg3OMMS+OgfjvVWZQ9MhcemvDU0ipwSRimslCaQ8eF wnHNLEQ1E63b5Dpuo/TGSMuwLBwqJ0o4k22jeWl0CuX7msJ04y3lwXL30Ht4/laSPFjJqMevYSP i/NfEkZFm73K5LISeMT2u6kSAegaqWU1ZviJrnCKxBOcjtysExPkbfP856xITrY6nHZkbs0AS6W uoMSWPVOsDKc/BThSgN2YjHt5aJ45ixG0+zcNv0rWwL+MQw/4i0uqB0O2RZNKReioSEAQq+uBNY l+zYjXCg2QR32SXvRtjDGy27L5L+2RBs5g18d7aLX3ldKf05Gv/j+dPX9ci511TuPmN3Dx7Mr4h 8yK2UKhzm+F+c4Fs9xZHhgpw4Gb4Bd5fEgMstwOzP2Q8fMkvLYtQT6qnNSNqiiVLVoMkA+Fi3WW 1m3tekqzLW X-Received: by 2002:a05:6830:2a8c:b0:7ca:c7b0:17eb with SMTP id 46e09a7af769-7d4c300277amr2066239a34.10.1771010715968; Fri, 13 Feb 2026 11:25:15 -0800 (PST) Received: from 20HS2G4.. ([2a09:bac1:76c0:540::499:50]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d4a76f96b8sm6591407a34.21.2026.02.13.11.25.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Feb 2026 11:25:15 -0800 (PST) From: Chris J Arges To: michael.chan@broadcom.com, pavan.chebbi@broadcom.com, hawk@kernel.org, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Alexei Starovoitov , Daniel Borkmann , John Fastabend , Stanislav Fomichev Cc: kernel-team@cloudflare.com, jbrandeburg@cloudflare.com, Chris J Arges , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org Subject: [PATCH 2/2] bnxt_en: Implement XDP RSS hash metadata extraction Date: Fri, 13 Feb 2026 13:24:28 -0600 Message-ID: <20260213192449.1294830-3-carges@cloudflare.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260213192449.1294830-1-carges@cloudflare.com> References: <20260213192449.1294830-1-carges@cloudflare.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for extracting RSS hash values and hash types from hardware completion descriptors in XDP programs for bnxt_en. Add IP_TYPE definition for determining if completion is ipv4 or ipv6. In addition add ITYPE_ICMP flag for identifying ICMP completions. Signed-off-by: Chris J Arges --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 5 ++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 + drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 47 +++++++++++++++++++ drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h | 2 + 4 files changed, 56 insertions(+) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 4c5e50bad783..42c024e9d974 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -15845,6 +15845,10 @@ static const struct net_device_ops bnxt_netdev_ops = { .ndo_hwtstamp_set = bnxt_hwtstamp_set, }; +static const struct xdp_metadata_ops bnxt_xdp_metadata_ops = { + .xmo_rx_hash = bnxt_xdp_rx_hash, +}; + static void bnxt_get_queue_stats_rx(struct net_device *dev, int i, struct netdev_queue_stats_rx *stats) { @@ -16684,6 +16688,7 @@ static int bnxt_init_one(struct pci_dev *pdev, const struct pci_device_id *ent) goto init_err_free; dev->netdev_ops = &bnxt_netdev_ops; + dev->xdp_metadata_ops = &bnxt_xdp_metadata_ops; dev->stat_ops = &bnxt_stat_ops; dev->watchdog_timeo = BNXT_TX_TIMEOUT; dev->ethtool_ops = &bnxt_ethtool_ops; diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h index f88e7769a838..ef5f71c97c63 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h @@ -232,6 +232,7 @@ struct rx_cmp { #define RX_CMP_FLAGS_ITYPE_UDP (3 << 12) #define RX_CMP_FLAGS_ITYPE_FCOE (4 << 12) #define RX_CMP_FLAGS_ITYPE_ROCE (5 << 12) + #define RX_CMP_FLAGS_ITYPE_ICMP (7 << 12) #define RX_CMP_FLAGS_ITYPE_PTP_WO_TS (8 << 12) #define RX_CMP_FLAGS_ITYPE_PTP_W_TS (9 << 12) #define RX_CMP_LEN (0xffff << 16) @@ -311,6 +312,7 @@ struct rx_cmp_ext { #define RX_CMP_FLAGS2_T_IP_CS_CALC (0x1 << 2) #define RX_CMP_FLAGS2_T_L4_CS_CALC (0x1 << 3) #define RX_CMP_FLAGS2_META_FORMAT_VLAN (0x1 << 4) + #define RX_CMP_FLAGS2_IP_TYPE (0x1 << 8) __le32 rx_cmp_meta_data; #define RX_CMP_FLAGS2_METADATA_TCI_MASK 0xffff #define RX_CMP_FLAGS2_METADATA_VID_MASK 0xfff diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c index c94a391b1ba5..28f7f03662df 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c @@ -472,3 +472,50 @@ bnxt_xdp_build_skb(struct bnxt *bp, struct sk_buff *skb, u8 num_frags, xdp_buff_get_skb_flags(xdp)); return skb; } + +static int bnxt_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash, + enum xdp_rss_hash_type *rss_type) +{ + const struct bnxt_xdp_buff *xdp = (void *)ctx; + const struct rx_cmp *rxcmp = xdp->rxcmp; + const struct rx_cmp_ext *rxcmp1 = xdp->rxcmp1; + u32 itypes; + enum xdp_rss_hash_type hash_type = 0; + + if (!rxcmp || !RX_CMP_HASH_VALID(rxcmp)) + return -ENODATA; + + *hash = le32_to_cpu(rxcmp->rx_cmp_rss_hash); + + if (!rxcmp1) { + *rss_type = XDP_RSS_TYPE_L2; + return 0; + } + + if (xdp->cmp_type == CMP_TYPE_RX_L2_CMP) { + itypes = RX_CMP_ITYPES(rxcmp); + if (rxcmp1->rx_cmp_flags2 & + cpu_to_le32(RX_CMP_FLAGS2_IP_TYPE)) { + hash_type |= XDP_RSS_TYPE_L3_IPV6; + } else { + hash_type |= XDP_RSS_TYPE_L3_IPV4; + } + + switch (itypes) { + case RX_CMP_FLAGS_ITYPE_TCP: + hash_type |= XDP_RSS_L4 | XDP_RSS_L4_TCP; + break; + case RX_CMP_FLAGS_ITYPE_UDP: + hash_type |= XDP_RSS_L4 | XDP_RSS_L4_UDP; + break; + case RX_CMP_FLAGS_ITYPE_ICMP: + hash_type |= XDP_RSS_L4 | XDP_RSS_L4_ICMP; + break; + default: + break; + } + } + + *rss_type = hash_type; + return 0; +} diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h index 5f60b848fcc4..53fed951c151 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.h @@ -41,4 +41,6 @@ void bnxt_xdp_buff_frags_free(struct bnxt_rx_ring_info *rxr, struct sk_buff *bnxt_xdp_build_skb(struct bnxt *bp, struct sk_buff *skb, u8 num_frags, struct page_pool *pool, struct xdp_buff *xdp); +int bnxt_xdp_rx_hash(const struct xdp_md *ctx, u32 *hash, + enum xdp_rss_hash_type *rss_type); #endif -- 2.43.0