From: Kohei Enju <kohei@enjuk.jp>
To: kohei@enjuk.jp
Cc: andrew+netdev@lunn.ch, anthony.l.nguyen@intel.com,
davem@davemloft.net, edumazet@google.com, horms@kernel.org,
intel-wired-lan@lists.osuosl.org, jedrzej.jagielski@intel.com,
kohei.enju@gmail.com, kuba@kernel.org,
mateusz.palczewski@intel.com, netdev@vger.kernel.org,
pabeni@redhat.com, przemyslaw.kitszel@intel.com,
przemyslawx.patynowski@intel.com, witoldx.fijalkowski@intel.com
Subject: Re: [PATCH v1 iwl-net] iavf: fix out-of-bounds writes in iavf_get_ethtool_stats()
Date: Mon, 16 Feb 2026 15:17:31 +0000 [thread overview]
Message-ID: <20260216151802.24884-1-kohei@enjuk.jp> (raw)
In-Reply-To: <20260216144457.19871-1-kohei@enjuk.jp>
On Mon, 16 Feb 2026 14:44:57 +0000, Kohei Enju wrote:
> The scenario flow lacked netdev_(un)lock, my bad.
>
> Thread 1 (ethtool -L) Thread 2 (work) Thread 3 (ethtool -S)
> netdev_lock()
> iavf_set_channels()
> ...
> iavf_alloc_queues()
> -> alloc {tx,rx}_rings
> -> num_active_queues = 8
> iavf_schedule_finish_config()
> netdev_unlock()
> netdev_lock()
> iavf_get_sset_count()
> real_num_tx_queues: 1
> -> buffer for 1 queue
> iavf_get_ethtool_stats()
> num_active_queues: 8
> -> out-of-bounds!
> netdev_unlock()
> iavf_finish_config()
> netdev_lock()
> -> real_num_tx_queues = 8
> netdev_unlock()
Note that the flow of Thread 1 is based on a recent commit
b542fa9dd830 ("iavf: fix incorrect reset handling in callbacks") in
tnguy/net-queue.git.
next prev parent reply other threads:[~2026-02-16 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-14 19:14 [PATCH v1 iwl-net] iavf: fix out-of-bounds writes in iavf_get_ethtool_stats() Kohei Enju
2026-02-16 13:19 ` Simon Horman
2026-02-16 14:44 ` Kohei Enju
2026-02-16 15:17 ` Kohei Enju [this message]
2026-02-17 16:02 ` Simon Horman
2026-02-18 5:39 ` Przemek Kitszel
2026-02-18 6:31 ` Kohei Enju
2026-02-18 8:00 ` [Intel-wired-lan] " Paul Menzel
2026-03-19 9:14 ` Romanowski, Rafal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260216151802.24884-1-kohei@enjuk.jp \
--to=kohei@enjuk.jp \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jedrzej.jagielski@intel.com \
--cc=kohei.enju@gmail.com \
--cc=kuba@kernel.org \
--cc=mateusz.palczewski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=przemyslawx.patynowski@intel.com \
--cc=witoldx.fijalkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox