public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net] net: Drop the lock in skb_may_tx_timestamp()
Date: Tue, 17 Feb 2026 14:28:38 +0100	[thread overview]
Message-ID: <20260217132838.kgRAQ87W@linutronix.de> (raw)
In-Reply-To: <willemdebruijn.kernel.3b597169afaae@gmail.com>

On 2026-02-16 13:08:43 [-0500], Willem de Bruijn wrote:
> It will be great to have this additional context in the commit
> message.
> 
> And a Link: to the original discussion thread.

Okay.

> Btw, the commit states that a few drivers already call this from their
> hard interrupt handler. Can you point to one or two?

- bxcan_tx_isr() -> can_get_echo_skb() -> __can_get_echo_skb() ->
  skb_tstamp_tx()

- at91_irq() -> at91_irq_tx() -> can_get_echo_skb() -> … ->
  skb_tstamp_tx()

- hclge_misc_irq_handle() -> hclge_ptp_clean_tx_hwts() ->
  skb_tstamp_tx()

- igc_intr_msi() -> igc_tsync_interrupt() -> igc_ptp_tx_tstamp_event()
  -> igc_ptp_tx_hwtstamp() -> igc_ptp_tx_reg_to_stamp() ->
  skb_tstamp_tx()

> If this is only for new drivers, it would be vastly preferable if this
> can go through net-next.

I found three, I knew about igc. I don't mind net-next but if we keep
the stable tag, it will be backported anyway, it will just take longer.
But if we want to do this in order to catch problems with it before it
hits stable then it makes sense.

Sebastian

  reply	other threads:[~2026-02-17 13:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-14 23:24 [PATCH net] net: Drop the lock in skb_may_tx_timestamp() Sebastian Andrzej Siewior
2026-02-15  4:05 ` Willem de Bruijn
2026-02-15 18:46   ` Sebastian Andrzej Siewior
2026-02-16 16:47     ` Vadim Fedorenko
2026-02-16 18:08       ` Willem de Bruijn
2026-02-17 13:28         ` Sebastian Andrzej Siewior [this message]
2026-02-17 14:14           ` Willem de Bruijn
2026-02-17 12:13       ` Sebastian Andrzej Siewior
2026-02-17  7:48     ` Jason Xing
2026-02-17 14:44       ` Sebastian Andrzej Siewior
2026-02-17  8:01 ` Eric Dumazet
2026-02-17 14:45   ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260217132838.kgRAQ87W@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vadim.fedorenko@linux.dev \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox